Files
marketingskills/validate-skills.sh
T
Corey Haines 30f9b9a729 feat: v2.0 skill renames and CRO consolidation (#291)
* feat: v2.0 skill renames and CRO consolidation

BREAKING CHANGE: Users must reinstall skills after this update.

## Skill Renames (16)
- ab-test-setup → ab-testing
- analytics-tracking → analytics
- aso-audit → aso
- competitor-alternatives → competitors
- email-sequence → emails
- free-tool-strategy → free-tools
- launch-strategy → launch
- onboarding-cro → onboarding
- paywall-upgrade-cro → paywalls
- popup-cro → popups
- pricing-strategy → pricing
- product-marketing-context → product-marketing
- referral-program → referrals
- schema-markup → schema
- signup-flow-cro → signup
- social-content → social

## Consolidations (1)
- page-cro + form-cro → cro (form content in references/form.md)

## Why 2.0?
- Shorter, cleaner skill names
- Consistent naming (no -strategy, -setup, -cro suffixes)
- All cross-references updated across 100+ files

Total skills: 40

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(v2.0): update evals for renamed skills, fix validate script, clear warnings

- Update 32 evals.json files to reference new skill names (page-cro → cro,
  product-marketing-context → product-marketing, etc.) — these were missed
  in the initial v2.0 rename pass since only SKILL.md and marketplace.json
  were updated.
- Fix validate-skills.sh: replace GNU-only `head -n -1` with portable awk
  so frontmatter extraction works on macOS.
- Move Copy Editing Checklist (56 lines) to references/checklist.md to
  bring copy-editing SKILL.md under the 500-line limit (508 → 457).
- Add "see X" pointers to marketing-psychology description for skill
  discovery (cro, pricing, copywriting).
- Update skill-request.yml issue template placeholder (page-cro → cro).

All 40 skills now pass validation with zero warnings.

* fix(v2.0): add evals for 8 missing skills, strip stale frontmatter from cro/form.md

Adds 48 new eval cases (6 per skill) for skills that previously had no evals:
aso, co-marketing, community-marketing, competitor-profiling, directory-submissions,
image, lead-magnets, video. All 40 skills now have eval coverage (251 total cases).

Strips leftover frontmatter from skills/cro/references/form.md — it was inherited
from the old form-cro SKILL.md before consolidation. Reference files don't need
frontmatter.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(v2.0): rename paid-ads → ads

One more v2.0 simplification — drops the redundant 'paid-' qualifier. Updates
the skill directory, SKILL.md frontmatter, evals.json, README skill table, the
v2.0 rename table in VERSIONS.md (now 17 renames), and all cross-references in
related skills (ad-creative, aso, competitor-profiling, customer-research,
lead-magnets, marketing-ideas) plus the tools/integrations guides.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(v2.0): bump SKILL.md frontmatter version to 2.0.0 for all 40 skills

VERSIONS.md was already updated to 2.0.0 but the metadata.version field inside
each SKILL.md was still on 1.x. That mismatch would have caused the update-check
flow to perpetually report 'update available' since it compares VERSIONS.md
against local SKILL.md metadata versions.

Caught by codex review (P1).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(v2.0): add legacy product-marketing-context.md filename fallback

Before this fix, users upgrading from v1.x who had a `product-marketing-context.md`
file would lose automatic context loading — every skill only checked the new
`product-marketing.md` filename. Now all 40 skills also accept the legacy
filename (in either `.agents/` or `.claude/`), and the README migration command
covers both legacy and current filenames.

Caught by codex review (P1 + P2).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(v2.0): re-sort README skills table alphabetically, fix ads box width

The skills table had a few entries out of alphabetical order from the renames
(co-marketing was after cold-email, ads was at the renamed position).
Re-sorted alphabetically per sync-skills.js. Also padded the 'ads' cell in the
ASCII flow diagram to keep the box width consistent.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(v2.0): document folder cleanup on upgrade, stop sync-skills from re-adding skills array

README upgrade guide now includes:
- A clear cleanup step for stale v1.x skill folders (renamed + consolidated) so
  users don't end up with both old and new folders side-by-side after upgrading
- The full v1 to v2 rename map for reference
- Existing product-marketing-context.md migration steps (preserved)

sync-skills.js no longer (re-)introduces a `skills` array on marketplace.json --
Claude Code's plugin schema discovers skills via the `skills/` directory, and the
explicit array was failing validation. The script now refreshes the description
count and strips the stale array if present.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-05-13 22:05:15 -07:00

170 lines
5.7 KiB
Bash
Executable File

#!/bin/bash
# Colors for output
RED='\033[0;31m'
GREEN='\033[0;32m'
YELLOW='\033[1;33m'
BLUE='\033[0;34m'
NC='\033[0m' # No Color
SKILLS_DIR="skills"
ISSUES=0
WARNINGS=0
PASSED=0
echo "🔍 Auditing Skills Against Agent Skills Specification"
echo "======================================================"
echo ""
echo "Reference: https://agentskills.io/specification.md"
echo ""
# Validation rules from CLAUDE.md
# REQUIRED: name, description
# OPTIONAL: license, metadata
# name: 1-64 chars, lowercase a-z, numbers, hyphens only, must match directory
# description: 1-1024 chars with trigger phrases
# SKILL.md: under 500 lines
# Optional dirs: references/, scripts/, assets/
for skill_dir in "$SKILLS_DIR"/*/; do
skill_name=$(basename "$skill_dir")
skill_file="$skill_dir/SKILL.md"
skill_errors=()
skill_warnings=()
# Check if SKILL.md exists
if [[ ! -f "$skill_file" ]]; then
echo -e "${RED}$skill_name${NC}"
echo " Missing SKILL.md"
((ISSUES++))
continue
fi
# Extract frontmatter (between the first two `---` markers, exclusive)
frontmatter=$(awk '/^---$/{count++; next} count==1' "$skill_file")
# Validate frontmatter exists
if [[ -z "$frontmatter" ]]; then
echo -e "${RED}$skill_name${NC}"
echo " Missing YAML frontmatter (---)"
((ISSUES++))
continue
fi
# ===== NAME VALIDATION =====
name_in_file=$(echo "$frontmatter" | grep "^name:" | sed 's/^name: //' | tr -d ' ')
if [[ -z "$name_in_file" ]]; then
skill_errors+=("Missing 'name' field in frontmatter")
elif [[ "$name_in_file" != "$skill_name" ]]; then
skill_errors+=("Name mismatch: directory='$skill_name' but frontmatter='$name_in_file'")
elif ! [[ "$name_in_file" =~ ^[a-z0-9]([a-z0-9-]{0,62}[a-z0-9])?$ ]]; then
skill_errors+=("Invalid name format: '$name_in_file' (must be lowercase, alphanumeric + hyphens only)")
elif [[ ${#name_in_file} -lt 1 || ${#name_in_file} -gt 64 ]]; then
skill_errors+=("Name length invalid: ${#name_in_file} chars (must be 1-64)")
fi
# ===== DESCRIPTION VALIDATION =====
# Handle both quoted and unquoted descriptions
description=$(echo "$frontmatter" | grep "^description:" | head -1)
if [[ $description == *'description: "'* ]]; then
# Quoted description - extract between quotes
description=$(echo "$description" | sed 's/^description: "//' | sed 's/"$//')
else
# Unquoted description
description=$(echo "$description" | sed 's/^description: //')
fi
if [[ -z "$description" ]]; then
skill_errors+=("Missing 'description' field in frontmatter")
else
desc_len=${#description}
if [[ $desc_len -lt 1 || $desc_len -gt 1024 ]]; then
skill_errors+=("Description length invalid: $desc_len chars (must be 1-1024)")
fi
# Check for trigger phrases (When, when to use, mentions, etc.)
if ! echo "$description" | grep -qi "when\|mention\|use"; then
skill_warnings+=("Description lacks clear trigger phrases ('when', 'mention', 'use')")
fi
# Check for related skills reference (scope boundaries)
if ! echo "$description" | grep -qi "see\|for\|ref"; then
skill_warnings+=("Description lacks related skills reference (e.g., 'For X, see Y')")
fi
fi
# ===== OPTIONAL FIELDS VALIDATION =====
license=$(echo "$frontmatter" | grep "^license:" | sed 's/^license: //' | tr -d ' ')
if [[ -n "$license" && "$license" != "MIT" && "$license" != "Apache-2.0" && "$license" != "ISC" ]]; then
skill_warnings+=("License '$license' is non-standard (default: MIT)")
fi
# Check metadata structure
metadata=$(echo "$frontmatter" | grep -A 10 "^metadata:")
if [[ -n "$metadata" ]]; then
# If metadata exists, check for version placement
if echo "$frontmatter" | grep -q "^version:"; then
skill_errors+=("'version' is top-level (should be under 'metadata:')")
fi
# Could add more metadata validation here
fi
# ===== FILE STRUCTURE VALIDATION =====
line_count=$(wc -l < "$skill_file")
if [[ $line_count -gt 500 ]]; then
skill_warnings+=("SKILL.md is $line_count lines (should be <500, move details to references/)")
fi
# Check for optional directories
for optdir in references scripts assets; do
if [[ -d "$skill_dir/$optdir" ]]; then
# Just note its presence - no validation required
:
fi
done
# ===== REPORT RESULTS =====
if [[ ${#skill_errors[@]} -gt 0 ]]; then
echo -e "${RED}$skill_name${NC}"
for error in "${skill_errors[@]}"; do
echo -e " ${RED}Error:${NC} $error"
done
if [[ ${#skill_warnings[@]} -gt 0 ]]; then
for warning in "${skill_warnings[@]}"; do
echo -e " ${YELLOW}Warning:${NC} $warning"
done
fi
((ISSUES++))
elif [[ ${#skill_warnings[@]} -gt 0 ]]; then
echo -e "${YELLOW}⚠️ $skill_name${NC}"
for warning in "${skill_warnings[@]}"; do
echo -e " ${YELLOW}Warning:${NC} $warning"
done
((WARNINGS++))
else
echo -e "${GREEN}$skill_name${NC}"
((PASSED++))
fi
done
echo ""
echo "======================================================"
echo "Summary:"
echo -e " ${GREEN}✓ Passed: $PASSED${NC}"
if [[ $WARNINGS -gt 0 ]]; then
echo -e " ${YELLOW}⚠️ Warnings: $WARNINGS${NC}"
fi
if [[ $ISSUES -gt 0 ]]; then
echo -e " ${RED}❌ Issues: $ISSUES${NC}"
fi
echo ""
if [[ $ISSUES -eq 0 ]]; then
echo -e "${GREEN}All skills are valid! ✓${NC}"
exit 0
else
echo -e "${RED}Found $ISSUES issue(s) that need fixing.${NC}"
exit 1
fi