luna/oh-my-opencode
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(codex): harden lsp post tool hook

Browse Source
This commit is contained in:
YeonGyu-Kim
2026-05-31 05:41:23 +09:00
parent 19f1c3418f
commit 0f5a796739
5 changed files with 75 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/omo-codex/plugin/components/lsp/test/codex-hook-cli.test.ts
+28
View File
@@ -0,0 +1,28 @@
import { spawnSync } from "node:child_process";
import path from "node:path";
import { fileURLToPath } from "node:url";
import { describe, expect, it } from "vitest";
describe("codex PostToolUse hook CLI", () => {
it("#given malformed post-tool-use stdin #when hook CLI runs #then it no-ops without stderr", () => {
// given
const input = "break;\n";
// when
const result = runBuiltHookCli(input);
// then
expect(result.status).toBe(0);
expect(result.stderr).toBe("");
expect(result.stdout).toBe("");
});
});
function runBuiltHookCli(input: string): ReturnType<typeof spawnSync> {
const cliPath = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "../dist/cli.js");
return spawnSync(process.execPath, [cliPath, "hook", "post-tool-use"], {
input,
encoding: "utf8",
});
}
packages/omo-codex/plugin/components/lsp/test/package-smoke.test.ts
+7 -5
View File
@@ -56,6 +56,7 @@ describe("plugin package metadata", () => {
const hooksJson = readHooksJson("hooks/hooks.json");
const mcpJson = readMcpJson(".mcp.json");
const cliSource = readFileSync("src/cli.ts", "utf8");
const codexHookCliSource = readFileSync("src/codex-hook-cli.ts", "utf8");
const codexHookSource = readFileSync("src/codex-hook.ts", "utf8");
const sourceFiles = readdirSync("src");
@@ -79,11 +80,12 @@ describe("plugin package metadata", () => {
expect(lspServer?.command).toBe("node");
expect(lspServer?.args).toEqual(["../../../../lsp-tools-mcp/dist/cli.js", "mcp"]);
expect(cliSource).not.toContain("./lazy-lsp-mcp.js");
expect(cliSource).not.toContain("@code-yeongyu/lsp-tools-mcp");
expect(cliSource).toContain("../../../../../lsp-tools-mcp/dist/cli.js");
expect(codexHookSource).not.toContain("@code-yeongyu/lsp-tools-mcp");
expect(codexHookSource).toContain("../../../../../lsp-tools-mcp/dist/lsp/manager.js");
expect(codexHookSource).toContain("../../../../../lsp-tools-mcp/dist/tools.js");
expect(cliSource).toContain("@code-yeongyu/lsp-tools-mcp/dist/cli.js");
expect(cliSource).not.toContain("../../../../../lsp-tools-mcp/dist/cli.js");
expect(codexHookCliSource).toContain("@code-yeongyu/lsp-tools-mcp/dist/lsp/manager.js");
expect(codexHookSource).toContain("@code-yeongyu/lsp-tools-mcp/dist/tools.js");
expect(codexHookCliSource).not.toContain("../../../../../lsp-tools-mcp/dist/lsp/manager.js");
expect(codexHookSource).not.toContain("../../../../../lsp-tools-mcp/dist/tools.js");
expect(sourceFiles.filter((name) => name.startsWith("lazy-mcp") || name === "lazy-lsp-mcp.ts")).toEqual([]);
});