fix(config): allow Sisyphus-Junior agent customization via oh-my-opencode.json (#648)

* fix(config): allow Sisyphus-Junior agent customization via oh-my-opencode.json Allow users to configure Sisyphus-Junior agent via agents["Sisyphus-Junior"] in oh-my-opencode.json, removing hardcoded defaults while preserving safety constraints. Closes #623 Changes: - Add "Sisyphus-Junior" to AgentOverridesSchema and OverridableAgentNameSchema - Create createSisyphusJuniorAgentWithOverrides() helper with guardrails - Update config-handler to use override helper instead of hardcoded values - Fix README category wording (runtime presets, not separate agents) Honored override fields: - model, temperature, top_p, tools, permission, description, color, prompt_append Safety guardrails enforced post-merge: - mode forced to "subagent" (cannot change) - prompt is append-only (base discipline text preserved) - blocked tools (task, sisyphus_task, call_omo_agent) always denied - disable: true ignores override block, uses defaults Category interaction: - sisyphus_task(category=...) runs use the base Sisyphus-Junior agent config - Category model/temperature overrides take precedence at request time - To change model for a category, set categories.<cat>.model (not agent override) - Categories are runtime presets applied to Sisyphus-Junior, not separate agents Tests: 15 new tests in sisyphus-junior.test.ts, 3 new schema tests Co-Authored-By: Sisyphus <sisyphus@mengmota.com> * test(sisyphus-junior): add guard assertion for prompt anchor text Add validation that baseEndIndex is not -1 before using it for ordering assertion. Previously, if "Dense > verbose." text changed in the base prompt, indexOf would return -1 and any positive appendIndex would pass. Co-Authored-By: Sisyphus <sisyphus@mengmota.com> --------- Co-authored-by: Sisyphus <sisyphus@mengmota.com>
2026-01-12 19:46:47 +11:00
parent c79235744b
commit 0fada4d0fc
8 changed files with 502 additions and 7 deletions
@@ -0,0 +1,230 @@
+import { describe, expect, test } from "bun:test"
+import { createSisyphusJuniorAgentWithOverrides, SISYPHUS_JUNIOR_DEFAULTS } from "./sisyphus-junior"
+
+describe("createSisyphusJuniorAgentWithOverrides", () => {
+  describe("honored fields", () => {
+    test("applies model override", () => {
+      // #given
+      const override = { model: "openai/gpt-5.2" }
+
+      // #when
+      const result = createSisyphusJuniorAgentWithOverrides(override)
+
+      // #then
+      expect(result.model).toBe("openai/gpt-5.2")
+    })
+
+    test("applies temperature override", () => {
+      // #given
+      const override = { temperature: 0.5 }
+
+      // #when
+      const result = createSisyphusJuniorAgentWithOverrides(override)
+
+      // #then
+      expect(result.temperature).toBe(0.5)
+    })
+
+    test("applies top_p override", () => {
+      // #given
+      const override = { top_p: 0.9 }
+
+      // #when
+      const result = createSisyphusJuniorAgentWithOverrides(override)
+
+      // #then
+      expect(result.top_p).toBe(0.9)
+    })
+
+    test("applies description override", () => {
+      // #given
+      const override = { description: "Custom description" }
+
+      // #when
+      const result = createSisyphusJuniorAgentWithOverrides(override)
+
+      // #then
+      expect(result.description).toBe("Custom description")
+    })
+
+    test("applies color override", () => {
+      // #given
+      const override = { color: "#FF0000" }
+
+      // #when
+      const result = createSisyphusJuniorAgentWithOverrides(override)
+
+      // #then
+      expect(result.color).toBe("#FF0000")
+    })
+
+    test("appends prompt_append to base prompt", () => {
+      // #given
+      const override = { prompt_append: "Extra instructions here" }
+
+      // #when
+      const result = createSisyphusJuniorAgentWithOverrides(override)
+
+      // #then
+      expect(result.prompt).toContain("You work ALONE")
+      expect(result.prompt).toContain("Extra instructions here")
+    })
+  })
+
+  describe("defaults", () => {
+    test("uses default model when no override", () => {
+      // #given
+      const override = {}
+
+      // #when
+      const result = createSisyphusJuniorAgentWithOverrides(override)
+
+      // #then
+      expect(result.model).toBe(SISYPHUS_JUNIOR_DEFAULTS.model)
+    })
+
+    test("uses default temperature when no override", () => {
+      // #given
+      const override = {}
+
+      // #when
+      const result = createSisyphusJuniorAgentWithOverrides(override)
+
+      // #then
+      expect(result.temperature).toBe(SISYPHUS_JUNIOR_DEFAULTS.temperature)
+    })
+  })
+
+  describe("disable semantics", () => {
+    test("disable: true causes override block to be ignored", () => {
+      // #given
+      const override = {
+        disable: true,
+        model: "openai/gpt-5.2",
+        temperature: 0.9,
+      }
+
+      // #when
+      const result = createSisyphusJuniorAgentWithOverrides(override)
+
+      // #then - defaults should be used, not the overrides
+      expect(result.model).toBe(SISYPHUS_JUNIOR_DEFAULTS.model)
+      expect(result.temperature).toBe(SISYPHUS_JUNIOR_DEFAULTS.temperature)
+    })
+  })
+
+  describe("constrained fields", () => {
+    test("mode is forced to subagent", () => {
+      // #given
+      const override = { mode: "primary" as const }
+
+      // #when
+      const result = createSisyphusJuniorAgentWithOverrides(override)
+
+      // #then
+      expect(result.mode).toBe("subagent")
+    })
+
+    test("prompt override is ignored (discipline text preserved)", () => {
+      // #given
+      const override = { prompt: "Completely new prompt that replaces everything" }
+
+      // #when
+      const result = createSisyphusJuniorAgentWithOverrides(override)
+
+      // #then
+      expect(result.prompt).toContain("You work ALONE")
+      expect(result.prompt).not.toBe("Completely new prompt that replaces everything")
+    })
+  })
+
+  describe("tool safety (blocked tools enforcement)", () => {
+    test("blocked tools remain blocked even if override tries to enable them via tools format", () => {
+      // #given
+      const override = {
+        tools: {
+          task: true,
+          sisyphus_task: true,
+          call_omo_agent: true,
+          read: true,
+        },
+      }
+
+      // #when
+      const result = createSisyphusJuniorAgentWithOverrides(override)
+
+      // #then
+      const tools = result.tools as Record<string, boolean> | undefined
+      const permission = result.permission as Record<string, string> | undefined
+      if (tools) {
+        expect(tools.task).toBe(false)
+        expect(tools.sisyphus_task).toBe(false)
+        expect(tools.call_omo_agent).toBe(false)
+        expect(tools.read).toBe(true)
+      }
+      if (permission) {
+        expect(permission.task).toBe("deny")
+        expect(permission.sisyphus_task).toBe("deny")
+        expect(permission.call_omo_agent).toBe("deny")
+      }
+    })
+
+    test("blocked tools remain blocked when using permission format override", () => {
+      // #given
+      const override = {
+        permission: {
+          task: "allow",
+          sisyphus_task: "allow",
+          call_omo_agent: "allow",
+          read: "allow",
+        },
+      } as { permission: Record<string, string> }
+
+      // #when
+      const result = createSisyphusJuniorAgentWithOverrides(override as Parameters<typeof createSisyphusJuniorAgentWithOverrides>[0])
+
+      // #then - blocked tools should be denied regardless
+      const tools = result.tools as Record<string, boolean> | undefined
+      const permission = result.permission as Record<string, string> | undefined
+      if (tools) {
+        expect(tools.task).toBe(false)
+        expect(tools.sisyphus_task).toBe(false)
+        expect(tools.call_omo_agent).toBe(false)
+      }
+      if (permission) {
+        expect(permission.task).toBe("deny")
+        expect(permission.sisyphus_task).toBe("deny")
+        expect(permission.call_omo_agent).toBe("deny")
+      }
+    })
+  })
+
+  describe("prompt composition", () => {
+    test("base prompt contains discipline constraints", () => {
+      // #given
+      const override = {}
+
+      // #when
+      const result = createSisyphusJuniorAgentWithOverrides(override)
+
+      // #then
+      expect(result.prompt).toContain("Sisyphus-Junior")
+      expect(result.prompt).toContain("You work ALONE")
+      expect(result.prompt).toContain("BLOCKED ACTIONS")
+    })
+
+    test("prompt_append is added after base prompt", () => {
+      // #given
+      const override = { prompt_append: "CUSTOM_MARKER_FOR_TEST" }
+
+      // #when
+      const result = createSisyphusJuniorAgentWithOverrides(override)
+
+      // #then
+      const baseEndIndex = result.prompt!.indexOf("Dense > verbose.")
+      const appendIndex = result.prompt!.indexOf("CUSTOM_MARKER_FOR_TEST")
+      expect(baseEndIndex).not.toBe(-1) // Guard: anchor text must exist in base prompt
+      expect(appendIndex).toBeGreaterThan(baseEndIndex)
+    })
+  })
+})