luna/oh-my-opencode
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(council-archive): add movePromptFile error logging and fix isPathEscaping false positives

Browse Source 
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This commit is contained in:
ismeth
2026-03-01 19:38:12 +01:00
committed by YeonGyu-Kim
parent 06deead1e7
commit 17ac08a02b
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/tools/council-archive/council-finalize-helpers.ts
+5 -3
View File
@@ -1,4 +1,4 @@
import { readFile, writeFile, rename } from "node:fs/promises" import { readFile, writeFile, rename, unlink } from "node:fs/promises"
import { join, isAbsolute, resolve, relative } from "node:path" import { join, isAbsolute, resolve, relative } from "node:path"
import { log } from "../../shared/logger" import { log } from "../../shared/logger"
@@ -24,7 +24,7 @@ export function extractAgentFromFrontmatter(content: string): string | null {
export function isPathEscaping(expectedRoot: string, targetPath: string): boolean { export function isPathEscaping(expectedRoot: string, targetPath: string): boolean {
const rel = relative(expectedRoot, targetPath) const rel = relative(expectedRoot, targetPath)
return rel.startsWith("..") || isAbsolute(rel) return rel === ".." || rel.startsWith("../") || rel.startsWith("..\\") || isAbsolute(rel)
} }
export async function movePromptFile( export async function movePromptFile(
@@ -42,9 +42,11 @@ export async function movePromptFile(
return undefined return undefined
} }
const absPromptDest = join(absArchiveDir, promptFilename) const absPromptDest = join(absArchiveDir, promptFilename)
await rename(absPromptSrc, absPromptDest).catch(async () => { await rename(absPromptSrc, absPromptDest).catch(async (renameErr) => {
log("[council-finalize] Rename failed, falling back to copy", { promptFile: promptFilePath, error: String(renameErr) })
const content = await readFile(absPromptSrc, "utf-8") const content = await readFile(absPromptSrc, "utf-8")
await writeFile(absPromptDest, content, "utf-8") await writeFile(absPromptDest, content, "utf-8")
await unlink(absPromptSrc).catch(() => {})
}) })
return toPosixPath(join(relArchiveDir, promptFilename)) return toPosixPath(join(relArchiveDir, promptFilename))
} catch (err) { } catch (err) {