fix(todo-continuation): normalize prompt agent
Todo continuation could reinject with a lowercase built-in config key such as hephaestus when no registered alias was available. OpenCode prompt dispatch expects the prompt-facing agent name, so the continuation failed with an agent-not-found error. Normalize the dispatch fallback through the existing prompt agent display-name resolver and pin the lowercase Hephaestus regression.
This commit is contained in:
@@ -0,0 +1,48 @@
|
|||||||
|
/// <reference path="../../../bun-test.d.ts" />
|
||||||
|
|
||||||
|
import { afterEach, describe, expect, test } from "bun:test"
|
||||||
|
|
||||||
|
import { unsafeTestValue } from "../../../test-support/unsafe-test-value"
|
||||||
|
|
||||||
|
import { releaseAllPromptAsyncReservationsForTesting } from "../shared/prompt-async-gate"
|
||||||
|
import { injectContinuation } from "./continuation-injection"
|
||||||
|
|
||||||
|
describe("injectContinuation agent names", () => {
|
||||||
|
afterEach(() => {
|
||||||
|
releaseAllPromptAsyncReservationsForTesting()
|
||||||
|
})
|
||||||
|
|
||||||
|
test("#given resolved agent is a lowercase built-in config key #when continuation is injected #then promptAsync receives the registered display name", async () => {
|
||||||
|
// given
|
||||||
|
let capturedAgent: string | undefined
|
||||||
|
const ctx = unsafeTestValue<Parameters<typeof injectContinuation>[0]["ctx"]>({
|
||||||
|
directory: "/tmp/test",
|
||||||
|
client: {
|
||||||
|
session: {
|
||||||
|
todo: async () => ({ data: [{ id: "1", content: "todo", status: "pending", priority: "high" }] }),
|
||||||
|
promptAsync: async (input: { body: { agent?: string } }) => {
|
||||||
|
capturedAgent = input.body.agent
|
||||||
|
return {}
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
})
|
||||||
|
const sessionStateStore = unsafeTestValue<Parameters<typeof injectContinuation>[0]["sessionStateStore"]>({
|
||||||
|
getExistingState: () => ({ inFlight: false, lastInjectedAt: 0, consecutiveFailures: 0 }),
|
||||||
|
})
|
||||||
|
|
||||||
|
// when
|
||||||
|
await injectContinuation({
|
||||||
|
ctx,
|
||||||
|
sessionID: "ses_lowercase_builtin_agent",
|
||||||
|
resolvedInfo: {
|
||||||
|
agent: "hephaestus",
|
||||||
|
model: { providerID: "openai", modelID: "gpt-5.5" },
|
||||||
|
},
|
||||||
|
sessionStateStore,
|
||||||
|
})
|
||||||
|
|
||||||
|
// then
|
||||||
|
expect(capturedAgent).toBe("Hephaestus - Deep Agent")
|
||||||
|
})
|
||||||
|
})
|
||||||
@@ -20,8 +20,8 @@ import { log } from "../../shared/logger"
|
|||||||
import { isSqliteBackend } from "../../shared/opencode-storage-detection"
|
import { isSqliteBackend } from "../../shared/opencode-storage-detection"
|
||||||
import {
|
import {
|
||||||
getAgentConfigKey,
|
getAgentConfigKey,
|
||||||
|
normalizeAgentForPrompt,
|
||||||
normalizeAgentForPromptKey,
|
normalizeAgentForPromptKey,
|
||||||
stripAgentListSortPrefix,
|
|
||||||
} from "../../shared/agent-display-names"
|
} from "../../shared/agent-display-names"
|
||||||
import { dispatchInternalPrompt, isInternalPromptDispatchAccepted } from "../shared/prompt-async-gate"
|
import { dispatchInternalPrompt, isInternalPromptDispatchAccepted } from "../shared/prompt-async-gate"
|
||||||
|
|
||||||
@@ -134,7 +134,7 @@ export async function injectContinuation(args: {
|
|||||||
|
|
||||||
const promptAgent = normalizeAgentForPromptKey(agentName)
|
const promptAgent = normalizeAgentForPromptKey(agentName)
|
||||||
const resolvedAgent = resolveRegisteredAgentName(agentName)
|
const resolvedAgent = resolveRegisteredAgentName(agentName)
|
||||||
const launchAgent = resolvedAgent ? stripAgentListSortPrefix(resolvedAgent) : resolvedAgent
|
const launchAgent = normalizeAgentForPrompt(resolvedAgent ?? agentName)
|
||||||
|
|
||||||
if (promptAgent && skipAgents.some(s => getAgentConfigKey(s) === getAgentConfigKey(promptAgent))) {
|
if (promptAgent && skipAgents.some(s => getAgentConfigKey(s) === getAgentConfigKey(promptAgent))) {
|
||||||
log(`[${HOOK_NAME}] Skipped: agent in skipAgents list`, { sessionID, agent: agentName })
|
log(`[${HOOK_NAME}] Skipped: agent in skipAgents list`, { sessionID, agent: agentName })
|
||||||
|
|||||||
Reference in New Issue
Block a user