fix(hooks): settle idle prompt continuations
This commit is contained in:
@@ -11,6 +11,7 @@ import { getLastAgentFromSession } from "./session-last-agent"
|
|||||||
import { isSessionInBoulderLineage } from "./boulder-session-lineage"
|
import { isSessionInBoulderLineage } from "./boulder-session-lineage"
|
||||||
import { getAgentConfigKey } from "../../shared/agent-display-names"
|
import { getAgentConfigKey } from "../../shared/agent-display-names"
|
||||||
import { log } from "../../shared/logger"
|
import { log } from "../../shared/logger"
|
||||||
|
import { settleAfterSessionIdle } from "../shared/session-idle-settle"
|
||||||
import { injectBoulderContinuation } from "./boulder-continuation-injector"
|
import { injectBoulderContinuation } from "./boulder-continuation-injector"
|
||||||
import { HOOK_NAME } from "./hook-name"
|
import { HOOK_NAME } from "./hook-name"
|
||||||
import { resolveActiveBoulderSession } from "./resolve-active-boulder-session"
|
import { resolveActiveBoulderSession } from "./resolve-active-boulder-session"
|
||||||
@@ -302,6 +303,8 @@ export async function handleAtlasSessionIdle(input: {
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
|
await settleAfterSessionIdle(options?.idleSettleMs)
|
||||||
|
|
||||||
await injectContinuation({
|
await injectContinuation({
|
||||||
ctx,
|
ctx,
|
||||||
sessionID,
|
sessionID,
|
||||||
|
|||||||
@@ -68,6 +68,7 @@ describe("atlas hook", () => {
|
|||||||
): ReturnType<typeof createAtlasHook> {
|
): ReturnType<typeof createAtlasHook> {
|
||||||
const resolvedOptions: AtlasHookOptions = {
|
const resolvedOptions: AtlasHookOptions = {
|
||||||
directory: TEST_DIR,
|
directory: TEST_DIR,
|
||||||
|
idleSettleMs: 0,
|
||||||
isCallerOrchestrator: async (sessionID) => callerAgentBySession.get(sessionID ?? "") === "atlas",
|
isCallerOrchestrator: async (sessionID) => callerAgentBySession.get(sessionID ?? "") === "atlas",
|
||||||
...options,
|
...options,
|
||||||
}
|
}
|
||||||
@@ -1346,6 +1347,40 @@ session_id: ses_untrusted_999
|
|||||||
expect(callArgs.body.parts[0].text).toContain("2 remaining")
|
expect(callArgs.body.parts[0].text).toContain("2 remaining")
|
||||||
})
|
})
|
||||||
|
|
||||||
|
test("should settle idle before injecting boulder continuation", async () => {
|
||||||
|
// given
|
||||||
|
const planPath = join(TEST_DIR, "test-plan.md")
|
||||||
|
writeFileSync(planPath, "# Plan\n- [ ] Task 1\n- [x] Task 2")
|
||||||
|
|
||||||
|
const state: BoulderState = {
|
||||||
|
active_plan: planPath,
|
||||||
|
started_at: "2026-01-02T10:00:00Z",
|
||||||
|
session_ids: [MAIN_SESSION_ID],
|
||||||
|
plan_name: "test-plan",
|
||||||
|
}
|
||||||
|
writeBoulderState(TEST_DIR, state)
|
||||||
|
|
||||||
|
const mockInput = createMockPluginInput()
|
||||||
|
const hook = createTestAtlasHook(mockInput, { idleSettleMs: 50 })
|
||||||
|
|
||||||
|
// when
|
||||||
|
const startedAt = Date.now()
|
||||||
|
const eventPromise = hook.handler({
|
||||||
|
event: {
|
||||||
|
type: "session.idle",
|
||||||
|
properties: { sessionID: MAIN_SESSION_ID },
|
||||||
|
},
|
||||||
|
})
|
||||||
|
await Promise.resolve()
|
||||||
|
|
||||||
|
// then
|
||||||
|
expect(mockInput._promptMock).not.toHaveBeenCalled()
|
||||||
|
|
||||||
|
await eventPromise
|
||||||
|
expect(Date.now() - startedAt).toBeGreaterThanOrEqual(45)
|
||||||
|
expect(mockInput._promptMock).toHaveBeenCalledTimes(1)
|
||||||
|
})
|
||||||
|
|
||||||
test("should not inject when no boulder state exists", async () => {
|
test("should not inject when no boulder state exists", async () => {
|
||||||
// given - no boulder state
|
// given - no boulder state
|
||||||
const mockInput = createMockPluginInput()
|
const mockInput = createMockPluginInput()
|
||||||
|
|||||||
@@ -13,6 +13,7 @@ export interface AtlasHookOptions {
|
|||||||
isContinuationStopped?: (sessionID: string) => boolean
|
isContinuationStopped?: (sessionID: string) => boolean
|
||||||
isCallerOrchestrator?: (sessionID: string | undefined) => Promise<boolean>
|
isCallerOrchestrator?: (sessionID: string | undefined) => Promise<boolean>
|
||||||
agentOverrides?: AgentOverrides
|
agentOverrides?: AgentOverrides
|
||||||
|
idleSettleMs?: number
|
||||||
/** Enable auto-commit after each atomic task completion (default: true) */
|
/** Enable auto-commit after each atomic task completion (default: true) */
|
||||||
autoCommit?: boolean
|
autoCommit?: boolean
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,5 @@
|
|||||||
|
export const DEFAULT_SESSION_IDLE_SETTLE_MS = 150
|
||||||
|
|
||||||
|
export function settleAfterSessionIdle(ms = DEFAULT_SESSION_IDLE_SETTLE_MS): Promise<void> {
|
||||||
|
return ms > 0 ? new Promise((resolve) => setTimeout(resolve, ms)) : Promise.resolve()
|
||||||
|
}
|
||||||
@@ -113,6 +113,38 @@ afterEach(async () => {
|
|||||||
})
|
})
|
||||||
|
|
||||||
describe("createTeamIdleWakeHint", () => {
|
describe("createTeamIdleWakeHint", () => {
|
||||||
|
test("settles idle before sending the wake hint", async () => {
|
||||||
|
// given
|
||||||
|
const baseDir = await createTemporaryBaseDir()
|
||||||
|
const config = createConfig(baseDir)
|
||||||
|
const teamRunId = randomUUID()
|
||||||
|
await seedRuntimeState(createRuntimeState(teamRunId), config)
|
||||||
|
await seedUnreadMessage(teamRunId, config, randomUUID(), "first message body", 100)
|
||||||
|
|
||||||
|
const promptAsyncSpy = mock(async (_input: WakeHintPromptInput) => ({}))
|
||||||
|
const handler = createTeamIdleWakeHint({
|
||||||
|
directory: "/tmp/project",
|
||||||
|
client: { session: { promptAsync: promptAsyncSpy } },
|
||||||
|
}, config, { idleSettleMs: 50 })
|
||||||
|
|
||||||
|
// when
|
||||||
|
const startedAt = Date.now()
|
||||||
|
const eventPromise = handler({
|
||||||
|
event: {
|
||||||
|
type: "session.idle",
|
||||||
|
properties: { sessionID: "member-session" },
|
||||||
|
},
|
||||||
|
})
|
||||||
|
await Promise.resolve()
|
||||||
|
|
||||||
|
// then
|
||||||
|
expect(promptAsyncSpy).not.toHaveBeenCalled()
|
||||||
|
|
||||||
|
await eventPromise
|
||||||
|
expect(Date.now() - startedAt).toBeGreaterThanOrEqual(45)
|
||||||
|
expect(promptAsyncSpy).toHaveBeenCalledTimes(1)
|
||||||
|
})
|
||||||
|
|
||||||
test("sends a trigger-only wake hint when new unread mail exists", async () => {
|
test("sends a trigger-only wake hint when new unread mail exists", async () => {
|
||||||
// given
|
// given
|
||||||
const baseDir = await createTemporaryBaseDir()
|
const baseDir = await createTemporaryBaseDir()
|
||||||
|
|||||||
@@ -8,6 +8,7 @@ import {
|
|||||||
buildMemberPromptBody,
|
buildMemberPromptBody,
|
||||||
} from "../../features/team-mode/member-session-routing"
|
} from "../../features/team-mode/member-session-routing"
|
||||||
import { log } from "../../shared/logger"
|
import { log } from "../../shared/logger"
|
||||||
|
import { settleAfterSessionIdle } from "../shared/session-idle-settle"
|
||||||
|
|
||||||
type PromptAsyncInput = {
|
type PromptAsyncInput = {
|
||||||
path: { id: string }
|
path: { id: string }
|
||||||
@@ -31,6 +32,7 @@ type TeamIdleWakeHintContext = {
|
|||||||
|
|
||||||
type HookInput = { event: { type: string; properties?: unknown } }
|
type HookInput = { event: { type: string; properties?: unknown } }
|
||||||
export type HookImpl = (input: HookInput) => Promise<void>
|
export type HookImpl = (input: HookInput) => Promise<void>
|
||||||
|
type TeamIdleWakeHintOptions = { idleSettleMs?: number }
|
||||||
|
|
||||||
function getIdleSessionID(properties: unknown): string | undefined {
|
function getIdleSessionID(properties: unknown): string | undefined {
|
||||||
const record = properties as { sessionID?: string } | undefined
|
const record = properties as { sessionID?: string } | undefined
|
||||||
@@ -41,7 +43,7 @@ function buildWakeHint(unreadCount: number): string {
|
|||||||
return `You have ${unreadCount} new team messages. They will be injected on your next turn.`
|
return `You have ${unreadCount} new team messages. They will be injected on your next turn.`
|
||||||
}
|
}
|
||||||
|
|
||||||
export function createTeamIdleWakeHint(ctx: TeamIdleWakeHintContext, config: TeamModeConfig): HookImpl {
|
export function createTeamIdleWakeHint(ctx: TeamIdleWakeHintContext, config: TeamModeConfig, options?: TeamIdleWakeHintOptions): HookImpl {
|
||||||
return async ({ event }: HookInput): Promise<void> => {
|
return async ({ event }: HookInput): Promise<void> => {
|
||||||
if (event.type !== "session.idle") return
|
if (event.type !== "session.idle") return
|
||||||
|
|
||||||
@@ -97,6 +99,7 @@ export function createTeamIdleWakeHint(ctx: TeamIdleWakeHintContext, config: Tea
|
|||||||
}
|
}
|
||||||
|
|
||||||
applyMemberSessionRouting(sessionID, memberEntry)
|
applyMemberSessionRouting(sessionID, memberEntry)
|
||||||
|
await settleAfterSessionIdle(options?.idleSettleMs)
|
||||||
|
|
||||||
await ctx.client.session.promptAsync({
|
await ctx.client.session.promptAsync({
|
||||||
path: { id: sessionID },
|
path: { id: sessionID },
|
||||||
|
|||||||
@@ -63,6 +63,41 @@ describe("unstable-agent-babysitter hook", () => {
|
|||||||
_resetForTesting()
|
_resetForTesting()
|
||||||
})
|
})
|
||||||
|
|
||||||
|
test("settles idle before injecting a reminder", async () => {
|
||||||
|
// #given
|
||||||
|
setMainSession("main-1")
|
||||||
|
const promptCalls: Array<{ input: unknown }> = []
|
||||||
|
const ctx = createMockPluginInput({
|
||||||
|
messagesBySession: {
|
||||||
|
"main-1": [
|
||||||
|
{ info: { agent: "sisyphus", model: { providerID: "openai", modelID: "gpt-4" } } },
|
||||||
|
],
|
||||||
|
"bg-1": [
|
||||||
|
{ info: { role: "assistant" }, parts: [{ type: "thinking", thinking: "deep thought" }] },
|
||||||
|
],
|
||||||
|
},
|
||||||
|
promptCalls,
|
||||||
|
})
|
||||||
|
const backgroundManager = createBackgroundManager([createTask()])
|
||||||
|
const hook = createUnstableAgentBabysitterHook(ctx, {
|
||||||
|
backgroundManager,
|
||||||
|
config: { timeout_ms: 120000 },
|
||||||
|
idleSettleMs: 50,
|
||||||
|
})
|
||||||
|
|
||||||
|
// #when
|
||||||
|
const startedAt = Date.now()
|
||||||
|
const eventPromise = hook.event({ event: { type: "session.idle", properties: { sessionID: "main-1" } } })
|
||||||
|
await Promise.resolve()
|
||||||
|
|
||||||
|
// #then
|
||||||
|
expect(promptCalls.length).toBe(0)
|
||||||
|
|
||||||
|
await eventPromise
|
||||||
|
expect(Date.now() - startedAt).toBeGreaterThanOrEqual(45)
|
||||||
|
expect(promptCalls.length).toBe(1)
|
||||||
|
})
|
||||||
|
|
||||||
test("fires reminder for hung gemini task", async () => {
|
test("fires reminder for hung gemini task", async () => {
|
||||||
// #given
|
// #given
|
||||||
setMainSession("main-1")
|
setMainSession("main-1")
|
||||||
|
|||||||
@@ -11,6 +11,7 @@ import {
|
|||||||
isUnstableTask,
|
isUnstableTask,
|
||||||
THINKING_SUMMARY_MAX_CHARS,
|
THINKING_SUMMARY_MAX_CHARS,
|
||||||
} from "./task-message-analyzer"
|
} from "./task-message-analyzer"
|
||||||
|
import { settleAfterSessionIdle } from "../shared/session-idle-settle"
|
||||||
|
|
||||||
const HOOK_NAME = "unstable-agent-babysitter"
|
const HOOK_NAME = "unstable-agent-babysitter"
|
||||||
const DEFAULT_TIMEOUT_MS = 120000
|
const DEFAULT_TIMEOUT_MS = 120000
|
||||||
@@ -54,6 +55,7 @@ type BabysitterContext = {
|
|||||||
type BabysitterOptions = {
|
type BabysitterOptions = {
|
||||||
backgroundManager: Pick<BackgroundManager, "getTasksByParentSession">
|
backgroundManager: Pick<BackgroundManager, "getTasksByParentSession">
|
||||||
config?: BabysittingConfig
|
config?: BabysittingConfig
|
||||||
|
idleSettleMs?: number
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
@@ -212,6 +214,7 @@ export function createUnstableAgentBabysitterHook(ctx: BabysitterContext, option
|
|||||||
? { providerID: model.providerID, modelID: model.modelID }
|
? { providerID: model.providerID, modelID: model.modelID }
|
||||||
: undefined
|
: undefined
|
||||||
const launchVariant = model?.variant
|
const launchVariant = model?.variant
|
||||||
|
await settleAfterSessionIdle(options.idleSettleMs)
|
||||||
|
|
||||||
await ctx.client.session.promptAsync({
|
await ctx.client.session.promptAsync({
|
||||||
path: { id: mainSessionID },
|
path: { id: mainSessionID },
|
||||||
|
|||||||
Reference in New Issue
Block a user