luna/oh-my-opencode
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(delegate-task): apply getAgentConfigKey normalization to isPlanAgent

Browse Source 
isPlanFamily was already fixed to normalize display names via getAgentConfigKey,
but isPlanAgent still used raw agentName.toLowerCase() without normalization.

Apply the same fix to isPlanAgent for consistency.

Also fixes test title: 'returns true for planner' was describing the OLD
includes-based behavior (the bug), but the assertion already expected false.
Add regression tests covering Metis/Momus/Atlas display names for both functions.

Fixes #3312
This commit is contained in:
Code_G
2026-04-11 13:40:02 +09:00
parent e2c2c5b142
commit 23d125755f
2 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/tools/delegate-task/tools.test.ts
+15 -1
View File
@@ -191,7 +191,7 @@ describe("sisyphus-task", () => {
expect(result).toBe(false)
})
test("returns true for 'planner' (matches via includes('plan'))", () => {
test("returns false for 'planner' (no longer matches via substring)", () => {
//#given / #when
const result = isPlanAgent("planner")
@@ -251,6 +251,13 @@ describe("sisyphus-task", () => {
//#given / #when / #then
expect(PLAN_AGENT_NAMES).toEqual(["plan"])
})
test("returns false for non-plan agent display names (regression: isPlanAgent display-name false-positive)", () => {
//#given / #when / #then
expect(isPlanAgent(getAgentDisplayName("metis"))).toBe(false)
expect(isPlanAgent(getAgentDisplayName("momus"))).toBe(false)
expect(isPlanAgent(getAgentDisplayName("atlas"))).toBe(false)
})
})
describe("isPlanFamily", () => {
@@ -296,6 +303,13 @@ describe("sisyphus-task", () => {
expect(result).toBe(false)
})
test("returns false for non-plan-family agent display names (regression: isPlanFamily includes() false-positive)", () => {
//#given / #when / #then
expect(isPlanFamily(getAgentDisplayName("metis"))).toBe(false)
expect(isPlanFamily(getAgentDisplayName("momus"))).toBe(false)
expect(isPlanFamily(getAgentDisplayName("atlas"))).toBe(false)
})
test("PLAN_FAMILY_NAMES contains plan and prometheus", () => {
//#given / #when / #then
expect(PLAN_FAMILY_NAMES).toEqual(["plan", "prometheus"])