fix(windows): add windowsHide to Bun.spawn calls to prevent stray terminal windows

Closes #1915

src/cli/run/on-complete-hook.test.ts

@@ -1,4 +1,5 @@
 import { describe, it, expect, spyOn, beforeEach, afterEach } from "bun:test"
+import * as spawnWithWindowsHideModule from "../../shared/spawn-with-windows-hide"
 import { executeOnCompleteHook } from "./on-complete-hook"
 
 describe("executeOnCompleteHook", () => {
@@ -6,7 +7,10 @@ describe("executeOnCompleteHook", () => {
     return {
       exited: Promise.resolve(exitCode),
       exitCode,
-    } as unknown as ReturnType<typeof Bun.spawn>
+      stdout: undefined,
+      stderr: undefined,
+      kill: () => {},
+    } satisfies ReturnType<typeof spawnWithWindowsHideModule.spawnWithWindowsHide>
   }
 
   let consoleErrorSpy: ReturnType<typeof spyOn<typeof console, "error">>
@@ -21,7 +25,7 @@ describe("executeOnCompleteHook", () => {
 
   it("executes command with correct env vars", async () => {
     // given
-    const spawnSpy = spyOn(Bun, "spawn").mockReturnValue(createProc(0))
+    const spawnSpy = spyOn(spawnWithWindowsHideModule, "spawnWithWindowsHide").mockReturnValue(createProc(0))
 
     try {
       // when
@@ -35,7 +39,7 @@ describe("executeOnCompleteHook", () => {
 
       // then
       expect(spawnSpy).toHaveBeenCalledTimes(1)
-      const [args, options] = spawnSpy.mock.calls[0] as Parameters<typeof Bun.spawn>
+      const [args, options] = spawnSpy.mock.calls[0] as Parameters<typeof spawnWithWindowsHideModule.spawnWithWindowsHide>
 
       expect(args).toEqual(["sh", "-c", "echo test"])
       expect(options?.env?.SESSION_ID).toBe("session-123")
@@ -51,7 +55,7 @@ describe("executeOnCompleteHook", () => {
 
   it("env var values are strings", async () => {
     // given
-    const spawnSpy = spyOn(Bun, "spawn").mockReturnValue(createProc(0))
+    const spawnSpy = spyOn(spawnWithWindowsHideModule, "spawnWithWindowsHide").mockReturnValue(createProc(0))
 
     try {
       // when
@@ -64,7 +68,7 @@ describe("executeOnCompleteHook", () => {
       })
 
       // then
-      const [_, options] = spawnSpy.mock.calls[0] as Parameters<typeof Bun.spawn>
+      const [_, options] = spawnSpy.mock.calls[0] as Parameters<typeof spawnWithWindowsHideModule.spawnWithWindowsHide>
 
       expect(options?.env?.EXIT_CODE).toBe("1")
       expect(options?.env?.EXIT_CODE).toBeTypeOf("string")
@@ -79,7 +83,7 @@ describe("executeOnCompleteHook", () => {
 
   it("empty command string is no-op", async () => {
     // given
-    const spawnSpy = spyOn(Bun, "spawn").mockReturnValue(createProc(0))
+    const spawnSpy = spyOn(spawnWithWindowsHideModule, "spawnWithWindowsHide").mockReturnValue(createProc(0))
 
     try {
       // when
@@ -100,7 +104,7 @@ describe("executeOnCompleteHook", () => {
 
   it("whitespace-only command is no-op", async () => {
     // given
-    const spawnSpy = spyOn(Bun, "spawn").mockReturnValue(createProc(0))
+    const spawnSpy = spyOn(spawnWithWindowsHideModule, "spawnWithWindowsHide").mockReturnValue(createProc(0))
 
     try {
       // when
@@ -121,11 +125,11 @@ describe("executeOnCompleteHook", () => {
 
   it("command failure logs warning but does not throw", async () => {
     // given
-    const spawnSpy = spyOn(Bun, "spawn").mockReturnValue(createProc(1))
+    const spawnSpy = spyOn(spawnWithWindowsHideModule, "spawnWithWindowsHide").mockReturnValue(createProc(1))
 
     try {
       // when
-      await expect(
+      expect(
         executeOnCompleteHook({
           command: "false",
           sessionId: "session-123",
@@ -149,13 +153,13 @@ describe("executeOnCompleteHook", () => {
   it("spawn error logs warning but does not throw", async () => {
     // given
     const spawnError = new Error("Command not found")
-    const spawnSpy = spyOn(Bun, "spawn").mockImplementation(() => {
+    const spawnSpy = spyOn(spawnWithWindowsHideModule, "spawnWithWindowsHide").mockImplementation(() => {
       throw spawnError
     })
 
     try {
       // when
-      await expect(
+      expect(
         executeOnCompleteHook({
           command: "nonexistent-command",
           sessionId: "session-123",