fix(omo-codex): bundle explorer/librarian/plan agent TOMLs for spawn_agent
The synced Codex skills (refactor, review-work, remove-ai-slops) emit `spawn_agent(agent_type="explorer"/"librarian"/"plan", ...)` guidance that sync-skills.mjs injects into every skill containing OpenCode-only orchestration calls. Only codex-ultrawork-reviewer.toml was bundled, so Codex had no matching agent role to dispatch. An older omo-codex release shipped explorer/librarian/plan TOMLs but without the required top-level `name` field, leaving Codex to warn: Ignoring malformed agent role definition: agent role file at ~/.codex/agents/<name>.toml must define a non-empty `name` This commit bundles three correctly-formed TOMLs into components/ultrawork/agents/. Each has the full schema Codex parses: `name`, `description`, `nickname_candidates`, `model`, `model_reasoning_effort`, `service_tier`, `developer_instructions`. The existing sync-agents.py SessionStart hook installs them via rglob into CODEX_HOME/agents/. Models match the original design: explorer + librarian on gpt-5.4-mini low effort (fast contextual + external research); plan on gpt-5.5 xhigh effort (deep reasoning + interview-style planning). Tests: - test/bundled-agents.test.mjs: locks the sync-hook contract by running sync-agents.py against a temp CODEX_HOME and verifying each TOML lands with the expected name + schema. - test/aggregate.test.mjs: locks the schema keys on every bundled TOML and the spawn_agent contract (every in-scope agent_type referenced by a synced skill has a matching bundle). Follow-up: the sync-skills.mjs compatibility table also references `spawn_agent(agent_type="worker", ...)`. No worker.toml is present in CODEX_HOME and Codex does not warn about its absence, suggesting worker is a built-in Codex role. Confirm and ship worker.toml if not.
This commit is contained in:
YeonGyu-Kim
@@ -1,6 +1,6 @@
|
||||
import assert from "node:assert/strict";
|
||||
import { readdir, readFile } from "node:fs/promises";
|
||||
import { dirname, join } from "node:path";
|
||||
import { readdir, readFile, stat } from "node:fs/promises";
|
||||
import { basename, dirname, join } from "node:path";
|
||||
import test from "node:test";
|
||||
import { fileURLToPath } from "node:url";
|
||||
|
||||
@@ -10,6 +10,15 @@ async function readJson(relativePath) {
|
||||
return JSON.parse(await readFile(join(root, relativePath), "utf8"));
|
||||
}
|
||||
|
||||
function findSpawnAgentTypes(content) {
|
||||
const agentTypes = new Set();
|
||||
const regex = /spawn_agent\(agent_type="([^"]+)"/g;
|
||||
for (const match of content.matchAll(regex)) {
|
||||
agentTypes.add(match[1]);
|
||||
}
|
||||
return [...agentTypes].sort();
|
||||
}
|
||||
|
||||
test("#given aggregate plugin manifest #when inspected #then it owns the omo namespace", async () => {
|
||||
// given
|
||||
const manifest = await readJson(".codex-plugin/plugin.json");
|
||||
@@ -91,3 +100,57 @@ test("#given component directories #when scanned #then only root owns plugin ide
|
||||
);
|
||||
}
|
||||
});
|
||||
|
||||
test("#given bundled Codex agents #when components/ultrawork/agents directory is scanned #then explorer librarian and reviewer TOMLs are present and match expected schema keys", async () => {
|
||||
const agentsDir = join(root, "components", "ultrawork", "agents");
|
||||
const entries = (await readdir(agentsDir, { withFileTypes: true }))
|
||||
.filter((entry) => entry.isFile() && entry.name.endsWith(".toml"))
|
||||
.map((entry) => entry.name)
|
||||
.sort();
|
||||
|
||||
assert.deepEqual(entries, [
|
||||
"codex-ultrawork-reviewer.toml",
|
||||
"explorer.toml",
|
||||
"librarian.toml",
|
||||
"plan.toml",
|
||||
]);
|
||||
|
||||
for (const fileName of entries) {
|
||||
const content = await readFile(join(agentsDir, fileName), "utf8");
|
||||
assert.match(content, /^name\s*=\s*".+"$/m);
|
||||
assert.match(content, /^description\s*=\s*".+"$/m);
|
||||
assert.match(content, /^nickname_candidates\s*=\s*\[.+\]$/m);
|
||||
assert.match(content, /^model\s*=\s*".+"$/m);
|
||||
assert.match(content, /^model_reasoning_effort\s*=\s*".+"$/m);
|
||||
assert.match(content, /^developer_instructions\s*=\s*"""/m);
|
||||
}
|
||||
});
|
||||
|
||||
test("#given synced skills with Codex compatibility guidance #when explorer/librarian agent_type is referenced #then a matching TOML is bundled", async () => {
|
||||
const skillsDir = join(root, "skills");
|
||||
const skillEntries = await readdir(skillsDir, { withFileTypes: true });
|
||||
const skillFiles = skillEntries
|
||||
.filter((entry) => entry.isDirectory())
|
||||
.map((entry) => join(skillsDir, entry.name, "SKILL.md"));
|
||||
|
||||
const referencedAgentTypes = new Set();
|
||||
for (const skillPath of skillFiles) {
|
||||
const content = await readFile(skillPath, "utf8");
|
||||
for (const agentType of findSpawnAgentTypes(content)) {
|
||||
if (agentType === "worker" || agentType === "codex-ultrawork-reviewer") {
|
||||
continue;
|
||||
}
|
||||
referencedAgentTypes.add(agentType);
|
||||
}
|
||||
}
|
||||
|
||||
const expected = [...referencedAgentTypes].sort();
|
||||
assert.deepEqual(expected, ["explorer", "librarian", "plan"]);
|
||||
|
||||
for (const agentType of expected) {
|
||||
const tomlPath = join(root, "components", "ultrawork", "agents", `${agentType}.toml`);
|
||||
const fileStat = await stat(tomlPath);
|
||||
assert.equal(fileStat.isFile(), true);
|
||||
assert.equal(basename(tomlPath), `${agentType}.toml`);
|
||||
}
|
||||
});
|
||||
|
||||
@@ -0,0 +1,129 @@
|
||||
import assert from "node:assert/strict";
|
||||
import { spawn } from "node:child_process";
|
||||
import { lstat, mkdtemp, readdir, readFile, rm } from "node:fs/promises";
|
||||
import { tmpdir } from "node:os";
|
||||
import { dirname, join } from "node:path";
|
||||
import { fileURLToPath } from "node:url";
|
||||
import test from "node:test";
|
||||
|
||||
const testDir = dirname(fileURLToPath(import.meta.url));
|
||||
const pluginRoot = dirname(testDir);
|
||||
const componentRoot = join(pluginRoot, "components", "ultrawork");
|
||||
const syncAgentsPath = join(componentRoot, "hooks", "sync-agents.py");
|
||||
|
||||
async function makeTempDir() {
|
||||
return mkdtemp(join(tmpdir(), "codex-bundled-agents-"));
|
||||
}
|
||||
|
||||
async function runSyncHook(codexHome) {
|
||||
return new Promise((resolve, reject) => {
|
||||
const child = spawn("python3", [syncAgentsPath], {
|
||||
env: { ...process.env, CODEX_HOME: codexHome },
|
||||
});
|
||||
let stdout = "";
|
||||
let stderr = "";
|
||||
child.stdout.setEncoding("utf8");
|
||||
child.stderr.setEncoding("utf8");
|
||||
child.stdout.on("data", (chunk) => {
|
||||
stdout += chunk;
|
||||
});
|
||||
child.stderr.on("data", (chunk) => {
|
||||
stderr += chunk;
|
||||
});
|
||||
child.once("error", reject);
|
||||
child.once("close", (code) => resolve({ code, stdout, stderr }));
|
||||
child.stdin.end('{"hook_event_name":"SessionStart"}');
|
||||
});
|
||||
}
|
||||
|
||||
test("#given session start #when sync hook runs #then bundles explorer agent", async () => {
|
||||
const codexHome = await makeTempDir();
|
||||
try {
|
||||
const result = await runSyncHook(codexHome);
|
||||
assert.equal(result.code, 0);
|
||||
assert.equal(result.stdout, "");
|
||||
assert.equal(result.stderr, "");
|
||||
|
||||
const target = join(codexHome, "agents", "explorer.toml");
|
||||
const targetStat = await lstat(target);
|
||||
assert.equal(targetStat.isFile(), true);
|
||||
assert.equal(targetStat.isSymbolicLink(), false);
|
||||
|
||||
const content = await readFile(target, "utf8");
|
||||
assert.match(content, /^name = "explorer"$/m);
|
||||
assert.match(content, /^model = /m);
|
||||
assert.match(content, /^model_reasoning_effort = /m);
|
||||
assert.match(content, /^developer_instructions = """/m);
|
||||
assert.match(content, /codebase search specialist/i);
|
||||
} finally {
|
||||
await rm(codexHome, { recursive: true, force: true });
|
||||
}
|
||||
});
|
||||
|
||||
test("#given session start #when sync hook runs #then bundles librarian agent", async () => {
|
||||
const codexHome = await makeTempDir();
|
||||
try {
|
||||
const result = await runSyncHook(codexHome);
|
||||
assert.equal(result.code, 0);
|
||||
assert.equal(result.stdout, "");
|
||||
assert.equal(result.stderr, "");
|
||||
|
||||
const target = join(codexHome, "agents", "librarian.toml");
|
||||
const targetStat = await lstat(target);
|
||||
assert.equal(targetStat.isFile(), true);
|
||||
assert.equal(targetStat.isSymbolicLink(), false);
|
||||
|
||||
const content = await readFile(target, "utf8");
|
||||
assert.match(content, /^name = "librarian"$/m);
|
||||
assert.match(content, /^model = /m);
|
||||
assert.match(content, /^model_reasoning_effort = /m);
|
||||
assert.match(content, /^developer_instructions = """/m);
|
||||
assert.match(content, /THE LIBRARIAN/);
|
||||
} finally {
|
||||
await rm(codexHome, { recursive: true, force: true });
|
||||
}
|
||||
});
|
||||
|
||||
test("#given session start #when sync hook runs #then bundles plan agent into CODEX_HOME/agents", async () => {
|
||||
const codexHome = await makeTempDir();
|
||||
try {
|
||||
const result = await runSyncHook(codexHome);
|
||||
assert.equal(result.code, 0);
|
||||
assert.equal(result.stdout, "");
|
||||
assert.equal(result.stderr, "");
|
||||
|
||||
const target = join(codexHome, "agents", "plan.toml");
|
||||
const targetStat = await lstat(target);
|
||||
assert.equal(targetStat.isFile(), true);
|
||||
assert.equal(targetStat.isSymbolicLink(), false);
|
||||
|
||||
const content = await readFile(target, "utf8");
|
||||
assert.match(content, /^name = "plan"$/m);
|
||||
assert.match(content, /^model = /m);
|
||||
assert.match(content, /^model_reasoning_effort = /m);
|
||||
assert.match(content, /^developer_instructions = """/m);
|
||||
assert.match(content, /strategic planning consultant/i);
|
||||
} finally {
|
||||
await rm(codexHome, { recursive: true, force: true });
|
||||
}
|
||||
});
|
||||
|
||||
test("#given session start #when sync hook runs #then installs exactly the expected bundled set", async () => {
|
||||
const codexHome = await makeTempDir();
|
||||
try {
|
||||
await runSyncHook(codexHome);
|
||||
const entries = await readdir(join(codexHome, "agents"), { withFileTypes: true });
|
||||
const names = entries
|
||||
.filter((entry) => entry.isFile())
|
||||
.map((entry) => entry.name)
|
||||
.sort();
|
||||
assert.deepEqual(names, [
|
||||
"codex-ultrawork-reviewer.toml",
|
||||
"explorer.toml",
|
||||
"librarian.toml",
|
||||
"plan.toml",
|
||||
]);
|
||||
} finally {
|
||||
await rm(codexHome, { recursive: true, force: true });
|
||||
}
|
||||
});
|
||||
Reference in New Issue
Block a user