fix: address review-work round 3 findings (async shutdown, signal generation, stale test name)

This commit is contained in:
YeonGyu-Kim
2026-03-11 21:30:04 +09:00
parent ff536e992a
commit 2c3c447dc4
6 changed files with 14 additions and 13 deletions
+4 -4
View File
@@ -116,7 +116,7 @@ export class BackgroundManager {
private config?: BackgroundTaskConfig
private tmuxEnabled: boolean
private onSubagentSessionCreated?: OnSubagentSessionCreated
private onShutdown?: () => void
private onShutdown?: () => void | Promise<void>
private queuesByKey: Map<string, QueueItem[]> = new Map()
private processingKeys: Set<string> = new Set()
@@ -134,7 +134,7 @@ export class BackgroundManager {
options?: {
tmuxConfig?: TmuxConfig
onSubagentSessionCreated?: OnSubagentSessionCreated
onShutdown?: () => void
onShutdown?: () => void | Promise<void>
enableParentSessionNotifications?: boolean
}
) {
@@ -1702,7 +1702,7 @@ Use \`background_output(task_id="${task.id}")\` to retrieve this result when rea
* Cancels all pending concurrency waiters and clears timers.
* Should be called when the plugin is unloaded.
*/
shutdown(): void {
async shutdown(): Promise<void> {
if (this.shutdownTriggered) return
this.shutdownTriggered = true
log("[background-agent] Shutting down BackgroundManager")
@@ -1720,7 +1720,7 @@ Use \`background_output(task_id="${task.id}")\` to retrieve this result when rea
// Notify shutdown listeners (e.g., tmux cleanup)
if (this.onShutdown) {
try {
this.onShutdown()
await this.onShutdown()
} catch (error) {
log("[background-agent] Error in onShutdown callback:", error)
}
@@ -19,6 +19,7 @@ export function registerProcessCleanup(state: SkillMcpManagerState): void {
state.cleanupRegistered = true
const cleanup = async (): Promise<void> => {
state.shutdownGeneration++
for (const managed of state.clients.values()) {
await closeManagedClient(managed)
}
@@ -142,7 +142,7 @@ describe("getOrCreateClient disconnect race", () => {
expect(createdTransports[0]?.close).toHaveBeenCalledTimes(1)
})
it("#given session A in disconnectedSessions #when new connection is requested for session A #then session A is removed from disconnectedSessions and connection proceeds normally", async () => {
it("#given session A in disconnectedSessions #when new connection is requested for session A #then connection proceeds normally and disconnectedSessions entry is retained for pending race protection", async () => {
const state = createState()
const info = createClientInfo("session-a")
const clientKey = createClientKey(info)