fix(chat-params): use conservative token fallback for invalid limits

Avoid inflating non-positive maxOutputTokens values to model capability maxima by always falling back to a safe fixed budget.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This commit is contained in:
YeonGyu-Kim
2026-05-11 08:47:49 +09:00
parent 279f0d150f
commit 2f8ce576dc
2 changed files with 54 additions and 8 deletions
+12 -4
View File
@@ -1,5 +1,7 @@
import { getSessionPromptParams } from "../shared/session-prompt-params-state"
import { getModelCapabilities, resolveCompatibleModelSettings } from "../shared"
import { getModelCapabilities, log, resolveCompatibleModelSettings } from "../shared"
const SAFE_MAX_OUTPUT_TOKENS_FALLBACK = 4096
export type ChatParamsInput = {
sessionID: string
@@ -168,9 +170,15 @@ export function createChatParamsHandler(args: {
if (compatibility.maxTokens !== undefined && compatibility.maxTokens > 0) {
output.maxOutputTokens = compatibility.maxTokens
} else {
const capabilitiesLimit = capabilities?.maxOutputTokens
output.maxOutputTokens =
typeof capabilitiesLimit === "number" && capabilitiesLimit > 0 ? capabilitiesLimit : 4096
const originalMaxOutputTokens = typeof output.maxOutputTokens === "number"
? output.maxOutputTokens
: compatibility.maxTokens
output.maxOutputTokens = SAFE_MAX_OUTPUT_TOKENS_FALLBACK
if (typeof originalMaxOutputTokens === "number" && originalMaxOutputTokens <= 0) {
log(
`[plugin] maxOutputTokens=${originalMaxOutputTokens} is non-positive; using safe fallback ${SAFE_MAX_OUTPUT_TOKENS_FALLBACK}`,
)
}
}
}