test(skill-mcp): add scope field to test fixtures

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This commit is contained in:
YeonGyu-Kim
2026-04-08 13:11:28 +09:00
parent fa140b0375
commit 35f778db2d
4 changed files with 43 additions and 5 deletions
@@ -94,6 +94,7 @@ function createClientInfo(serverName: string): SkillMcpClientInfo {
serverName, serverName,
skillName: "env-skill", skillName: "env-skill",
sessionID: "session-env", sessionID: "session-env",
scope: "builtin",
} }
} }
@@ -95,6 +95,7 @@ function createClientInfo(sessionID: string): SkillMcpClientInfo {
serverName: "race-server", serverName: "race-server",
skillName: "race-skill", skillName: "race-skill",
sessionID, sessionID,
scope: "builtin",
} }
} }
+40 -5
View File
@@ -65,6 +65,7 @@ describe("SkillMcpManager", () => {
serverName: "test-server", serverName: "test-server",
skillName: "test-skill", skillName: "test-skill",
sessionID: "session-1", sessionID: "session-1",
scope: "builtin",
} }
const config: ClaudeCodeMcpServer = {} const config: ClaudeCodeMcpServer = {}
@@ -80,6 +81,7 @@ describe("SkillMcpManager", () => {
serverName: "my-mcp", serverName: "my-mcp",
skillName: "data-skill", skillName: "data-skill",
sessionID: "session-1", sessionID: "session-1",
scope: "builtin",
} }
const config: ClaudeCodeMcpServer = {} const config: ClaudeCodeMcpServer = {}
@@ -95,6 +97,7 @@ describe("SkillMcpManager", () => {
serverName: "custom-server", serverName: "custom-server",
skillName: "custom-skill", skillName: "custom-skill",
sessionID: "session-1", sessionID: "session-1",
scope: "builtin",
} }
const config: ClaudeCodeMcpServer = {} const config: ClaudeCodeMcpServer = {}
@@ -112,6 +115,7 @@ describe("SkillMcpManager", () => {
serverName: "http-server", serverName: "http-server",
skillName: "test-skill", skillName: "test-skill",
sessionID: "session-1", sessionID: "session-1",
scope: "builtin",
} }
const config: ClaudeCodeMcpServer = { const config: ClaudeCodeMcpServer = {
type: "http", type: "http",
@@ -130,6 +134,7 @@ describe("SkillMcpManager", () => {
serverName: "sse-server", serverName: "sse-server",
skillName: "test-skill", skillName: "test-skill",
sessionID: "session-1", sessionID: "session-1",
scope: "builtin",
} }
const config: ClaudeCodeMcpServer = { const config: ClaudeCodeMcpServer = {
type: "sse", type: "sse",
@@ -148,6 +153,7 @@ describe("SkillMcpManager", () => {
serverName: "inferred-http", serverName: "inferred-http",
skillName: "test-skill", skillName: "test-skill",
sessionID: "session-1", sessionID: "session-1",
scope: "builtin",
} }
const config: ClaudeCodeMcpServer = { const config: ClaudeCodeMcpServer = {
url: "https://example.com/mcp", url: "https://example.com/mcp",
@@ -165,6 +171,7 @@ describe("SkillMcpManager", () => {
serverName: "stdio-server", serverName: "stdio-server",
skillName: "test-skill", skillName: "test-skill",
sessionID: "session-1", sessionID: "session-1",
scope: "builtin",
} }
const config: ClaudeCodeMcpServer = { const config: ClaudeCodeMcpServer = {
type: "stdio", type: "stdio",
@@ -184,6 +191,7 @@ describe("SkillMcpManager", () => {
serverName: "inferred-stdio", serverName: "inferred-stdio",
skillName: "test-skill", skillName: "test-skill",
sessionID: "session-1", sessionID: "session-1",
scope: "builtin",
} }
const config: ClaudeCodeMcpServer = { const config: ClaudeCodeMcpServer = {
command: "node", command: "node",
@@ -202,6 +210,7 @@ describe("SkillMcpManager", () => {
serverName: "mixed-config", serverName: "mixed-config",
skillName: "test-skill", skillName: "test-skill",
sessionID: "session-1", sessionID: "session-1",
scope: "builtin",
} }
const config: ClaudeCodeMcpServer = { const config: ClaudeCodeMcpServer = {
type: "stdio", type: "stdio",
@@ -224,6 +233,7 @@ describe("SkillMcpManager", () => {
serverName: "bad-url-server", serverName: "bad-url-server",
skillName: "test-skill", skillName: "test-skill",
sessionID: "session-1", sessionID: "session-1",
scope: "builtin",
} }
const config: ClaudeCodeMcpServer = { const config: ClaudeCodeMcpServer = {
type: "http", type: "http",
@@ -242,6 +252,7 @@ describe("SkillMcpManager", () => {
serverName: "http-error-server", serverName: "http-error-server",
skillName: "test-skill", skillName: "test-skill",
sessionID: "session-1", sessionID: "session-1",
scope: "builtin",
} }
const config: ClaudeCodeMcpServer = { const config: ClaudeCodeMcpServer = {
url: "https://nonexistent.example.com/mcp", url: "https://nonexistent.example.com/mcp",
@@ -259,6 +270,7 @@ describe("SkillMcpManager", () => {
serverName: "hint-server", serverName: "hint-server",
skillName: "test-skill", skillName: "test-skill",
sessionID: "session-1", sessionID: "session-1",
scope: "builtin",
} }
const config: ClaudeCodeMcpServer = { const config: ClaudeCodeMcpServer = {
url: "https://nonexistent.example.com/mcp", url: "https://nonexistent.example.com/mcp",
@@ -276,6 +288,7 @@ describe("SkillMcpManager", () => {
serverName: "mock-test-server", serverName: "mock-test-server",
skillName: "test-skill", skillName: "test-skill",
sessionID: "session-1", sessionID: "session-1",
scope: "builtin",
} }
const config: ClaudeCodeMcpServer = { const config: ClaudeCodeMcpServer = {
url: "https://example.com/mcp", url: "https://example.com/mcp",
@@ -302,6 +315,7 @@ describe("SkillMcpManager", () => {
serverName: "missing-command", serverName: "missing-command",
skillName: "test-skill", skillName: "test-skill",
sessionID: "session-1", sessionID: "session-1",
scope: "builtin",
} }
const config: ClaudeCodeMcpServer = { const config: ClaudeCodeMcpServer = {
type: "stdio", type: "stdio",
@@ -320,6 +334,7 @@ describe("SkillMcpManager", () => {
serverName: "test-server", serverName: "test-server",
skillName: "test-skill", skillName: "test-skill",
sessionID: "session-1", sessionID: "session-1",
scope: "builtin",
} }
const config: ClaudeCodeMcpServer = { const config: ClaudeCodeMcpServer = {
command: "nonexistent-command-xyz", command: "nonexistent-command-xyz",
@@ -338,6 +353,7 @@ describe("SkillMcpManager", () => {
serverName: "test-server", serverName: "test-server",
skillName: "test-skill", skillName: "test-skill",
sessionID: "session-1", sessionID: "session-1",
scope: "builtin",
} }
const config: ClaudeCodeMcpServer = { const config: ClaudeCodeMcpServer = {
command: "nonexistent-command", command: "nonexistent-command",
@@ -358,11 +374,13 @@ describe("SkillMcpManager", () => {
serverName: "server1", serverName: "server1",
skillName: "skill1", skillName: "skill1",
sessionID: "session-1", sessionID: "session-1",
scope: "builtin",
} }
const session2Info: SkillMcpClientInfo = { const session2Info: SkillMcpClientInfo = {
serverName: "server1", serverName: "server1",
skillName: "skill1", skillName: "skill1",
sessionID: "session-2", sessionID: "session-2",
scope: "builtin",
} }
// when // when
@@ -396,6 +414,7 @@ describe("SkillMcpManager", () => {
serverName: "signal-server", serverName: "signal-server",
skillName: "signal-skill", skillName: "signal-skill",
sessionID: "session-1", sessionID: "session-1",
scope: "builtin",
} }
const config: ClaudeCodeMcpServer = { const config: ClaudeCodeMcpServer = {
url: "https://example.com/mcp", url: "https://example.com/mcp",
@@ -423,11 +442,12 @@ describe("SkillMcpManager", () => {
describe("isConnected", () => { describe("isConnected", () => {
it("returns false for unconnected server", () => { it("returns false for unconnected server", () => {
// given // given
const info: SkillMcpClientInfo = { const info: SkillMcpClientInfo = {
serverName: "unknown", serverName: "$1",
skillName: "test", skillName: "$2",
sessionID: "session-1", sessionID: "$3",
} scope: "builtin",
}
// when / #then // when / #then
expect(manager.isConnected(info)).toBe(false) expect(manager.isConnected(info)).toBe(false)
@@ -448,6 +468,7 @@ describe("SkillMcpManager", () => {
serverName: "test-server", serverName: "test-server",
skillName: "test-skill", skillName: "test-skill",
sessionID: "session-1", sessionID: "session-1",
scope: "builtin",
} }
const configWithoutEnv: ClaudeCodeMcpServer = { const configWithoutEnv: ClaudeCodeMcpServer = {
command: "node", command: "node",
@@ -471,6 +492,7 @@ describe("SkillMcpManager", () => {
serverName: "test-server", serverName: "test-server",
skillName: "test-skill", skillName: "test-skill",
sessionID: "session-2", sessionID: "session-2",
scope: "builtin",
} }
const configWithEnv: ClaudeCodeMcpServer = { const configWithEnv: ClaudeCodeMcpServer = {
command: "node", command: "node",
@@ -498,6 +520,7 @@ describe("SkillMcpManager", () => {
serverName: "auth-server", serverName: "auth-server",
skillName: "test-skill", skillName: "test-skill",
sessionID: "session-1", sessionID: "session-1",
scope: "builtin",
} }
const config: ClaudeCodeMcpServer = { const config: ClaudeCodeMcpServer = {
url: "https://example.com/mcp", url: "https://example.com/mcp",
@@ -526,6 +549,7 @@ describe("SkillMcpManager", () => {
serverName: "no-auth-server", serverName: "no-auth-server",
skillName: "test-skill", skillName: "test-skill",
sessionID: "session-1", sessionID: "session-1",
scope: "builtin",
} }
const config: ClaudeCodeMcpServer = { const config: ClaudeCodeMcpServer = {
url: "https://example.com/mcp", url: "https://example.com/mcp",
@@ -546,6 +570,7 @@ describe("SkillMcpManager", () => {
serverName: "retry-server", serverName: "retry-server",
skillName: "retry-skill", skillName: "retry-skill",
sessionID: "session-retry-1", sessionID: "session-retry-1",
scope: "builtin",
} }
const context: SkillMcpServerContext = { const context: SkillMcpServerContext = {
config: { config: {
@@ -584,6 +609,7 @@ describe("SkillMcpManager", () => {
serverName: "fail-server", serverName: "fail-server",
skillName: "fail-skill", skillName: "fail-skill",
sessionID: "session-fail-1", sessionID: "session-fail-1",
scope: "builtin",
} }
const context: SkillMcpServerContext = { const context: SkillMcpServerContext = {
config: { config: {
@@ -615,6 +641,7 @@ describe("SkillMcpManager", () => {
serverName: "error-server", serverName: "error-server",
skillName: "error-skill", skillName: "error-skill",
sessionID: "session-error-1", sessionID: "session-error-1",
scope: "builtin",
} }
const context: SkillMcpServerContext = { const context: SkillMcpServerContext = {
config: { config: {
@@ -653,6 +680,7 @@ describe("SkillMcpManager", () => {
serverName: "oauth-server", serverName: "oauth-server",
skillName: "oauth-skill", skillName: "oauth-skill",
sessionID: "session-oauth-1", sessionID: "session-oauth-1",
scope: "builtin",
} }
const config: ClaudeCodeMcpServer = { const config: ClaudeCodeMcpServer = {
url: "https://mcp.example.com/mcp", url: "https://mcp.example.com/mcp",
@@ -679,6 +707,7 @@ describe("SkillMcpManager", () => {
serverName: "oauth-no-token", serverName: "oauth-no-token",
skillName: "oauth-skill", skillName: "oauth-skill",
sessionID: "session-oauth-2", sessionID: "session-oauth-2",
scope: "builtin",
} }
const config: ClaudeCodeMcpServer = { const config: ClaudeCodeMcpServer = {
url: "https://mcp.example.com/mcp", url: "https://mcp.example.com/mcp",
@@ -705,6 +734,7 @@ describe("SkillMcpManager", () => {
serverName: "oauth-with-headers", serverName: "oauth-with-headers",
skillName: "oauth-skill", skillName: "oauth-skill",
sessionID: "session-oauth-3", sessionID: "session-oauth-3",
scope: "builtin",
} }
const config: ClaudeCodeMcpServer = { const config: ClaudeCodeMcpServer = {
url: "https://mcp.example.com/mcp", url: "https://mcp.example.com/mcp",
@@ -734,6 +764,7 @@ describe("SkillMcpManager", () => {
serverName: "oauth-refresh", serverName: "oauth-refresh",
skillName: "oauth-skill", skillName: "oauth-skill",
sessionID: "session-oauth-refresh", sessionID: "session-oauth-refresh",
scope: "builtin",
} }
const config: ClaudeCodeMcpServer = { const config: ClaudeCodeMcpServer = {
url: "https://mcp.example.com/mcp", url: "https://mcp.example.com/mcp",
@@ -766,6 +797,7 @@ describe("SkillMcpManager", () => {
serverName: "oauth-refresh-fallback", serverName: "oauth-refresh-fallback",
skillName: "oauth-skill", skillName: "oauth-skill",
sessionID: "session-oauth-refresh-fallback", sessionID: "session-oauth-refresh-fallback",
scope: "builtin",
} }
const config: ClaudeCodeMcpServer = { const config: ClaudeCodeMcpServer = {
url: "https://mcp.example.com/mcp", url: "https://mcp.example.com/mcp",
@@ -799,6 +831,7 @@ describe("SkillMcpManager", () => {
serverName: "no-oauth-server", serverName: "no-oauth-server",
skillName: "test-skill", skillName: "test-skill",
sessionID: "session-no-oauth", sessionID: "session-no-oauth",
scope: "builtin",
} }
const config: ClaudeCodeMcpServer = { const config: ClaudeCodeMcpServer = {
url: "https://mcp.example.com/mcp", url: "https://mcp.example.com/mcp",
@@ -824,6 +857,7 @@ describe("SkillMcpManager", () => {
serverName: "stepup-server", serverName: "stepup-server",
skillName: "stepup-skill", skillName: "stepup-skill",
sessionID: "session-stepup-1", sessionID: "session-stepup-1",
scope: "builtin",
} }
const config: ClaudeCodeMcpServer = { const config: ClaudeCodeMcpServer = {
url: "https://mcp.example.com/mcp", url: "https://mcp.example.com/mcp",
@@ -869,6 +903,7 @@ describe("SkillMcpManager", () => {
serverName: "no-stepup-server", serverName: "no-stepup-server",
skillName: "no-stepup-skill", skillName: "no-stepup-skill",
sessionID: "session-no-stepup", sessionID: "session-no-stepup",
scope: "builtin",
} }
const context: SkillMcpServerContext = { const context: SkillMcpServerContext = {
config: { config: {
@@ -23,6 +23,7 @@ export async function formatMcpCapabilities(
serverName, serverName,
skillName: skill.name, skillName: skill.name,
sessionID, sessionID,
scope: skill.scope,
} }
const context: SkillMcpServerContext = { const context: SkillMcpServerContext = {
config, config,