fix(atlas): address review findings for task session reuse

src/hooks/atlas/subagent-session-id.test.ts

@@ -25,6 +25,17 @@ describe("extractSessionIdFromOutput", () => {
     expect(result).toBe("ses_sync_12345")
   })
 
+  test("extracts hyphenated session IDs from task metadata blocks", () => {
+    // given
+    const output = `Task completed.\n\n<task_metadata>\nsession_id: ses_auth-flow-123\n</task_metadata>`
+
+    // when
+    const result = extractSessionIdFromOutput(output)
+
+    // then
+    expect(result).toBe("ses_auth-flow-123")
+  })
+
   test("returns undefined when no session id is present", () => {
     // given
     const output = "Task completed without metadata"

src/hooks/atlas/subagent-session-id.ts

@@ -7,13 +7,13 @@ export function extractSessionIdFromOutput(output: string): string | undefined {
   const taskMetadataBlocks = [...output.matchAll(/<task_metadata>([\s\S]*?)<\/task_metadata>/gi)]
   const lastTaskMetadataBlock = taskMetadataBlocks.at(-1)?.[1]
   if (lastTaskMetadataBlock) {
-    const taskMetadataSessionMatch = lastTaskMetadataBlock.match(/session_id:\s*(ses_[a-zA-Z0-9_]+)/i)
+    const taskMetadataSessionMatch = lastTaskMetadataBlock.match(/session_id:\s*(ses_[a-zA-Z0-9_-]+)/i)
     if (taskMetadataSessionMatch) {
       return taskMetadataSessionMatch[1]
     }
   }
 
-  const explicitSessionMatches = [...output.matchAll(/Session ID:\s*(ses_[a-zA-Z0-9_]+)/g)]
+  const explicitSessionMatches = [...output.matchAll(/Session ID:\s*(ses_[a-zA-Z0-9_-]+)/g)]
   return explicitSessionMatches.at(-1)?.[1]
 }
 

src/hooks/atlas/tool-execute-after.ts

@@ -160,8 +160,8 @@ export function createToolExecuteAfterHandler(input: {
             taskLabel: currentTask.label,
             taskTitle: currentTask.title,
             sessionId: subagentSessionId,
-            agent: toolOutput.metadata?.agent as string | undefined,
-            category: toolOutput.metadata?.category as string | undefined,
+            agent: typeof toolOutput.metadata?.agent === "string" ? toolOutput.metadata.agent : undefined,
+            category: typeof toolOutput.metadata?.category === "string" ? toolOutput.metadata.category : undefined,
           })
         }