test: update plugin tests for MCP-backed LSP

src/plugin-dispose.test.ts

@@ -12,14 +12,10 @@ describe("createPluginDispose", () => {
     const skillMcpManager = {
       disconnectAll: async (): Promise<void> => {},
     }
-    const lspManager = {
-      stopAll: async (): Promise<void> => {},
-    }
     const shutdownSpy = spyOn(backgroundManager, "shutdown")
     const dispose = createPluginDispose({
       backgroundManager,
       skillMcpManager,
-      lspManager,
       disposeHooks: (): void => {},
     })
 
@@ -38,14 +34,10 @@ describe("createPluginDispose", () => {
     const skillMcpManager = {
       disconnectAll: async (): Promise<void> => {},
     }
-    const lspManager = {
-      stopAll: async (): Promise<void> => {},
-    }
     const disconnectAllSpy = spyOn(skillMcpManager, "disconnectAll")
     const dispose = createPluginDispose({
       backgroundManager,
       skillMcpManager,
-      lspManager,
       disposeHooks: (): void => {},
     })
 
@@ -73,9 +65,6 @@ describe("createPluginDispose", () => {
     const autoSlashCommand = {
       dispose: (): void => {},
     }
-    const lspManager = {
-      stopAll: async (): Promise<void> => {},
-    }
     const claudeCodeHooksDisposeSpy = spyOn(claudeCodeHooks, "dispose")
     const commentCheckerDisposeSpy = spyOn(commentChecker, "dispose")
     const runtimeFallbackDisposeSpy = spyOn(runtimeFallback, "dispose")
@@ -88,7 +77,6 @@ describe("createPluginDispose", () => {
       skillMcpManager: {
         disconnectAll: async (): Promise<void> => {},
       },
-      lspManager,
       disposeHooks: (): void => {
         disposeCreatedHooks({
           claudeCodeHooks,
@@ -119,20 +107,15 @@ describe("createPluginDispose", () => {
     const skillMcpManager = {
       disconnectAll: async (): Promise<void> => {},
     }
-    const lspManager = {
-      stopAll: async (): Promise<void> => {},
-    }
     const disposeHooks = {
       run: (): void => {},
     }
     const shutdownSpy = spyOn(backgroundManager, "shutdown")
     const disconnectAllSpy = spyOn(skillMcpManager, "disconnectAll")
-    const stopAllSpy = spyOn(lspManager, "stopAll")
     const disposeHooksSpy = spyOn(disposeHooks, "run")
     const dispose = createPluginDispose({
       backgroundManager,
       skillMcpManager,
-      lspManager,
       disposeHooks: disposeHooks.run,
     })
 
@@ -143,7 +126,6 @@ describe("createPluginDispose", () => {
     // then
       expect(shutdownSpy).toHaveBeenCalledTimes(1)
       expect(disconnectAllSpy).toHaveBeenCalledTimes(1)
-      expect(stopAllSpy).toHaveBeenCalledTimes(1)
       expect(disposeHooksSpy).toHaveBeenCalledTimes(1)
   })
 
@@ -157,15 +139,11 @@ describe("createPluginDispose", () => {
     const skillMcpManager = {
       disconnectAll: async (): Promise<void> => {},
     }
-    const lspManager = {
-      stopAll: async (): Promise<void> => {},
-    }
     const disposeHooksCalls: number[] = []
     const disconnectAllSpy = spyOn(skillMcpManager, "disconnectAll")
     const dispose = createPluginDispose({
       backgroundManager,
       skillMcpManager,
-      lspManager,
       disposeHooks: (): void => {
         disposeHooksCalls.push(1)
       },
@@ -189,15 +167,11 @@ describe("createPluginDispose", () => {
         throw new Error("disconnectAll failed")
       },
     }
-    const lspManager = {
-      stopAll: async (): Promise<void> => {},
-    }
     const disposeHooksCalls: number[] = []
     const shutdownSpy = spyOn(backgroundManager, "shutdown")
     const dispose = createPluginDispose({
       backgroundManager,
       skillMcpManager,
-      lspManager,
       disposeHooks: (): void => {
         disposeHooksCalls.push(1)
       },
@@ -210,28 +184,4 @@ describe("createPluginDispose", () => {
     expect(shutdownSpy).toHaveBeenCalledTimes(1)
     expect(disposeHooksCalls).toHaveLength(1)
   })
-
-  test("#given active LSP clients #when dispose runs #then lsp manager is stopped", async () => {
-    // given
-    const lspManager = {
-      stopAll: async (): Promise<void> => {},
-    }
-    const stopAllSpy = spyOn(lspManager, "stopAll")
-    const dispose = createPluginDispose({
-      backgroundManager: {
-        shutdown: async (): Promise<void> => {},
-      },
-      skillMcpManager: {
-        disconnectAll: async (): Promise<void> => {},
-      },
-      lspManager,
-      disposeHooks: (): void => {},
-    })
-
-    // when
-    await dispose()
-
-    // then
-    expect(stopAllSpy).toHaveBeenCalledTimes(1)
-  })
 })