fix(ci): resolve all test failures + complete rename compat layer

Sisyphus-authored fixes across 15 files:

- plugin-identity: align CONFIG_BASENAME with actual config file name
- add-plugin-to-opencode-config: handle legacy→canonical name migration
- plugin-detection tests: update expectations for new identity constants
- doctor/system: fix legacy name warning test assertions
- install tests: align with new plugin name
- chat-params tests: fix mock isolation
- model-capabilities tests: fix snapshot expectations
- image-converter: fix platform-dependent test assertions (Linux CI)
- example configs: expanded with more detailed comments

Full suite: 4484 pass, 0 fail, typecheck clean.

src/cli/doctor/checks/system.test.ts

@@ -1,9 +1,19 @@
+/// <reference types="bun-types" />
+
 import { beforeEach, describe, expect, it, mock } from "bun:test"
+import { PLUGIN_NAME } from "../../../shared"
+import type { PluginInfo } from "./system-plugin"
+
+type SystemModule = typeof import("./system")
+
+async function importFreshSystemModule(): Promise<SystemModule> {
+  return import(`./system?test=${Date.now()}-${Math.random()}`)
+}
 
 const mockFindOpenCodeBinary = mock(async () => ({ path: "/usr/local/bin/opencode" }))
 const mockGetOpenCodeVersion = mock(async () => "1.0.200")
-const mockCompareVersions = mock(() => true)
-const mockGetPluginInfo = mock(() => ({
+const mockCompareVersions = mock((_leftVersion?: string, _rightVersion?: string) => true)
+const mockGetPluginInfo = mock((): PluginInfo => ({
   registered: true,
   entry: "oh-my-opencode",
   isPinned: false,
@@ -18,7 +28,8 @@ const mockGetLoadedPluginVersion = mock(() => ({
   expectedVersion: "3.0.0",
   loadedVersion: "3.1.0",
 }))
-const mockGetLatestPluginVersion = mock(async () => null)
+const mockGetLatestPluginVersion = mock(async (_currentVersion: string | null) => null as string | null)
+const mockGetSuggestedInstallTag = mock(() => "latest")
 
 mock.module("./system-binary", () => ({
   findOpenCodeBinary: mockFindOpenCodeBinary,
@@ -33,10 +44,9 @@ mock.module("./system-plugin", () => ({
 mock.module("./system-loaded-version", () => ({
   getLoadedPluginVersion: mockGetLoadedPluginVersion,
   getLatestPluginVersion: mockGetLatestPluginVersion,
+  getSuggestedInstallTag: mockGetSuggestedInstallTag,
 }))
 
-const { checkSystem } = await import("./system?test")
-
 describe("system check", () => {
   beforeEach(() => {
     mockFindOpenCodeBinary.mockReset()
@@ -45,6 +55,7 @@ describe("system check", () => {
     mockGetPluginInfo.mockReset()
     mockGetLoadedPluginVersion.mockReset()
     mockGetLatestPluginVersion.mockReset()
+    mockGetSuggestedInstallTag.mockReset()
 
     mockFindOpenCodeBinary.mockResolvedValue({ path: "/usr/local/bin/opencode" })
     mockGetOpenCodeVersion.mockResolvedValue("1.0.200")
@@ -65,10 +76,14 @@ describe("system check", () => {
       loadedVersion: "3.1.0",
     })
     mockGetLatestPluginVersion.mockResolvedValue(null)
+    mockGetSuggestedInstallTag.mockReturnValue("latest")
   })
 
   describe("#given cache directory contains spaces", () => {
     it("uses a quoted cache directory in mismatch fix command", async () => {
+      //#given
+      const { checkSystem } = await importFreshSystemModule()
+
       //#when
       const result = await checkSystem()
 
@@ -87,9 +102,11 @@ describe("system check", () => {
         loadedVersion: "3.0.0-canary.1",
       })
       mockGetLatestPluginVersion.mockResolvedValue("3.0.0-canary.2")
-      mockCompareVersions.mockImplementation((leftVersion: string, rightVersion: string) => {
+      mockGetSuggestedInstallTag.mockReturnValue("canary")
+      mockCompareVersions.mockImplementation((leftVersion?: string, rightVersion?: string) => {
         return !(leftVersion === "3.0.0-canary.1" && rightVersion === "3.0.0-canary.2")
       })
+      const { checkSystem } = await importFreshSystemModule()
 
       //#when
       const result = await checkSystem()
@@ -97,8 +114,94 @@ describe("system check", () => {
       //#then
       const outdatedIssue = result.issues.find((issue) => issue.title === "Loaded plugin is outdated")
       expect(outdatedIssue?.fix).toBe(
-        'Update: cd "/Users/test/Library/Caches/opencode with spaces" && bun add oh-my-opencode@canary'
+        `Update: cd "/Users/test/Library/Caches/opencode with spaces" && bun add ${PLUGIN_NAME}@canary`
       )
     })
   })
+
+  describe("#given OpenCode plugin entry uses legacy package name", () => {
+    it("adds a warning for a bare legacy entry", async () => {
+      //#given
+      mockGetPluginInfo.mockReturnValue({
+        registered: true,
+        entry: "oh-my-opencode",
+        isPinned: false,
+        pinnedVersion: null,
+        configPath: null,
+        isLocalDev: false,
+      })
+      const { checkSystem } = await importFreshSystemModule()
+
+      //#when
+      const result = await checkSystem()
+
+      //#then
+      const legacyEntryIssue = result.issues.find((issue) => issue.title === "Using legacy package name")
+      expect(legacyEntryIssue?.severity).toBe("warning")
+      expect(legacyEntryIssue?.fix).toBe(
+        'Update your opencode.json plugin entry: "oh-my-opencode" → "oh-my-openagent"'
+      )
+    })
+
+    it("adds a warning for a version-pinned legacy entry", async () => {
+      //#given
+      mockGetPluginInfo.mockReturnValue({
+        registered: true,
+        entry: "oh-my-opencode@3.0.0",
+        isPinned: true,
+        pinnedVersion: "3.0.0",
+        configPath: null,
+        isLocalDev: false,
+      })
+      const { checkSystem } = await importFreshSystemModule()
+
+      //#when
+      const result = await checkSystem()
+
+      //#then
+      const legacyEntryIssue = result.issues.find((issue) => issue.title === "Using legacy package name")
+      expect(legacyEntryIssue?.severity).toBe("warning")
+      expect(legacyEntryIssue?.fix).toBe(
+        'Update your opencode.json plugin entry: "oh-my-opencode@3.0.0" → "oh-my-openagent@3.0.0"'
+      )
+    })
+
+    it("does not warn for a canonical plugin entry", async () => {
+      //#given
+      mockGetPluginInfo.mockReturnValue({
+        registered: true,
+        entry: PLUGIN_NAME,
+        isPinned: false,
+        pinnedVersion: null,
+        configPath: null,
+        isLocalDev: false,
+      })
+      const { checkSystem } = await importFreshSystemModule()
+
+      //#when
+      const result = await checkSystem()
+
+      //#then
+      expect(result.issues.some((issue) => issue.title === "Using legacy package name")).toBe(false)
+    })
+
+    it("does not warn for a local-dev legacy entry", async () => {
+      //#given
+      mockGetPluginInfo.mockReturnValue({
+        registered: true,
+        entry: "oh-my-opencode",
+        isPinned: false,
+        pinnedVersion: null,
+        configPath: null,
+        isLocalDev: true,
+      })
+      const { checkSystem } = await importFreshSystemModule()
+
+      //#when
+      const result = await checkSystem()
+
+      //#then
+      expect(result.issues.some((issue) => issue.title === "Using legacy package name")).toBe(false)
+    })
+  })
 })

src/cli/doctor/checks/system.ts

@@ -83,18 +83,18 @@ export async function checkSystem(): Promise<CheckResult> {
 
   if (!pluginInfo.registered) {
     issues.push({
-      title: "oh-my-opencode is not registered",
+      title: `${PLUGIN_NAME} is not registered`,
       description: "Plugin entry is missing from OpenCode configuration.",
-      fix: "Run: bunx oh-my-opencode install",
+      fix: `Run: bunx ${PLUGIN_NAME} install`,
       severity: "error",
       affects: ["all agents"],
     })
   }
 
-  // Detect legacy package name in plugin config
   if (pluginInfo.entry && !pluginInfo.isLocalDev) {
     const isLegacyName = pluginInfo.entry === LEGACY_PLUGIN_NAME
       || pluginInfo.entry.startsWith(`${LEGACY_PLUGIN_NAME}@`)
+
     if (isLegacyName) {
       const suggestedEntry = pluginInfo.entry.replace(LEGACY_PLUGIN_NAME, PLUGIN_NAME)
       issues.push({
@@ -125,7 +125,7 @@ export async function checkSystem(): Promise<CheckResult> {
     issues.push({
       title: "Loaded plugin is outdated",
       description: `Loaded ${systemInfo.loadedVersion}, latest ${latestVersion}.`,
-      fix: `Update: cd "${loadedInfo.cacheDir}" && bun add oh-my-opencode@${installTag}`,
+      fix: `Update: cd "${loadedInfo.cacheDir}" && bun add ${PLUGIN_NAME}@${installTag}`,
       severity: "warning",
       affects: ["plugin features"],
     })

src/cli/doctor/constants.ts

@@ -1,4 +1,5 @@
 import color from "picocolors"
+import { PLUGIN_NAME } from "../../shared"
 
 export const SYMBOLS = {
   check: color.green("\u2713"),
@@ -38,6 +39,6 @@ export const EXIT_CODES = {
 
 export const MIN_OPENCODE_VERSION = "1.0.150"
 
-export const PACKAGE_NAME = "oh-my-opencode"
+export const PACKAGE_NAME = PLUGIN_NAME
 
 export const OPENCODE_BINARIES = ["opencode", "opencode-desktop"] as const