From 5441c848bad5904549c64fb3f1c402a5d71244be Mon Sep 17 00:00:00 2001
From: trafgals <slagfart@gmail.com>
Date: Sat, 4 Apr 2026 07:23:12 +1000
Subject: [PATCH] refactor: use spyOn instead of vi.mock for agent loader mocks

Use spyOn which is more idiomatic for bun:test, as suggested in PR review.
---
 src/tools/delegate-task/subagent-resolver.test.ts | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/src/tools/delegate-task/subagent-resolver.test.ts b/src/tools/delegate-task/subagent-resolver.test.ts
index 013a256ed..825eeccf2 100644
--- a/src/tools/delegate-task/subagent-resolver.test.ts
+++ b/src/tools/delegate-task/subagent-resolver.test.ts
@@ -5,14 +5,7 @@ import type { DelegateTaskArgs } from "./types"
 import type { ExecutorContext } from "./executor-types"
 import * as logger from "../../shared/logger"
 import * as connectedProvidersCache from "../../shared/connected-providers-cache"
-
-const mockLoadUserAgents = vi.fn().mockReturnValue({})
-const mockLoadProjectAgents = vi.fn().mockReturnValue({})
-
-vi.mock("../../features/claude-code-agent-loader", () => ({
-  loadUserAgents: mockLoadUserAgents,
-  loadProjectAgents: mockLoadProjectAgents,
-}))
+import * as agentLoader from "../../features/claude-code-agent-loader"
 
 function createBaseArgs(overrides?: Partial<DelegateTaskArgs>): DelegateTaskArgs {
   return {
@@ -45,14 +38,20 @@ function createExecutorContext(
 
 describe("resolveSubagentExecution", () => {
   let logSpy: ReturnType<typeof spyOn> | undefined
+  let mockLoadUserAgents: ReturnType<typeof spyOn>
+  let mockLoadProjectAgents: ReturnType<typeof spyOn>
 
   beforeEach(() => {
     mock.restore()
     logSpy = spyOn(logger, "log").mockImplementation(() => {})
+    mockLoadUserAgents = spyOn(agentLoader, "loadUserAgents").mockReturnValue({})
+    mockLoadProjectAgents = spyOn(agentLoader, "loadProjectAgents").mockReturnValue({})
   })
 
   afterEach(() => {
     logSpy?.mockRestore()
+    mockLoadUserAgents?.mockRestore()
+    mockLoadProjectAgents?.mockRestore()
   })
 
   test("returns delegation error when agent discovery fails instead of silently proceeding", async () => {