fix(athena): address 5 audit findings — remove harmful thinking config, add error handling, improve tests

- Remove applyModelThinkingConfig and all callers (OpenCode handles thinking natively)

- Add try/catch error handling to prepare_council_prompt filesystem operations

- Add mode input validation to prepare_council_prompt tool

- Add 2 missing placeholder test cases (RETRY_FAILED_IF_OTHERS_FINISHED, CANCEL_RETRYING_ON_QUORUM)

- Remove redundant 'Do NOT use TodoWrite' prompt section from council member agent
This commit is contained in:
ismeth
2026-02-26 15:12:57 +01:00
committed by YeonGyu-Kim
parent 4cd27f620e
commit 5a819d0914
7 changed files with 34 additions and 126 deletions
+2 -8
View File
@@ -1,7 +1,6 @@
import type { AgentConfig } from "@opencode-ai/sdk"
import type { AgentMode } from "../types"
import { createAgentToolAllowlist } from "../../shared"
import { applyModelThinkingConfig } from "./model-thinking-config"
const MODE: AgentMode = "subagent"
@@ -57,12 +56,7 @@ You MUST wrap your final analysis in <COUNCIL_MEMBER_RESPONSE> tags. This is how
</COUNCIL_MEMBER_RESPONSE>
\`\`\`
If you do not wrap your response in these tags, your analysis will not be included in the synthesis.
## CRITICAL: Do NOT use TodoWrite
- Do NOT create todos or task lists
- Do NOT use the TodoWrite tool under any circumstances
- Simply report your findings directly in your response`
If you do not wrap your response in these tags, your analysis will not be included in the synthesis.`
export const COUNCIL_SOLO_ADDENDUM = `
## Solo Analysis Mode
@@ -129,6 +123,6 @@ export function createCouncilMemberAgent(model: string): AgentConfig {
...restrictions,
}
return applyModelThinkingConfig(base, model)
return base
}
createCouncilMemberAgent.mode = MODE