fix(installer): bound outputPromise wait after kill to prevent indirect hang

After SIGTERM/SIGKILL escalation, the stdout stream may not close immediately on all platforms. The unconditional await on outputPromise could then hang indefinitely, defeating the bounded process lifetime guarantee. Race outputPromise against a short follow-up timeout to ensure getOpenCodeVersion always returns within a bounded time.

Refs #3766
This commit is contained in:
YeonGyu-Kim
2026-05-11 09:24:42 +09:00
parent 84073897c6
commit 5d1c8718d7
2 changed files with 42 additions and 4 deletions
+3 -2
View File
@@ -6,6 +6,7 @@ import { initConfigContext } from "./config-context"
const OPENCODE_BINARIES = ["opencode", "opencode-desktop"] as const
const OPENCODE_VERSION_CHECK_TIMEOUT_MS = 1500
const OPENCODE_VERSION_KILL_GRACE_MS = 200
const OPENCODE_OUTPUT_WAIT_TIMEOUT_MS = 200
interface OpenCodeBinaryResult {
binary: OpenCodeBinaryType
@@ -44,9 +45,9 @@ async function findOpenCodeBinaryWithVersion(): Promise<OpenCodeBinaryResult | n
new Promise<string>((resolve) => {
setTimeout(() => {
resolve("")
}, OPENCODE_VERSION_KILL_GRACE_MS)
}, OPENCODE_OUTPUT_WAIT_TIMEOUT_MS)
}),
])
]).catch(() => "")
if (timedExitCode === 0 && proc.exitCode === 0) {
const version = extractSemverFromOutput(output) ?? output.trim()