luna/oh-my-opencode
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(athena): harden council tool error handling and type safety

Browse Source 
Improve not-configured error message with config file path. Wrap metadataFn in try/catch for best-effort metadata. Replace unsafe as-casts with getToolContextProperty helper. Show Name (model) format in errors. Return error directly for empty member selection.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This commit is contained in:
ismeth
2026-02-18 20:56:07 +01:00
committed by YeonGyu-Kim
parent f0922ecb4d
commit 5d32d5891b
2 changed files with 46 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/tools/athena-council/tools.test.ts
+14 -10
View File
@@ -39,16 +39,20 @@ function createRunningTask(id: string, sessionID = `ses-${id}`): BackgroundTask
}
describe("filterCouncilMembers", () => {
test("returns all members when selection is undefined", () => {
test("returns selection error when selection is undefined", () => {
const result = filterCouncilMembers(configuredMembers, undefined)
expect(result.members).toEqual(configuredMembers)
expect(result.error).toBeUndefined()
expect(result.members).toEqual([])
expect(result.error).toBe(
"athena_council runs one member per call. Pass exactly one member in members (single-item array). Available members: Claude, GPT, google/gemini-3-pro."
)
})
test("returns all members when selection is empty", () => {
test("returns selection error when selection is empty", () => {
const result = filterCouncilMembers(configuredMembers, [])
expect(result.members).toEqual(configuredMembers)
expect(result.error).toBeUndefined()
expect(result.members).toEqual([])
expect(result.error).toBe(
"athena_council runs one member per call. Pass exactly one member in members (single-item array). Available members: Claude, GPT, google/gemini-3-pro."
)
})
test("filters members using case-insensitive name and model matching", () => {
@@ -61,7 +65,7 @@ describe("filterCouncilMembers", () => {
const result = filterCouncilMembers(configuredMembers, ["mistral", "xai/grok-3"])
expect(result.members).toEqual([])
expect(result.error).toBe(
"Unknown council members: mistral, xai/grok-3. Available members: Claude, GPT, google/gemini-3-pro."
"Unknown council members: mistral, xai/grok-3. Available: Claude (anthropic/claude-sonnet-4-5), GPT (openai/gpt-5.3-codex), google/gemini-3-pro."
)
})
@@ -81,7 +85,7 @@ describe("createAthenaCouncilTool", () => {
const result = await athenaCouncilTool.execute({ question: "How should we proceed?" }, mockToolContext)
expect(result).toBe("Athena council not configured. Add agents.athena.council.members to your config.")
expect(result).toBe("Athena council is not configured. Add council members to agents.athena.council.members in .opencode/oh-my-opencode.jsonc.")
})
test("returns error when councilConfig has empty members", async () => {
@@ -92,7 +96,7 @@ describe("createAthenaCouncilTool", () => {
const result = await athenaCouncilTool.execute({ question: "Any concerns?" }, mockToolContext)
expect(result).toBe("Athena council not configured. Add agents.athena.council.members to your config.")
expect(result).toBe("Athena council is not configured. Add council members to agents.athena.council.members in .opencode/oh-my-opencode.jsonc.")
})
test("returns helpful error when members contains invalid names", async () => {
@@ -106,7 +110,7 @@ describe("createAthenaCouncilTool", () => {
mockToolContext
)
expect(result).toBe("Unknown council members: unknown-model. Available members: Claude, GPT, google/gemini-3-pro.")
expect(result).toBe("Unknown council members: unknown-model. Available: Claude (anthropic/claude-sonnet-4-5), GPT (openai/gpt-5.3-codex), google/gemini-3-pro.")
})
test("returns selection error when members are omitted", async () => {