fix(plugin): cover Anthropic-family prefill guard
Include Vertex Anthropic in the assistant-tail prefill guard after Cubic flagged the strict provider check. Keep the non-Anthropic opencode negative control covered by tests. Plan: plans/fix-anthropic-assistant-prefill-tail.md
This commit is contained in:
@@ -328,6 +328,47 @@ describe("createMessagesTransformHandler", () => {
|
|||||||
})
|
})
|
||||||
})
|
})
|
||||||
|
|
||||||
|
it("#given an Anthropic-family provider history ends with a rejecting assistant tail #when messages transform runs #then it appends a synthetic user recovery turn", async () => {
|
||||||
|
//#given
|
||||||
|
const messages: TestMessage[] = [
|
||||||
|
{
|
||||||
|
info: {
|
||||||
|
id: "msg_user_vertex_anthropic",
|
||||||
|
role: "user",
|
||||||
|
sessionID: "ses_vertex_anthropic",
|
||||||
|
agent: "sisyphus",
|
||||||
|
model: { providerID: "google-vertex-anthropic", modelID: "claude-opus-4-7" },
|
||||||
|
},
|
||||||
|
parts: [{ type: "text", text: "continue" }],
|
||||||
|
},
|
||||||
|
{
|
||||||
|
info: {
|
||||||
|
id: "msg_assistant_vertex_anthropic",
|
||||||
|
role: "assistant",
|
||||||
|
sessionID: "ses_vertex_anthropic",
|
||||||
|
},
|
||||||
|
parts: [{ type: "text", text: "done" }],
|
||||||
|
},
|
||||||
|
]
|
||||||
|
|
||||||
|
//#when
|
||||||
|
await runHandler(makeHooks({}), messages)
|
||||||
|
|
||||||
|
//#then
|
||||||
|
expect(messages).toHaveLength(3)
|
||||||
|
expect(messages.at(-1)?.info).toMatchObject({
|
||||||
|
role: "user",
|
||||||
|
sessionID: "ses_vertex_anthropic",
|
||||||
|
agent: "sisyphus",
|
||||||
|
model: { providerID: "google-vertex-anthropic", modelID: "claude-opus-4-7" },
|
||||||
|
})
|
||||||
|
expect(messages.at(-1)?.parts[0]).toMatchObject({
|
||||||
|
type: "text",
|
||||||
|
text: "[internal] Continue from the previous assistant state.",
|
||||||
|
synthetic: true,
|
||||||
|
})
|
||||||
|
})
|
||||||
|
|
||||||
it("#given rejecting model metadata uses direct provider and model fields #when messages transform runs #then it appends a synthetic user recovery turn", async () => {
|
it("#given rejecting model metadata uses direct provider and model fields #when messages transform runs #then it appends a synthetic user recovery turn", async () => {
|
||||||
//#given
|
//#given
|
||||||
const messages: TestMessage[] = [
|
const messages: TestMessage[] = [
|
||||||
|
|||||||
@@ -5,7 +5,10 @@ import { normalizeModelID } from "../shared/model-normalization"
|
|||||||
import type { CreatedHooks } from "../create-hooks"
|
import type { CreatedHooks } from "../create-hooks"
|
||||||
|
|
||||||
const ASSISTANT_PREFILL_RECOVERY_TEXT = "[internal] Continue from the previous assistant state."
|
const ASSISTANT_PREFILL_RECOVERY_TEXT = "[internal] Continue from the previous assistant state."
|
||||||
const ASSISTANT_PREFILL_UNSUPPORTED_PROVIDER = "anthropic"
|
const ASSISTANT_PREFILL_UNSUPPORTED_PROVIDERS = new Set([
|
||||||
|
"anthropic",
|
||||||
|
"google-vertex-anthropic",
|
||||||
|
])
|
||||||
const ASSISTANT_PREFILL_UNSUPPORTED_MODEL_PREFIXES = [
|
const ASSISTANT_PREFILL_UNSUPPORTED_MODEL_PREFIXES = [
|
||||||
"claude-opus-4-7",
|
"claude-opus-4-7",
|
||||||
"claude-opus-4-6",
|
"claude-opus-4-6",
|
||||||
@@ -94,7 +97,7 @@ function shouldRepairAssistantPrefillForModel(model: ModelIdentifier | undefined
|
|||||||
}
|
}
|
||||||
|
|
||||||
const providerID = model.providerID.toLowerCase()
|
const providerID = model.providerID.toLowerCase()
|
||||||
if (providerID !== ASSISTANT_PREFILL_UNSUPPORTED_PROVIDER) {
|
if (!ASSISTANT_PREFILL_UNSUPPORTED_PROVIDERS.has(providerID)) {
|
||||||
return false
|
return false
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user