From 60e1f6d580df05b7d50edef88da0b9440094d927 Mon Sep 17 00:00:00 2001 From: YeonGyu-Kim Date: Wed, 18 Mar 2026 12:37:21 +0900 Subject: [PATCH] fix: resolve Cubic review issues - workflow YAML, issue templates, stale references --- .github/ISSUE_TEMPLATE/bug_report.yml | 6 +++++- .github/ISSUE_TEMPLATE/feature_request.yml | 3 +++ .github/ISSUE_TEMPLATE/general.yml | 2 ++ .github/workflows/publish-platform.yml | 11 ++++++----- .github/workflows/publish.yml | 2 ++ .github/workflows/sisyphus-agent.yml | 1 + CONTRIBUTING.md | 2 +- src/agents/sisyphus-junior/gemini.ts | 3 +-- src/agents/sisyphus-junior/gpt-5-4.ts | 1 - 9 files changed, 21 insertions(+), 10 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index cfa5cd663..8fdb4e7ea 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -13,10 +13,13 @@ body: description: Please confirm the following before submitting options: - label: I will write this issue in English (see our [Language Policy](https://github.com/code-yeongyu/oh-my-openagent/blob/dev/CONTRIBUTING.md#language-policy)) + required: true - label: I have searched existing issues to avoid duplicates required: true - label: I am using the latest version of oh-my-openagent + required: true - label: I have read the [documentation](https://github.com/code-yeongyu/oh-my-openagent#readme) or asked an AI coding agent with this project's GitHub URL loaded and couldn't find the answer + required: true - type: textarea id: description @@ -84,7 +87,8 @@ body: id: config attributes: label: Configuration - description: If relevant, share your oh-my-openagent configuration (remove sensitive data) + description: If relevant, share your oh-my-openagent configuration (remove sensitive data) + placeholder: | { "agents": { ... }, "disabled_hooks": [ ... ] diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml index 6d8ad6db2..707fb61df 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.yml +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -13,10 +13,13 @@ body: description: Please confirm the following before submitting options: - label: I will write this issue in English (see our [Language Policy](https://github.com/code-yeongyu/oh-my-openagent/blob/dev/CONTRIBUTING.md#language-policy)) + required: true - label: I have searched existing issues and discussions to avoid duplicates required: true - label: This feature request is specific to oh-my-openagent (not OpenCode core) + required: true - label: I have read the [documentation](https://github.com/code-yeongyu/oh-my-openagent#readme) or asked an AI coding agent with this project's GitHub URL loaded and couldn't find the answer + required: true - type: textarea id: problem diff --git a/.github/ISSUE_TEMPLATE/general.yml b/.github/ISSUE_TEMPLATE/general.yml index d98878484..cd4e5db0a 100644 --- a/.github/ISSUE_TEMPLATE/general.yml +++ b/.github/ISSUE_TEMPLATE/general.yml @@ -13,9 +13,11 @@ body: description: Please confirm the following before submitting options: - label: I will write this issue in English (see our [Language Policy](https://github.com/code-yeongyu/oh-my-openagent/blob/dev/CONTRIBUTING.md#language-policy)) + required: true - label: I have searched existing issues and discussions required: true - label: I have read the [documentation](https://github.com/code-yeongyu/oh-my-openagent#readme) or asked an AI coding agent with this project's GitHub URL loaded and couldn't find the answer + required: true - label: This is a question (not a bug report or feature request) required: true diff --git a/.github/workflows/publish-platform.yml b/.github/workflows/publish-platform.yml index 4c2dd1173..195bb4602 100644 --- a/.github/workflows/publish-platform.yml +++ b/.github/workflows/publish-platform.yml @@ -269,6 +269,7 @@ jobs: registry-url: "https://registry.npmjs.org" - name: Publish oh-my-openagent-${{ matrix.platform }} + if: steps.check.outputs.skip != 'true' && steps.download.outcome == 'success' run: | cd packages/${{ matrix.platform }} @@ -284,21 +285,21 @@ jobs: timeout-minutes: 15 - name: Publish oh-my-opencode-${{ matrix.platform }} (alias) + if: steps.check.outputs.skip != 'true' && steps.download.outcome == 'success' + run: | cd packages/${{ matrix.platform }} - + # Rename package for oh-my-opencode jq --arg name "oh-my-opencode-${{ matrix.platform }}" \ --arg desc "Platform-specific binary for oh-my-opencode (${{ matrix.platform }})" \ '.name = $name | .description = $desc | .bin = {"oh-my-opencode": (.bin | to_entries | .[0].value)}' \ package.json > tmp.json && mv tmp.json package.json - '.name = $name | .description = $desc | .bin = {"oh-my-openagent": (.bin | to_entries | .[0].value)}' \ - package.json > tmp.json && mv tmp.json package.json - + TAG_ARG="" if [ -n "${{ inputs.dist_tag }}" ]; then TAG_ARG="--tag ${{ inputs.dist_tag }}" fi - + npm publish --access public --provenance $TAG_ARG env: NODE_AUTH_TOKEN: ${{ secrets.NODE_AUTH_TOKEN }} diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index eb8f99ca0..7e55e2df1 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -152,6 +152,7 @@ jobs: VERSION="${{ inputs.version }}" if [ -z "$VERSION" ]; then PREV=$(curl -s https://registry.npmjs.org/oh-my-openagent/latest | jq -r '.version // "0.0.0"') + BASE="${PREV%%-*}" IFS='.' read -r MAJOR MINOR PATCH <<< "$BASE" case "${{ inputs.bump }}" in major) VERSION="$((MAJOR+1)).0.0" ;; @@ -173,6 +174,7 @@ jobs: - name: Check if already published id: check run: | + VERSION="${{ steps.version.outputs.version }}" STATUS=$(curl -s -o /dev/null -w "%{http_code}" "https://registry.npmjs.org/oh-my-openagent/${VERSION}") if [ "$STATUS" = "200" ]; then echo "skip=true" >> $GITHUB_OUTPUT diff --git a/.github/workflows/sisyphus-agent.yml b/.github/workflows/sisyphus-agent.yml index bae8ebc6a..3cfa80b9b 100644 --- a/.github/workflows/sisyphus-agent.yml +++ b/.github/workflows/sisyphus-agent.yml @@ -110,6 +110,7 @@ jobs: REPO_PATH=$(pwd) jq --arg path "file://$REPO_PATH/src/index.ts" ' .plugin = [.plugin[] | select(. != "oh-my-opencode" and . != "oh-my-openagent")] + [$path] + ' "$OPENCODE_JSON" > /tmp/oc.json && mv /tmp/oc.json "$OPENCODE_JSON" OPENCODE_JSON=~/.config/opencode/opencode.json jq --arg baseURL "$ANTHROPIC_BASE_URL" --arg apiKey "$ANTHROPIC_API_KEY" ' diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index adb99b174..950347005 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -110,7 +110,7 @@ After making changes, you can test your local build in OpenCode: ``` oh-my-openagent/ ├── src/ -│ ├── index.ts # Plugin entry (OhMyOpenCodePlugin) +│ ├── index.ts # Plugin entry (OhMyOpenAgentPlugin) │ ├── plugin-config.ts # JSONC multi-level config (Zod v4) │ ├── agents/ # 11 agents (Sisyphus, Hephaestus, Oracle, Librarian, Explore, Atlas, Prometheus, Metis, Momus, Multimodal-Looker, Sisyphus-Junior) │ ├── hooks/ # Lifecycle hooks for orchestration, recovery, UX, and context management diff --git a/src/agents/sisyphus-junior/gemini.ts b/src/agents/sisyphus-junior/gemini.ts index 296bd1f70..d3b77faf1 100644 --- a/src/agents/sisyphus-junior/gemini.ts +++ b/src/agents/sisyphus-junior/gemini.ts @@ -20,7 +20,6 @@ export function buildGeminiSisyphusJuniorPrompt( ? "All tasks marked completed" : "All todos marked completed" const prompt = `You are Sisyphus-Junior — a focused task executor from OhMyOpenAgent. - You are Sisyphus-Junior — a focused task executor from OhMyOpenAgent. ## Identity @@ -191,4 +190,4 @@ No tasks on multi-step work = INCOMPLETE WORK. The user tracks your progress thr - **Batching** — NEVER batch completions. Mark EACH todo individually. No todos on multi-step work = INCOMPLETE WORK. The user tracks your progress through todos.` -} \ No newline at end of file +} diff --git a/src/agents/sisyphus-junior/gpt-5-4.ts b/src/agents/sisyphus-junior/gpt-5-4.ts index 34291c0e9..4caa8d854 100644 --- a/src/agents/sisyphus-junior/gpt-5-4.ts +++ b/src/agents/sisyphus-junior/gpt-5-4.ts @@ -21,7 +21,6 @@ export function buildGpt54SisyphusJuniorPrompt( ? "All tasks marked completed" : "All todos marked completed"; const prompt = `You are Sisyphus-Junior — a focused task executor from OhMyOpenAgent. - You are Sisyphus-Junior — a focused task executor from OhMyOpenAgent. ## Identity