feat(keyword-detector): handle ultrawork keyword after greeting patterns

- Add TRAILING_GREETING_ULTRAWORK_PATTERN to detect 'hi ultrawork' style inputs - Rename hasLeadingUltraworkKeyword to hasEdgeUltraworkKeyword for clarity - Add extractUltraworkTask guard to return empty string for greeting-only inputs - Add comprehensive test coverage for edge trigger scenarios Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-04-09 15:15:30 +09:00
parent 58be69114f
commit 69f47a9751
3 changed files with 143 additions and 4 deletions
@@ -0,0 +1,122 @@
+import { afterEach, beforeEach, describe, expect, test } from "bun:test"
+
+import { createKeywordDetectorHook } from "./index"
+import { _resetForTesting, setMainSession } from "../../features/claude-code-session-state"
+
+type StartLoopCall = {
+  sessionID: string
+  prompt: string
+  options: Record<string, unknown>
+}
+
+function createMockPluginInput(toastCalls: string[] = []) {
+  return {
+    client: {
+      tui: {
+        showToast: async (opts: { body: { title: string } }) => {
+          toastCalls.push(opts.body.title)
+        },
+      },
+    },
+  } as any
+}
+
+function createMockRalphLoop(startLoopCalls: StartLoopCall[]) {
+  return {
+    startLoop: (sessionID: string, prompt: string, options?: Record<string, unknown>): boolean => {
+      startLoopCalls.push({ sessionID, prompt, options: options ?? {} })
+      return true
+    },
+  }
+}
+
+describe("keyword-detector ultrawork edge trigger", () => {
+  beforeEach(() => {
+    _resetForTesting()
+    setMainSession("main-session")
+  })
+
+  afterEach(() => {
+    _resetForTesting()
+  })
+
+  test("#given greeting text before ulw and surrounding whitespace #when chat.message fires #then ultrawork still activates", async () => {
+    // given
+    const toastCalls: string[] = []
+    const startLoopCalls: StartLoopCall[] = []
+    const hook = createKeywordDetectorHook(
+      createMockPluginInput(toastCalls),
+      undefined,
+      createMockRalphLoop(startLoopCalls),
+    )
+    const output = {
+      message: {} as Record<string, unknown>,
+      parts: [{ type: "text", text: " hi there ulw " }],
+    }
+
+    // when
+    await hook["chat.message"]({ sessionID: "main-session", agent: "sisyphus" }, output)
+
+    // then
+    expect(toastCalls).toContain("Ultrawork Mode Activated")
+    expect(startLoopCalls).toHaveLength(1)
+    expect(startLoopCalls[0]).toEqual({
+      sessionID: "main-session",
+      prompt: "Complete the task as instructed",
+      options: {
+        ultrawork: true,
+        maxIterations: undefined,
+        completionPromise: undefined,
+        strategy: undefined,
+      },
+    })
+    expect(output.parts[0]?.text).toContain("ULTRAWORK MODE ENABLED!")
+    expect(output.parts[0]?.text).toContain(" hi there ulw ")
+  })
+
+  test("#given ulw mentioned in the middle of a sentence #when chat.message fires #then ultrawork stays disabled", async () => {
+    // given
+    const toastCalls: string[] = []
+    const startLoopCalls: StartLoopCall[] = []
+    const hook = createKeywordDetectorHook(
+      createMockPluginInput(toastCalls),
+      undefined,
+      createMockRalphLoop(startLoopCalls),
+    )
+    const output = {
+      message: {} as Record<string, unknown>,
+      parts: [{ type: "text", text: "I think ulw is cool" }],
+    }
+
+    // when
+    await hook["chat.message"]({ sessionID: "main-session", agent: "sisyphus" }, output)
+
+    // then
+    expect(toastCalls).not.toContain("Ultrawork Mode Activated")
+    expect(startLoopCalls).toHaveLength(0)
+    expect(output.parts[0]?.text).toBe("I think ulw is cool")
+  })
+
+  test("#given trailing ultrawork reference without punctuation #when chat.message fires #then ultrawork stays disabled", async () => {
+    // given
+    const toastCalls: string[] = []
+    const startLoopCalls: StartLoopCall[] = []
+    const hook = createKeywordDetectorHook(
+      createMockPluginInput(toastCalls),
+      undefined,
+      createMockRalphLoop(startLoopCalls),
+    )
+    const output = {
+      message: {} as Record<string, unknown>,
+      parts: [{ type: "text", text: "what is ultrawork" }],
+    }
+
+    // when
+    await hook["chat.message"]({ sessionID: "main-session", agent: "sisyphus" }, output)
+
+    // then
+    expect(toastCalls).not.toContain("Ultrawork Mode Activated")
+    expect(startLoopCalls).toHaveLength(0)
+    expect(output.parts[0]?.text).toBe("what is ultrawork")
+  })
+})