refactor(loaders): migrate to async-first pattern for commands and skills

- Remove all sync functions from command loader (async now default)
- Remove sync load functions from skill loader (async now default)
- Add resolveSymlinkAsync to file-utils.ts
- Update all callers to use async versions:
  - config-handler.ts
  - index.ts
  - tools/slashcommand/tools.ts
  - tools/skill/tools.ts
  - hooks/auto-slash-command/executor.ts
  - loader.test.ts
- All 607 tests pass, build succeeds

Generated with assistance of 🤖 [OhMyOpenCode](https://github.com/code-yeongyu/oh-my-opencode)

src/features/claude-code-command-loader/loader.ts

@@ -1,6 +1,6 @@
-import { existsSync, readdirSync, readFileSync, realpathSync, type Dirent } from "fs"
-import { promises as fsPromises } from "fs"
+import { promises as fs, type Dirent } from "fs"
 import { join, basename } from "path"
+import { homedir } from "os"
 import { parseFrontmatter } from "../../shared/frontmatter"
 import { sanitizeModelField } from "../../shared/model-sanitizer"
 import { isMarkdownFile } from "../../shared/file-utils"
@@ -8,19 +8,21 @@ import { getClaudeConfigDir } from "../../shared"
 import { log } from "../../shared/logger"
 import type { CommandScope, CommandDefinition, CommandFrontmatter, LoadedCommand } from "./types"
 
-function loadCommandsFromDir(
+async function loadCommandsFromDir(
   commandsDir: string,
   scope: CommandScope,
   visited: Set<string> = new Set(),
   prefix: string = ""
-): LoadedCommand[] {
-  if (!existsSync(commandsDir)) {
+): Promise<LoadedCommand[]> {
+  try {
+    await fs.access(commandsDir)
+  } catch {
     return []
   }
 
   let realPath: string
   try {
-    realPath = realpathSync(commandsDir)
+    realPath = await fs.realpath(commandsDir)
   } catch (error) {
     log(`Failed to resolve command directory: ${commandsDir}`, error)
     return []
@@ -33,7 +35,7 @@ function loadCommandsFromDir(
 
   let entries: Dirent[]
   try {
-    entries = readdirSync(commandsDir, { withFileTypes: true })
+    entries = await fs.readdir(commandsDir, { withFileTypes: true })
   } catch (error) {
     log(`Failed to read command directory: ${commandsDir}`, error)
     return []
@@ -46,7 +48,8 @@ function loadCommandsFromDir(
       if (entry.name.startsWith(".")) continue
       const subDirPath = join(commandsDir, entry.name)
       const subPrefix = prefix ? `${prefix}:${entry.name}` : entry.name
-      commands.push(...loadCommandsFromDir(subDirPath, scope, visited, subPrefix))
+      const subCommands = await loadCommandsFromDir(subDirPath, scope, visited, subPrefix)
+      commands.push(...subCommands)
       continue
     }
 
@@ -57,7 +60,7 @@ function loadCommandsFromDir(
     const commandName = prefix ? `${prefix}:${baseCommandName}` : baseCommandName
 
     try {
-      const content = readFileSync(commandPath, "utf-8")
+      const content = await fs.readFile(commandPath, "utf-8")
       const { data, body } = parseFrontmatter<CommandFrontmatter>(content)
 
       const wrappedTemplate = `<command-instruction>
@@ -106,154 +109,36 @@ function commandsToRecord(commands: LoadedCommand[]): Record<string, CommandDefi
   return result
 }
 
-export function loadUserCommands(): Record<string, CommandDefinition> {
+export async function loadUserCommands(): Promise<Record<string, CommandDefinition>> {
   const userCommandsDir = join(getClaudeConfigDir(), "commands")
-  const commands = loadCommandsFromDir(userCommandsDir, "user")
+  const commands = await loadCommandsFromDir(userCommandsDir, "user")
   return commandsToRecord(commands)
 }
 
-export function loadProjectCommands(): Record<string, CommandDefinition> {
+export async function loadProjectCommands(): Promise<Record<string, CommandDefinition>> {
   const projectCommandsDir = join(process.cwd(), ".claude", "commands")
-  const commands = loadCommandsFromDir(projectCommandsDir, "project")
+  const commands = await loadCommandsFromDir(projectCommandsDir, "project")
   return commandsToRecord(commands)
 }
 
-export function loadOpencodeGlobalCommands(): Record<string, CommandDefinition> {
-  const { homedir } = require("os")
+export async function loadOpencodeGlobalCommands(): Promise<Record<string, CommandDefinition>> {
   const opencodeCommandsDir = join(homedir(), ".config", "opencode", "command")
-  const commands = loadCommandsFromDir(opencodeCommandsDir, "opencode")
+  const commands = await loadCommandsFromDir(opencodeCommandsDir, "opencode")
   return commandsToRecord(commands)
 }
 
-export function loadOpencodeProjectCommands(): Record<string, CommandDefinition> {
+export async function loadOpencodeProjectCommands(): Promise<Record<string, CommandDefinition>> {
   const opencodeProjectDir = join(process.cwd(), ".opencode", "command")
-  const commands = loadCommandsFromDir(opencodeProjectDir, "opencode-project")
+  const commands = await loadCommandsFromDir(opencodeProjectDir, "opencode-project")
   return commandsToRecord(commands)
 }
 
-async function loadCommandsFromDirAsync(
-  commandsDir: string,
-  scope: CommandScope,
-  visited: Set<string> = new Set(),
-  prefix: string = ""
-): Promise<LoadedCommand[]> {
-  try {
-    await fsPromises.access(commandsDir)
-  } catch {
-    return []
-  }
-
-  let realPath: string
-  try {
-    realPath = await fsPromises.realpath(commandsDir)
-  } catch (error) {
-    log(`Failed to resolve command directory: ${commandsDir}`, error)
-    return []
-  }
-
-  if (visited.has(realPath)) {
-    return []
-  }
-  visited.add(realPath)
-
-  let entries: Dirent[]
-  try {
-    entries = await fsPromises.readdir(commandsDir, { withFileTypes: true })
-  } catch (error) {
-    log(`Failed to read command directory: ${commandsDir}`, error)
-    return []
-  }
-
-  const commands: LoadedCommand[] = []
-
-  for (const entry of entries) {
-    if (entry.isDirectory()) {
-      if (entry.name.startsWith(".")) continue
-      const subDirPath = join(commandsDir, entry.name)
-      const subPrefix = prefix ? `${prefix}:${entry.name}` : entry.name
-      const subCommands = await loadCommandsFromDirAsync(subDirPath, scope, visited, subPrefix)
-      commands.push(...subCommands)
-      continue
-    }
-
-    if (!isMarkdownFile(entry)) continue
-
-    const commandPath = join(commandsDir, entry.name)
-    const baseCommandName = basename(entry.name, ".md")
-    const commandName = prefix ? `${prefix}:${baseCommandName}` : baseCommandName
-
-    try {
-      const content = await fsPromises.readFile(commandPath, "utf-8")
-      const { data, body } = parseFrontmatter<CommandFrontmatter>(content)
-
-      const wrappedTemplate = `<command-instruction>
- ${body.trim()}
- </command-instruction>
-
- <user-request>
- $ARGUMENTS
- </user-request>`
-
-      const formattedDescription = `(${scope}) ${data.description || ""}`
-
-      const isOpencodeSource = scope === "opencode" || scope === "opencode-project"
-      const definition: CommandDefinition = {
-        name: commandName,
-        description: formattedDescription,
-        template: wrappedTemplate,
-        agent: data.agent,
-        model: sanitizeModelField(data.model, isOpencodeSource ? "opencode" : "claude-code"),
-        subtask: data.subtask,
-        argumentHint: data["argument-hint"],
-        handoffs: data.handoffs,
-      }
-
-      commands.push({
-        name: commandName,
-        path: commandPath,
-        definition,
-        scope,
-      })
-    } catch (error) {
-      log(`Failed to parse command: ${commandPath}`, error)
-      continue
-    }
-  }
-
-  return commands
-}
-
-export async function loadUserCommandsAsync(): Promise<Record<string, CommandDefinition>> {
-  const userCommandsDir = join(getClaudeConfigDir(), "commands")
-  const commands = await loadCommandsFromDirAsync(userCommandsDir, "user")
-  return commandsToRecord(commands)
-}
-
-export async function loadProjectCommandsAsync(): Promise<Record<string, CommandDefinition>> {
-  const projectCommandsDir = join(process.cwd(), ".claude", "commands")
-  const commands = await loadCommandsFromDirAsync(projectCommandsDir, "project")
-  return commandsToRecord(commands)
-}
-
-export async function loadOpencodeGlobalCommandsAsync(): Promise<Record<string, CommandDefinition>> {
-  const { homedir } = require("os")
-  const opencodeCommandsDir = join(homedir(), ".config", "opencode", "command")
-  const commands = await loadCommandsFromDirAsync(opencodeCommandsDir, "opencode")
-  return commandsToRecord(commands)
-}
-
-export async function loadOpencodeProjectCommandsAsync(): Promise<Record<string, CommandDefinition>> {
-  const opencodeProjectDir = join(process.cwd(), ".opencode", "command")
-  const commands = await loadCommandsFromDirAsync(opencodeProjectDir, "opencode-project")
-  return commandsToRecord(commands)
-}
-
-export async function loadAllCommandsAsync(): Promise<Record<string, CommandDefinition>> {
+export async function loadAllCommands(): Promise<Record<string, CommandDefinition>> {
   const [user, project, global, projectOpencode] = await Promise.all([
-    loadUserCommandsAsync(),
-    loadProjectCommandsAsync(),
-    loadOpencodeGlobalCommandsAsync(),
-    loadOpencodeProjectCommandsAsync(),
+    loadUserCommands(),
+    loadProjectCommands(),
+    loadOpencodeGlobalCommands(),
+    loadOpencodeProjectCommands(),
   ])
   return { ...projectOpencode, ...global, ...project, ...user }
 }