From 7e96af5f2813956ae038a0ade4993b2813c3eb01 Mon Sep 17 00:00:00 2001 From: YeonGyu-Kim Date: Sun, 12 Apr 2026 02:29:08 +0900 Subject: [PATCH] fix(atlas): exclude node_modules from verification git diff --stat (#3215) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Atlas verification reminders instructed 'git diff --stat' which included node_modules noise in the output. Added pathspec exclude to both VERIFICATION_REMINDER and VERIFICATION_REMINDER_GEMINI templates. 🤖 Generated with OhMyOpenCode assistance https://github.com/code-yeongyu/oh-my-opencode --- .../atlas/system-reminder-templates.test.ts | 18 +++++++++++++++++- src/hooks/atlas/system-reminder-templates.ts | 4 ++-- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/src/hooks/atlas/system-reminder-templates.test.ts b/src/hooks/atlas/system-reminder-templates.test.ts index a1a91a443..fe43719c5 100644 --- a/src/hooks/atlas/system-reminder-templates.test.ts +++ b/src/hooks/atlas/system-reminder-templates.test.ts @@ -1,5 +1,9 @@ import { describe, it, expect } from "bun:test" -import { BOULDER_CONTINUATION_PROMPT } from "./system-reminder-templates" +import { + BOULDER_CONTINUATION_PROMPT, + VERIFICATION_REMINDER, + VERIFICATION_REMINDER_GEMINI, +} from "./system-reminder-templates" describe("BOULDER_CONTINUATION_PROMPT", () => { describe("checkbox-first priority rules", () => { @@ -35,3 +39,15 @@ describe("BOULDER_CONTINUATION_PROMPT", () => { }) }) }) + +describe("VERIFICATION_REMINDER", () => { + it("contains node_modules exclusion pathspec in git diff command", () => { + expect(VERIFICATION_REMINDER).toContain(":!node_modules") + }) +}) + +describe("VERIFICATION_REMINDER_GEMINI", () => { + it("contains node_modules exclusion pathspec in git diff command", () => { + expect(VERIFICATION_REMINDER_GEMINI).toContain(":!node_modules") + }) +}) diff --git a/src/hooks/atlas/system-reminder-templates.ts b/src/hooks/atlas/system-reminder-templates.ts index c385cf518..ee7db3bb5 100644 --- a/src/hooks/atlas/system-reminder-templates.ts +++ b/src/hooks/atlas/system-reminder-templates.ts @@ -51,7 +51,7 @@ Assume the work is broken until YOU prove otherwise. Do NOT run tests yet. Read the code FIRST so you know what you're testing. -1. \`Bash("git diff --stat")\` - see exactly which files changed. Any file outside expected scope = scope creep. +1. \`Bash("git diff --stat -- ':!node_modules'")\` - see exactly which files changed. Any file outside expected scope = scope creep. 2. \`Read\` EVERY changed file - no exceptions, no skimming. 3. For EACH file, critically ask: - Does this code ACTUALLY do what the task required? (Re-read the task, compare line by line) @@ -125,7 +125,7 @@ Thinking "it looks correct" is NOT verification. Running \`lsp_diagnostics\` IS. Read the code FIRST so you know what you're testing. -1. \`Bash("git diff --stat")\` - see exactly which files changed. +1. \`Bash("git diff --stat -- ':!node_modules'")\` - see exactly which files changed. 2. \`Read\` EVERY changed file - no exceptions, no skimming. 3. For EACH file: - Does this code ACTUALLY do what the task required? RE-READ the task spec.