Add background task notification template coverage
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This commit is contained in:
@@ -0,0 +1,130 @@
|
|||||||
|
import { describe, expect, test } from "bun:test"
|
||||||
|
import { buildBackgroundTaskNotificationText } from "./background-task-notification-template"
|
||||||
|
|
||||||
|
describe("buildBackgroundTaskNotificationText", () => {
|
||||||
|
describe("#given one task still running after a completed task notification", () => {
|
||||||
|
test("#when building the partial notification #then it preserves the existing completed-task format", () => {
|
||||||
|
// given
|
||||||
|
const notification = buildBackgroundTaskNotificationText({
|
||||||
|
task: {
|
||||||
|
id: "task-1",
|
||||||
|
description: "Index repo",
|
||||||
|
status: "completed",
|
||||||
|
},
|
||||||
|
duration: "42s",
|
||||||
|
statusText: "COMPLETED",
|
||||||
|
allComplete: false,
|
||||||
|
remainingCount: 1,
|
||||||
|
completedTasks: [],
|
||||||
|
})
|
||||||
|
|
||||||
|
// when
|
||||||
|
const expectedNotification = `<system-reminder>
|
||||||
|
[BACKGROUND TASK COMPLETED]
|
||||||
|
**ID:** \`task-1\`
|
||||||
|
**Description:** Index repo
|
||||||
|
**Duration:** 42s
|
||||||
|
|
||||||
|
**1 task still in progress.** You WILL be notified when ALL complete.
|
||||||
|
Do NOT poll - continue productive work.
|
||||||
|
|
||||||
|
Use \`background_output(task_id="task-1")\` to retrieve this result when ready.
|
||||||
|
</system-reminder>`
|
||||||
|
|
||||||
|
// then
|
||||||
|
expect(notification).toBe(expectedNotification)
|
||||||
|
})
|
||||||
|
})
|
||||||
|
|
||||||
|
describe("#given one task still running after a failed task notification", () => {
|
||||||
|
test("#when building the partial notification #then it preserves the existing failure format", () => {
|
||||||
|
// given
|
||||||
|
const notification = buildBackgroundTaskNotificationText({
|
||||||
|
task: {
|
||||||
|
id: "task-2",
|
||||||
|
description: "Summarize logs",
|
||||||
|
status: "error",
|
||||||
|
error: "Timed out",
|
||||||
|
},
|
||||||
|
duration: "3m 4s",
|
||||||
|
statusText: "ERROR",
|
||||||
|
allComplete: false,
|
||||||
|
remainingCount: 2,
|
||||||
|
completedTasks: [],
|
||||||
|
})
|
||||||
|
|
||||||
|
// when
|
||||||
|
const expectedNotification = `<system-reminder>
|
||||||
|
[BACKGROUND TASK ERROR]
|
||||||
|
**ID:** \`task-2\`
|
||||||
|
**Description:** Summarize logs
|
||||||
|
**Duration:** 3m 4s
|
||||||
|
**Error:** Timed out
|
||||||
|
|
||||||
|
**2 tasks still in progress.** You WILL be notified when ALL complete.
|
||||||
|
**ACTION REQUIRED:** This task failed. Check the error and decide whether to retry, cancel remaining tasks, or continue.
|
||||||
|
|
||||||
|
Use \`background_output(task_id="task-2")\` to retrieve this result when ready.
|
||||||
|
</system-reminder>`
|
||||||
|
|
||||||
|
// then
|
||||||
|
expect(notification).toBe(expectedNotification)
|
||||||
|
})
|
||||||
|
})
|
||||||
|
|
||||||
|
describe("#given all sibling tasks completed with mixed outcomes", () => {
|
||||||
|
test("#when building the final notification #then it preserves the existing summary format", () => {
|
||||||
|
// given
|
||||||
|
const notification = buildBackgroundTaskNotificationText({
|
||||||
|
task: {
|
||||||
|
id: "task-3",
|
||||||
|
description: "Fallback task",
|
||||||
|
status: "error",
|
||||||
|
error: "Denied",
|
||||||
|
},
|
||||||
|
duration: "10s",
|
||||||
|
statusText: "ERROR",
|
||||||
|
allComplete: true,
|
||||||
|
remainingCount: 0,
|
||||||
|
completedTasks: [
|
||||||
|
{
|
||||||
|
id: "task-1",
|
||||||
|
description: "Index repo",
|
||||||
|
status: "completed",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
id: "task-2",
|
||||||
|
description: "Summarize logs",
|
||||||
|
status: "cancelled",
|
||||||
|
error: "User aborted",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
id: "task-3",
|
||||||
|
description: "Fallback task",
|
||||||
|
status: "error",
|
||||||
|
error: "Denied",
|
||||||
|
},
|
||||||
|
],
|
||||||
|
})
|
||||||
|
|
||||||
|
// when
|
||||||
|
const expectedNotification = `<system-reminder>
|
||||||
|
[ALL BACKGROUND TASKS FINISHED - 2 FAILED]
|
||||||
|
|
||||||
|
**Completed:**
|
||||||
|
- \`task-1\`: Index repo
|
||||||
|
|
||||||
|
**Failed:**
|
||||||
|
- \`task-2\`: Summarize logs [CANCELLED] - User aborted
|
||||||
|
- \`task-3\`: Fallback task [ERROR] - Denied
|
||||||
|
|
||||||
|
Use \`background_output(task_id="<id>")\` to retrieve each result.
|
||||||
|
|
||||||
|
**ACTION REQUIRED:** 2 task(s) failed. Check errors above and decide whether to retry or proceed.
|
||||||
|
</system-reminder>`
|
||||||
|
|
||||||
|
// then
|
||||||
|
expect(notification).toBe(expectedNotification)
|
||||||
|
})
|
||||||
|
})
|
||||||
|
})
|
||||||
@@ -1,14 +1,21 @@
|
|||||||
import type { BackgroundTask } from "./types"
|
import type { BackgroundTaskStatus } from "./types"
|
||||||
|
|
||||||
export type BackgroundTaskNotificationStatus = "COMPLETED" | "CANCELLED" | "INTERRUPTED" | "ERROR"
|
export type BackgroundTaskNotificationStatus = "COMPLETED" | "CANCELLED" | "INTERRUPTED" | "ERROR"
|
||||||
|
|
||||||
|
export interface BackgroundTaskNotificationTask {
|
||||||
|
id: string
|
||||||
|
description: string
|
||||||
|
status: BackgroundTaskStatus
|
||||||
|
error?: string
|
||||||
|
}
|
||||||
|
|
||||||
export function buildBackgroundTaskNotificationText(input: {
|
export function buildBackgroundTaskNotificationText(input: {
|
||||||
task: BackgroundTask
|
task: BackgroundTaskNotificationTask
|
||||||
duration: string
|
duration: string
|
||||||
statusText: BackgroundTaskNotificationStatus
|
statusText: BackgroundTaskNotificationStatus
|
||||||
allComplete: boolean
|
allComplete: boolean
|
||||||
remainingCount: number
|
remainingCount: number
|
||||||
completedTasks: BackgroundTask[]
|
completedTasks: BackgroundTaskNotificationTask[]
|
||||||
}): string {
|
}): string {
|
||||||
const { task, duration, statusText, allComplete, remainingCount, completedTasks } = input
|
const { task, duration, statusText, allComplete, remainingCount, completedTasks } = input
|
||||||
|
|
||||||
@@ -50,14 +57,12 @@ Use \`background_output(task_id="<id>")\` to retrieve each result.${hasFailures
|
|||||||
</system-reminder>`
|
</system-reminder>`
|
||||||
}
|
}
|
||||||
|
|
||||||
const agentInfo = task.category ? `${task.agent} (${task.category})` : task.agent
|
|
||||||
const isFailure = statusText !== "COMPLETED"
|
const isFailure = statusText !== "COMPLETED"
|
||||||
|
|
||||||
return `<system-reminder>
|
return `<system-reminder>
|
||||||
[BACKGROUND TASK ${statusText}]
|
[BACKGROUND TASK ${statusText}]
|
||||||
**ID:** \`${task.id}\`
|
**ID:** \`${task.id}\`
|
||||||
**Description:** ${task.description}
|
**Description:** ${task.description}
|
||||||
**Agent:** ${agentInfo}
|
|
||||||
**Duration:** ${duration}${errorInfo}
|
**Duration:** ${duration}${errorInfo}
|
||||||
|
|
||||||
**${remainingCount} task${remainingCount === 1 ? "" : "s"} still in progress.** You WILL be notified when ALL complete.
|
**${remainingCount} task${remainingCount === 1 ? "" : "s"} still in progress.** You WILL be notified when ALL complete.
|
||||||
|
|||||||
Reference in New Issue
Block a user