fix: address Cubic round 5 issues — prototype-pollution guard, URL-encode, JSONC preservation, config-context warning, dynamic config path

This commit is contained in:
YeonGyu-Kim
2026-02-08 22:35:16 +09:00
parent be03e27faf
commit 8a2c3cc98d
5 changed files with 24 additions and 4 deletions
+18 -2
View File
@@ -1,4 +1,4 @@
import { writeFileSync } from "node:fs"
import { readFileSync, writeFileSync } from "node:fs"
import type { ConfigMergeResult, InstallConfig } from "../types"
import { getConfigDir } from "./config-context"
import { ensureConfigDirectoryExists } from "./ensure-config-directory-exists"
@@ -45,7 +45,23 @@ export function addProviderConfig(config: InstallConfig): ConfigMergeResult {
newConfig.provider = providers
}
writeFileSync(path, JSON.stringify(newConfig, null, 2) + "\n")
if (format === "jsonc") {
const content = readFileSync(path, "utf-8")
const providerRegex = /"provider"\s*:\s*\{[\s\S]*?\n \}/
const providerJson = JSON.stringify(newConfig.provider, null, 2)
.split("\n")
.map((line, i) => (i === 0 ? line : ` ${line}`))
.join("\n")
if (providerRegex.test(content)) {
const newContent = content.replace(providerRegex, `"provider": ${providerJson}`)
writeFileSync(path, newContent)
} else {
const newContent = content.replace(/(\{)/, `$1\n "provider": ${providerJson},`)
writeFileSync(path, newContent)
}
} else {
writeFileSync(path, JSON.stringify(newConfig, null, 2) + "\n")
}
return { success: true, configPath: path }
} catch (err) {
return {