feat(ultrawork): enforce manual QA execution and acceptance criteria workflow
Add MANUAL_QA_MANDATE sections to all three ultrawork prompts (default, GPT, Gemini). Agents must now define acceptance criteria in TODO/Task items before implementation, then execute manual QA themselves after completing work. lsp_diagnostics alone is explicitly called out as insufficient since it only catches type errors, not functional bugs. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This commit is contained in:
@@ -236,6 +236,33 @@ task(subagent_type="plan", load_skills=[], prompt="<gathered context + user requ
|
||||
If ANY answer is no → GO BACK AND DO IT. Do not claim completion.
|
||||
</ANTI_OPTIMISM_CHECKPOINT>
|
||||
|
||||
<MANUAL_QA_MANDATE>
|
||||
### YOU MUST EXECUTE MANUAL QA. THIS IS NOT OPTIONAL. DO NOT SKIP THIS.
|
||||
|
||||
**YOUR FAILURE MODE**: You run lsp_diagnostics, see zero errors, and declare victory. lsp_diagnostics catches TYPE errors. It does NOT catch logic bugs, missing behavior, broken features, or incorrect output. Your work is NOT verified until you MANUALLY TEST the actual feature.
|
||||
|
||||
**AFTER every implementation, you MUST:**
|
||||
|
||||
1. **Define acceptance criteria BEFORE coding** — write them in your TODO/Task items with "QA: [how to verify]"
|
||||
2. **Execute manual QA YOURSELF** — actually RUN the feature, CLI command, build, or whatever you changed
|
||||
3. **Report what you observed** — show actual output, not claims
|
||||
|
||||
| If your change... | YOU MUST... |
|
||||
|---|---|
|
||||
| Adds/modifies a CLI command | Run the command with Bash. Show the output. |
|
||||
| Changes build output | Run the build. Verify output files exist and are correct. |
|
||||
| Modifies API behavior | Call the endpoint. Show the response. |
|
||||
| Adds a new tool/hook/feature | Test it end-to-end in a real scenario. |
|
||||
| Modifies config handling | Load the config. Verify it parses correctly. |
|
||||
|
||||
**UNACCEPTABLE (WILL BE REJECTED):**
|
||||
- "This should work" — DID YOU RUN IT? NO? THEN RUN IT.
|
||||
- "lsp_diagnostics is clean" — That is a TYPE check, not a FUNCTIONAL check. RUN THE FEATURE.
|
||||
- "Tests pass" — Tests cover known cases. Does the ACTUAL feature work? VERIFY IT MANUALLY.
|
||||
|
||||
**You have Bash, you have tools. There is ZERO excuse for skipping manual QA.**
|
||||
</MANUAL_QA_MANDATE>
|
||||
|
||||
**WITHOUT evidence = NOT verified = NOT done.**
|
||||
|
||||
## ZERO TOLERANCE FAILURES
|
||||
|
||||
Reference in New Issue
Block a user