fix(atlas): enforce checkbox completion before next task
🤖 GENERATED WITH ASSISTANCE OF [OhMyOpenCode](https://github.com/code-yeongyu/oh-my-opencode)
This commit is contained in:
@@ -213,7 +213,7 @@ After EVERY delegation, complete ALL of these steps — no shortcuts:
|
||||
|
||||
After verification, READ the plan file directly — every time, no exceptions:
|
||||
\`\`\`
|
||||
Read(".sisyphus/tasks/{plan-name}.yaml")
|
||||
Read(".sisyphus/plans/{plan-name}.md")
|
||||
\`\`\`
|
||||
Count remaining \`- [ ]\` tasks. This is your ground truth for what comes next.
|
||||
|
||||
@@ -335,7 +335,7 @@ task(category="quick", load_skills=[], run_in_background=false, prompt="Task 4..
|
||||
\`\`\`
|
||||
|
||||
**Path convention**:
|
||||
- Plan: \`.sisyphus/plans/{name}.md\` (READ ONLY)
|
||||
- Plan: \`.sisyphus/plans/{name}.md\` (you may EDIT to mark checkboxes)
|
||||
- Notepad: \`.sisyphus/notepads/{name}/\` (READ/APPEND)
|
||||
</notepad_protocol>
|
||||
|
||||
@@ -372,6 +372,7 @@ You are the QA gate. Subagents lie. Verify EVERYTHING.
|
||||
- Use lsp_diagnostics, grep, glob
|
||||
- Manage todos
|
||||
- Coordinate and verify
|
||||
- **EDIT \`.sisyphus\/plans\/*.md\` to change \`- [ ]\` to \`- [x]\` after verified task completion**
|
||||
|
||||
**YOU DELEGATE**:
|
||||
- All code writing/editing
|
||||
@@ -403,6 +404,20 @@ You are the QA gate. Subagents lie. Verify EVERYTHING.
|
||||
- **Store session_id from every delegation output**
|
||||
- **Use \`session_id="{session_id}"\` for retries, fixes, and follow-ups**
|
||||
</critical_overrides>
|
||||
|
||||
<post_delegation_rule>
|
||||
## POST-DELEGATION RULE (MANDATORY)
|
||||
|
||||
After EVERY verified task() completion, you MUST:
|
||||
|
||||
1. **EDIT the plan checkbox**: Change \`- [ ]\` to \`- [x]\` for the completed task in \`.sisyphus/plans/{plan-name}.md\`
|
||||
|
||||
2. **READ the plan to confirm**: Read \`.sisyphus/plans/{plan-name}.md\` and verify the checkbox count changed (fewer \`- [ ]\` remaining)
|
||||
|
||||
3. **MUST NOT call a new task()** before completing steps 1 and 2 above
|
||||
|
||||
This ensures accurate progress tracking. Skip this and you lose visibility into what remains.
|
||||
</post_delegation_rule>
|
||||
`
|
||||
|
||||
export function getDefaultAtlasPrompt(): string {
|
||||
|
||||
@@ -309,7 +309,7 @@ task(category="quick", load_skills=[], run_in_background=false, prompt="Task 3..
|
||||
- Instruct subagent to append findings (never overwrite)
|
||||
|
||||
**Paths**:
|
||||
- Plan: \`.sisyphus/plans/{name}.md\` (READ ONLY)
|
||||
- Plan: \`.sisyphus\/plans\/{name}.md\` (you may EDIT to mark checkboxes)
|
||||
- Notepad: \`.sisyphus/notepads/{name}/\` (READ/APPEND)
|
||||
</notepad_protocol>
|
||||
|
||||
@@ -343,6 +343,7 @@ Subagents CLAIM "done" when:
|
||||
- Use lsp_diagnostics, grep, glob
|
||||
- Manage todos
|
||||
- Coordinate and verify
|
||||
- **EDIT \`.sisyphus\/plans\/*.md\` to change \`- [ ]\` to \`- [x]\` after verified task completion**
|
||||
|
||||
**YOU DELEGATE (NO EXCEPTIONS):**
|
||||
- All code writing/editing
|
||||
@@ -373,6 +374,20 @@ Subagents CLAIM "done" when:
|
||||
- Store and reuse session_id for retries
|
||||
- **USE TOOL CALLS for verification — not internal reasoning**
|
||||
</critical_rules>
|
||||
|
||||
<post_delegation_rule>
|
||||
## POST-DELEGATION RULE (MANDATORY)
|
||||
|
||||
After EVERY verified task() completion, you MUST:
|
||||
|
||||
1. **EDIT the plan checkbox**: Change \`- [ ]\` to \`- [x]\` for the completed task in \`.sisyphus/plans/{plan-name}.md\`
|
||||
|
||||
2. **READ the plan to confirm**: Read \`.sisyphus/plans/{plan-name}.md\` and verify the checkbox count changed (fewer \`- [ ]\` remaining)
|
||||
|
||||
3. **MUST NOT call a new task()** before completing steps 1 and 2 above
|
||||
|
||||
This ensures accurate progress tracking. Skip this and you lose visibility into what remains.
|
||||
</post_delegation_rule>
|
||||
`
|
||||
|
||||
export function getGeminiAtlasPrompt(): string {
|
||||
|
||||
+15
-10
@@ -313,7 +313,7 @@ task(category="quick", load_skills=[], run_in_background=false, prompt="Task 3..
|
||||
- Instruct subagent to append findings (never overwrite)
|
||||
|
||||
**Paths**:
|
||||
- Plan: \`.sisyphus/plans/{name}.md\` (READ ONLY)
|
||||
- Plan: \`.sisyphus/plans/{name}.md\` (you may EDIT to mark checkboxes)
|
||||
- Notepad: \`.sisyphus/notepads/{name}/\` (READ/APPEND)
|
||||
</notepad_protocol>
|
||||
|
||||
@@ -348,6 +348,7 @@ Your job is to CATCH THEM. Assume every claim is false until YOU personally veri
|
||||
- Use lsp_diagnostics, grep, glob
|
||||
- Manage todos
|
||||
- Coordinate and verify
|
||||
- **EDIT \`.sisyphus\/plans\/*.md\` to change \`- [ ]\` to \`- [x]\` after verified task completion**
|
||||
|
||||
**YOU DELEGATE**:
|
||||
- All code writing/editing
|
||||
@@ -376,15 +377,19 @@ Your job is to CATCH THEM. Assume every claim is false until YOU personally veri
|
||||
- Store and reuse session_id for retries
|
||||
</critical_rules>
|
||||
|
||||
<user_updates_spec>
|
||||
- Send brief updates (1-2 sentences) only when:
|
||||
- Starting a new major phase
|
||||
- Discovering something that changes the plan
|
||||
- Avoid narrating routine tool calls
|
||||
- Each update must include a concrete outcome ("Found X", "Verified Y", "Delegated Z")
|
||||
- Keep updates varied in structure — don't start each the same way
|
||||
- Do NOT expand task scope; if you notice new work, call it out as optional
|
||||
</user_updates_spec>
|
||||
<post_delegation_rule>
|
||||
## POST-DELEGATION RULE (MANDATORY)
|
||||
|
||||
After EVERY verified task() completion, you MUST:
|
||||
|
||||
1. **EDIT the plan checkbox**: Change \`- [ ]\` to \`- [x]\` for the completed task in \`.sisyphus/plans/{plan-name}.md\`
|
||||
|
||||
2. **READ the plan to confirm**: Read \`.sisyphus/plans/{plan-name}.md\` and verify the checkbox count changed (fewer \`- [ ]\` remaining)
|
||||
|
||||
3. **MUST NOT call a new task()** before completing steps 1 and 2 above
|
||||
|
||||
This ensures accurate progress tracking. Skip this and you lose visibility into what remains.
|
||||
</post_delegation_rule>
|
||||
`;
|
||||
|
||||
export function getGptAtlasPrompt(): string {
|
||||
|
||||
@@ -0,0 +1,155 @@
|
||||
import { describe, test, expect } from "bun:test"
|
||||
import { ATLAS_SYSTEM_PROMPT } from "./default"
|
||||
import { ATLAS_GPT_SYSTEM_PROMPT } from "./gpt"
|
||||
import { ATLAS_GEMINI_SYSTEM_PROMPT } from "./gemini"
|
||||
|
||||
describe("ATLAS prompt checkbox enforcement", () => {
|
||||
describe("default prompt", () => {
|
||||
test("plan should NOT be marked (READ ONLY)", () => {
|
||||
// given
|
||||
const prompt = ATLAS_SYSTEM_PROMPT
|
||||
|
||||
// when / then
|
||||
expect(prompt).not.toMatch(/\(READ ONLY\)/)
|
||||
})
|
||||
|
||||
test("plan description should include EDIT for checkboxes", () => {
|
||||
// given
|
||||
const prompt = ATLAS_SYSTEM_PROMPT
|
||||
const lowerPrompt = prompt.toLowerCase()
|
||||
|
||||
// when / then
|
||||
expect(lowerPrompt).toMatch(/edit.*checkbox|checkbox.*edit/)
|
||||
})
|
||||
|
||||
test("boundaries should include exception for editing .sisyphus/plans/*.md checkboxes", () => {
|
||||
// given
|
||||
const prompt = ATLAS_SYSTEM_PROMPT
|
||||
const lowerPrompt = prompt.toLowerCase()
|
||||
|
||||
// when / then
|
||||
expect(lowerPrompt).toMatch(/\.sisyphus\/plans\/\*\.md/)
|
||||
expect(lowerPrompt).toMatch(/checkbox/)
|
||||
})
|
||||
|
||||
test("prompt should include POST-DELEGATION RULE", () => {
|
||||
// given
|
||||
const prompt = ATLAS_SYSTEM_PROMPT
|
||||
const lowerPrompt = prompt.toLowerCase()
|
||||
|
||||
// when / then
|
||||
expect(lowerPrompt).toMatch(/post-delegation/)
|
||||
})
|
||||
|
||||
test("prompt should include MUST NOT call a new task() before", () => {
|
||||
// given
|
||||
const prompt = ATLAS_SYSTEM_PROMPT
|
||||
const lowerPrompt = prompt.toLowerCase()
|
||||
|
||||
// when / then
|
||||
expect(lowerPrompt).toMatch(/must not.*call.*new.*task/)
|
||||
})
|
||||
|
||||
test("default prompt should NOT reference .sisyphus/tasks/", () => {
|
||||
// given
|
||||
const prompt = ATLAS_SYSTEM_PROMPT
|
||||
|
||||
// when / then
|
||||
expect(prompt).not.toMatch(/\.sisyphus\/tasks\//)
|
||||
})
|
||||
})
|
||||
|
||||
describe("GPT prompt", () => {
|
||||
test("plan should NOT be marked (READ ONLY)", () => {
|
||||
// given
|
||||
const prompt = ATLAS_GPT_SYSTEM_PROMPT
|
||||
|
||||
// when / then
|
||||
expect(prompt).not.toMatch(/\(READ ONLY\)/)
|
||||
})
|
||||
|
||||
test("plan description should include EDIT for checkboxes", () => {
|
||||
// given
|
||||
const prompt = ATLAS_GPT_SYSTEM_PROMPT
|
||||
const lowerPrompt = prompt.toLowerCase()
|
||||
|
||||
// when / then
|
||||
expect(lowerPrompt).toMatch(/edit.*checkbox|checkbox.*edit/)
|
||||
})
|
||||
|
||||
test("boundaries should include exception for editing .sisyphus/plans/*.md checkboxes", () => {
|
||||
// given
|
||||
const prompt = ATLAS_GPT_SYSTEM_PROMPT
|
||||
const lowerPrompt = prompt.toLowerCase()
|
||||
|
||||
// when / then
|
||||
expect(lowerPrompt).toMatch(/\.sisyphus\/plans\/\*\.md/)
|
||||
expect(lowerPrompt).toMatch(/checkbox/)
|
||||
})
|
||||
|
||||
test("prompt should include POST-DELEGATION RULE", () => {
|
||||
// given
|
||||
const prompt = ATLAS_GPT_SYSTEM_PROMPT
|
||||
const lowerPrompt = prompt.toLowerCase()
|
||||
|
||||
// when / then
|
||||
expect(lowerPrompt).toMatch(/post-delegation/)
|
||||
})
|
||||
|
||||
test("prompt should include MUST NOT call a new task() before", () => {
|
||||
// given
|
||||
const prompt = ATLAS_GPT_SYSTEM_PROMPT
|
||||
const lowerPrompt = prompt.toLowerCase()
|
||||
|
||||
// when / then
|
||||
expect(lowerPrompt).toMatch(/must not.*call.*new.*task/)
|
||||
})
|
||||
})
|
||||
|
||||
describe("Gemini prompt", () => {
|
||||
test("plan should NOT be marked (READ ONLY)", () => {
|
||||
// given
|
||||
const prompt = ATLAS_GEMINI_SYSTEM_PROMPT
|
||||
|
||||
// when / then
|
||||
expect(prompt).not.toMatch(/\(READ ONLY\)/)
|
||||
})
|
||||
|
||||
test("plan description should include EDIT for checkboxes", () => {
|
||||
// given
|
||||
const prompt = ATLAS_GEMINI_SYSTEM_PROMPT
|
||||
const lowerPrompt = prompt.toLowerCase()
|
||||
|
||||
// when / then
|
||||
expect(lowerPrompt).toMatch(/edit.*checkbox|checkbox.*edit/)
|
||||
})
|
||||
|
||||
test("boundaries should include exception for editing .sisyphus/plans/*.md checkboxes", () => {
|
||||
// given
|
||||
const prompt = ATLAS_GEMINI_SYSTEM_PROMPT
|
||||
const lowerPrompt = prompt.toLowerCase()
|
||||
|
||||
// when / then
|
||||
expect(lowerPrompt).toMatch(/\.sisyphus\/plans\/\*\.md/)
|
||||
expect(lowerPrompt).toMatch(/checkbox/)
|
||||
})
|
||||
|
||||
test("prompt should include POST-DELEGATION RULE", () => {
|
||||
// given
|
||||
const prompt = ATLAS_GEMINI_SYSTEM_PROMPT
|
||||
const lowerPrompt = prompt.toLowerCase()
|
||||
|
||||
// when / then
|
||||
expect(lowerPrompt).toMatch(/post-delegation/)
|
||||
})
|
||||
|
||||
test("prompt should include MUST NOT call a new task() before", () => {
|
||||
// given
|
||||
const prompt = ATLAS_GEMINI_SYSTEM_PROMPT
|
||||
const lowerPrompt = prompt.toLowerCase()
|
||||
|
||||
// when / then
|
||||
expect(lowerPrompt).toMatch(/must not.*call.*new.*task/)
|
||||
})
|
||||
})
|
||||
})
|
||||
Reference in New Issue
Block a user