From 9bf89deee3bfe996fc5bd01c5da9343f2e00026f Mon Sep 17 00:00:00 2001 From: YeonGyu-Kim Date: Mon, 20 Apr 2026 14:49:35 +0900 Subject: [PATCH] test(delegate-task): add failing tests for metadata continuation gaps Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus --- .../metadata-task-id-consistency.test.ts | 244 ++++++++++++++++++ 1 file changed, 244 insertions(+) diff --git a/src/tools/delegate-task/metadata-task-id-consistency.test.ts b/src/tools/delegate-task/metadata-task-id-consistency.test.ts index c9a2a0b8c..1f0d985d5 100644 --- a/src/tools/delegate-task/metadata-task-id-consistency.test.ts +++ b/src/tools/delegate-task/metadata-task-id-consistency.test.ts @@ -151,6 +151,55 @@ describe("taskId and backgroundTaskId metadata consistency", () => { expect(meta.metadata.sessionId).toBe("ses_resumed_x") expect(meta.metadata.backgroundTaskId).toBe("bg_resumed_y") }) + + test("#when resumed task has category #then metadata.category equals task.category", async () => { + const { executeBackgroundContinuation } = require("./background-continuation") + const ctx = makeMockCtx() + const args: DelegateTaskArgs = { + description: "continue", prompt: "keep going", + load_skills: [], run_in_background: true, task_id: "ses_resumed_x", + } + + await executeBackgroundContinuation(args, ctx, { + manager: { + resume: async () => ({ + id: "bg_resumed_y", description: "continue", agent: "explore", + status: "running", sessionID: "ses_resumed_x", model: MODEL, category: "deep", + }), + }, + } as any, parentContext) + + const meta = ctx.captured.find((item: any) => item.metadata?.sessionId) + expect(meta).toBeDefined() + expect(meta.metadata.category).toBe("deep") + }) + + test("#when publishing metadata with requested_subagent_type #then metadata.requested_subagent_type preserves original", async () => { + const { executeBackgroundContinuation } = require("./background-continuation") + const ctx = makeMockCtx() + const args = { + description: "continue", + prompt: "keep going", + category: "quick", + requested_subagent_type: "oracle", + load_skills: [], + run_in_background: true, + task_id: "ses_resumed_x", + } + + await executeBackgroundContinuation(args, ctx, { + manager: { + resume: async () => ({ + id: "bg_resumed_y", description: "continue", agent: "explore", + status: "running", sessionID: "ses_resumed_x", model: MODEL, + }), + }, + } as any, parentContext) + + const meta = ctx.captured.find((item: any) => item.metadata?.sessionId) + expect(meta).toBeDefined() + expect(meta.metadata.requested_subagent_type).toBe("oracle") + }) }) describe("#given sync-continuation runs", () => { @@ -183,6 +232,201 @@ describe("taskId and backgroundTaskId metadata consistency", () => { expect(meta.metadata.taskId).toBe("ses_cont_abc") expect(meta.metadata.sessionId).toBe("ses_cont_abc") }) + + test("#when resumeAgent is resolved #then metadata.agent equals resumeAgent", async () => { + const { executeSyncContinuation } = require("./sync-continuation") + const ctx = makeMockCtx() + const args: DelegateTaskArgs = { + description: "continue", prompt: "keep going", + load_skills: [], run_in_background: false, task_id: "ses_cont_abc", + } + + const deps = { + pollSyncSession: async () => null, + fetchSyncResult: async () => ({ ok: true as const, textContent: "done" }), + } + + await executeSyncContinuation(args, ctx, { + client: { + session: { + messages: async () => ({ + data: [{ info: { agent: "explore", model: MODEL } }], + }), + prompt: async () => ({}), + }, + }, + } as any, parentContext, deps) + + const meta = ctx.captured.find((item: any) => item.metadata?.sessionId) + expect(meta).toBeDefined() + expect(meta.metadata.agent).toBe("explore") + }) + + test("#when called with category arg #then metadata.category equals args.category", async () => { + const { executeSyncContinuation } = require("./sync-continuation") + const ctx = makeMockCtx() + const args: DelegateTaskArgs = { + description: "continue", prompt: "keep going", + category: "quick", load_skills: [], run_in_background: false, task_id: "ses_cont", + } + + const deps = { + pollSyncSession: async () => null, + fetchSyncResult: async () => ({ ok: true as const, textContent: "done" }), + } + + await executeSyncContinuation(args, ctx, { + client: { + session: { + messages: async () => ({ + data: [{ info: { agent: "explore", model: MODEL } }], + }), + prompt: async () => ({}), + }, + }, + } as any, parentContext, deps) + + const meta = ctx.captured.find((item: any) => item.metadata?.sessionId) + expect(meta).toBeDefined() + expect(meta.metadata.category).toBe("quick") + }) + + test("#when publishing metadata with requested_subagent_type #then metadata.requested_subagent_type preserves original", async () => { + const { executeSyncContinuation } = require("./sync-continuation") + const ctx = makeMockCtx() + const args = { + description: "continue", + prompt: "keep going", + category: "quick", + requested_subagent_type: "oracle", + load_skills: [], + run_in_background: false, + task_id: "ses_cont", + } + + const deps = { + pollSyncSession: async () => null, + fetchSyncResult: async () => ({ ok: true as const, textContent: "done" }), + } + + await executeSyncContinuation(args, ctx, { + client: { + session: { + messages: async () => ({ + data: [{ info: { agent: "explore", model: MODEL } }], + }), + prompt: async () => ({}), + }, + }, + } as any, parentContext, deps) + + const meta = ctx.captured.find((item: any) => item.metadata?.sessionId) + expect(meta).toBeDefined() + expect(meta.metadata.requested_subagent_type).toBe("oracle") + }) + }) + + describe("#given user calls with requested_subagent_type plus category", () => { + test("#when sync-task publishes metadata #then metadata.requested_subagent_type preserves original", async () => { + const { executeSyncTask } = require("./sync-task") + const ctx = makeMockCtx() + const deps = { + createSyncSession: async () => ({ ok: true, sessionID: "ses_sync" }), + sendSyncPrompt: async () => null, + pollSyncSession: async () => null, + fetchSyncResult: async () => ({ ok: true as const, textContent: "done" }), + } + const args = { + description: "test", + prompt: "do it", + category: "quick", + requested_subagent_type: "oracle", + load_skills: [], + run_in_background: false, + } + + await executeSyncTask(args, ctx, { + client: { session: { create: async () => ({ data: { id: "ses_sync" } }) } }, + directory: "/tmp", + onSyncSessionCreated: null, + }, parentContext, "Sisyphus-Junior", MODEL, undefined, undefined, undefined, deps) + + const meta = ctx.captured.find((item: any) => item.metadata?.sessionId) + expect(meta).toBeDefined() + expect(meta.metadata.requested_subagent_type).toBe("oracle") + }) + + test("#when background-task publishes metadata #then metadata.requested_subagent_type preserves original", async () => { + const { executeBackgroundTask } = require("./background-task") + const ctx = makeMockCtx() + const args = { + description: "test", + prompt: "do it", + category: "quick", + requested_subagent_type: "oracle", + load_skills: [], + run_in_background: true, + } + + await executeBackgroundTask(args, ctx, { + manager: { + launch: async () => ({ + id: "bg_abc123", description: "test", agent: "Sisyphus-Junior", + status: "pending", sessionID: "ses_xyz789", + }), + getTask: () => undefined, + }, + } as any, parentContext, "Sisyphus-Junior", MODEL, undefined) + + const meta = ctx.captured.find((item: any) => item.metadata?.sessionId) + expect(meta).toBeDefined() + expect(meta.metadata.requested_subagent_type).toBe("oracle") + }) + + test("#when unstable-agent-task publishes metadata #then metadata.requested_subagent_type preserves original", async () => { + const { executeUnstableAgentTask } = require("./unstable-agent-task") + const ctx = makeMockCtx() + const args = { + description: "test", + prompt: "do it", + category: "quick", + requested_subagent_type: "oracle", + load_skills: [], + run_in_background: false, + } + + const launchedTask = { + id: "bg_unstable_abc", description: "test", agent: "Sisyphus-Junior", + status: "completed", sessionID: "ses_unstable_xyz", + } + + await executeUnstableAgentTask( + args, ctx, + { + manager: { + launch: async () => launchedTask, + getTask: () => launchedTask, + }, + client: { + session: { + status: async () => ({ data: { ses_unstable_xyz: { type: "idle" } } }), + messages: async () => ({ + data: [{ + info: { role: "assistant", time: { created: 1 } }, + parts: [{ type: "text", text: "done" }], + }], + }), + }, + }, + syncPollTimeoutMs: 100, + } as any, + parentContext, "Sisyphus-Junior", MODEL, undefined, "anthropic/claude-sonnet-4-6", + ) + + const meta = ctx.captured.find((item: any) => item.metadata?.sessionId) + expect(meta).toBeDefined() + expect(meta.metadata.requested_subagent_type).toBe("oracle") + }) }) describe("#given background_output runs", () => {