From 9d930656daaa8a8c2839fa8c0aca2696a36b0e93 Mon Sep 17 00:00:00 2001 From: Ravi Tharuma Date: Wed, 25 Mar 2026 10:08:00 +0100 Subject: [PATCH] test(restack): drop stale compatibility expectations --- .../model-settings-compatibility.test.ts | 92 ------------------- 1 file changed, 92 deletions(-) diff --git a/src/shared/model-settings-compatibility.test.ts b/src/shared/model-settings-compatibility.test.ts index 55fc2a872..291da7547 100644 --- a/src/shared/model-settings-compatibility.test.ts +++ b/src/shared/model-settings-compatibility.test.ts @@ -90,29 +90,6 @@ describe("resolveCompatibleModelSettings", () => { }) }) - test("downgrades gpt-5 reasoningEffort max to xhigh", () => { - // given - const input = { - providerID: "openai", - modelID: "gpt-5.4", - desired: { reasoningEffort: "max" }, - } - - // when - const result = resolveCompatibleModelSettings(input) - - // then - expect(result.reasoningEffort).toBe("xhigh") - expect(result.changes).toEqual([ - { - field: "reasoningEffort", - from: "max", - to: "xhigh", - reason: "unsupported-by-model-family", - }, - ]) - }) - test("keeps supported OpenAI reasoning-family effort for o-series models", () => { const result = resolveCompatibleModelSettings({ providerID: "openai", @@ -127,75 +104,6 @@ describe("resolveCompatibleModelSettings", () => { }) }) - test("downgrades openai reasoning-family effort xhigh to high", () => { - // given - const input = { - providerID: "openai", - modelID: "o3-mini", - desired: { reasoningEffort: "xhigh" }, - } - - // when - const result = resolveCompatibleModelSettings(input) - - // then - expect(result.reasoningEffort).toBe("high") - expect(result.changes).toEqual([ - { - field: "reasoningEffort", - from: "xhigh", - to: "high", - reason: "unsupported-by-model-family", - }, - ]) - }) - - test("drops reasoningEffort for gpt-5 mini models", () => { - // given - const input = { - providerID: "openai", - modelID: "gpt-5.4-mini", - desired: { reasoningEffort: "high" }, - } - - // when - const result = resolveCompatibleModelSettings(input) - - // then - expect(result.reasoningEffort).toBeUndefined() - expect(result.changes).toEqual([ - { - field: "reasoningEffort", - from: "high", - to: undefined, - reason: "unsupported-by-model-family", - }, - ]) - }) - - test("treats non-openai o-series models as unknown", () => { - // given - const input = { - providerID: "ollama", - modelID: "o3", - desired: { reasoningEffort: "high" }, - } - - // when - const result = resolveCompatibleModelSettings(input) - - // then - expect(result.reasoningEffort).toBeUndefined() - expect(result.changes).toEqual([ - { - field: "reasoningEffort", - from: "high", - to: undefined, - reason: "unknown-model-family", - }, - ]) - }) - test("does not record case-only normalization as a compatibility downgrade", () => { const result = resolveCompatibleModelSettings({ providerID: "openai",