From a0bea3a415e76ea928dd48d943c6910a4e07f8c1 Mon Sep 17 00:00:00 2001 From: YeonGyu-Kim Date: Sun, 31 May 2026 00:26:10 +0900 Subject: [PATCH] fix: parse packaged telemetry sync defaults correctly --- .../scripts/sync-telemetry-component.mjs | 2 -- .../scripts/sync-telemetry-component.test.mjs | 26 ++++++++++++++++++- 2 files changed, 25 insertions(+), 3 deletions(-) diff --git a/packages/omo-codex/scripts/sync-telemetry-component.mjs b/packages/omo-codex/scripts/sync-telemetry-component.mjs index 5f2946ad0..cf28401f7 100644 --- a/packages/omo-codex/scripts/sync-telemetry-component.mjs +++ b/packages/omo-codex/scripts/sync-telemetry-component.mjs @@ -71,8 +71,6 @@ function isNodeError(error) { function parseArgs(args) { const parsed = { check: false, - sourceDir: DEFAULT_SOURCE_DIR, - componentDir: DEFAULT_COMPONENT_DIR, }; for (let index = 0; index < args.length; index += 1) { const arg = args[index]; diff --git a/packages/omo-codex/scripts/sync-telemetry-component.test.mjs b/packages/omo-codex/scripts/sync-telemetry-component.test.mjs index 1aed15da9..83ad8318a 100644 --- a/packages/omo-codex/scripts/sync-telemetry-component.test.mjs +++ b/packages/omo-codex/scripts/sync-telemetry-component.test.mjs @@ -1,7 +1,8 @@ import assert from "node:assert/strict"; -import { mkdir, mkdtemp, readFile, rm, writeFile } from "node:fs/promises"; +import { cp, mkdir, mkdtemp, readFile, rm, writeFile } from "node:fs/promises"; import { tmpdir } from "node:os"; import { join } from "node:path"; +import { spawnSync } from "node:child_process"; import test from "node:test"; const SCRIPT_PATH = new URL("./sync-telemetry-component.mjs", import.meta.url); @@ -68,3 +69,26 @@ test("#given a missing pure telemetry source file #when sync runs #then it fails await rm(root, { recursive: true, force: true }); } }); + +test("#given packaged default layout without pure telemetry source #when cli sync runs #then it exits cleanly", async () => { + // given + const root = await makeTempDir(); + const scriptPath = join(root, "packages", "omo-codex", "scripts", "sync-telemetry-component.mjs"); + await mkdir(join(root, "packages", "omo-codex", "scripts"), { recursive: true }); + await cp(new URL("./sync-telemetry-component.mjs", import.meta.url), scriptPath); + + try { + // when + const result = spawnSync(process.execPath, [scriptPath], { + encoding: "utf8", + env: { + ...process.env, + }, + }); + + // then + assert.equal(result.status, 0, result.stderr); + } finally { + await rm(root, { recursive: true, force: true }); + } +});