refactor(packages): extract utils package

2026-05-21 00:31:03 +09:00
parent c4fe747e15
commit a5c1d71001
52 changed files with 717 additions and 508 deletions
@@ -0,0 +1,10 @@
+## [2026-05-20T15:12:12Z] Task 2 scope reduction
+Dropped `write-file-atomically.ts` from utils extraction.
+Reason: depends on omo-specific `tolerant-fsync` chain (classify-path-environment, fsync-skip-tracker, logger).
+Decision deferred to a future task.
+Net effect: utils package ships 12 files instead of 13.
+
+## [2026-05-20T15:12:12Z] Task 2 jsonc-parser decoupling
+Choice: Option A
+Reason: Small call-site surface; keeps full jsonc-parser API together in the new package and avoids split ownership.
+Call sites changed: src/plugin-config.ts, src/cli/config-manager/config-context.ts, src/cli/doctor/checks/config.ts, src/cli/doctor/checks/model-resolution-config.ts, src/cli/doctor/checks/team-mode.ts, src/cli/doctor/checks/tools-lsp.ts, src/shared/project-discovery-dirs.ts, packages/utils/src/jsonc-parser.test.ts, packages/utils/src/jsonc-parser.memoization.test.ts
@@ -0,0 +1,23 @@
+
+## [2026-05-20T15:04:52Z] Task 1 baseline
+- Total tests: 7315
+- Pass: 7312, Fail: 2, Skip: 1
+- Build exit code: 0 (dist/ size: 13M, 1456 files)
+- Typecheck exit code: 0
+- Packages: 15 package.json files under packages/, 3 private (ast-grep-mcp, rules-core, web)
+- Anomalies observed: 2 pre-existing test failures in `src/features/opencode-skill-loader/skill-content.test.ts` — ambiguous short name resolution returns 2 resolved skills instead of 1 when "debugging" + "playwright" are queried together. This is a REAL baseline failure; do not fix as part of this refactor plan unless explicitly directed.
+
+## [2026-05-20T15:12:12Z] Task 2 pre-flight
+- `src/shared/deep-merge.ts`: pure, zero imports.
+- `src/shared/snake-case.ts`: imports `./deep-merge` only (moved together) — pure after extraction.
+- `src/shared/record-type-guard.ts`: pure, zero imports.
+- `src/shared/extract-semver.ts`: pure, zero imports.
+- `src/shared/frontmatter.ts`: imports `js-yaml` only.
+- `src/shared/file-utils.ts`: imports `fs` only.
+- `src/shared/contains-path.ts`: imports `fs` and `path` only.
+- `src/shared/port-utils.ts`: imports `node:net` only.
+- `src/shared/tool-name.ts`: pure, zero imports.
+- `src/shared/replace-tool-args.ts`: pure, zero imports.
+- `src/features/boulder-state/format-duration.ts`: pure, zero imports.
+- `src/shared/jsonc-parser.ts`: coupled to plugin basenames; decoupled via parameterized `detectPluginConfigFile(dir, options)`.
+- `src/shared/write-file-atomically.ts`: depends on omo-specific `./tolerant-fsync`; extraction deferred by scope decision (kept in-place).