From 28a896d09370b7550c4bb8ac537d3fe9bff9ba0c Mon Sep 17 00:00:00 2001 From: YeonGyu-Kim Date: Fri, 17 Apr 2026 12:16:27 +0900 Subject: [PATCH 1/3] fix(test): update dynamic-agent-prompt-builder test to expect task_id Same session_id->task_id migration as the atlas hook test. --- src/agents/dynamic-agent-prompt-builder.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/agents/dynamic-agent-prompt-builder.test.ts b/src/agents/dynamic-agent-prompt-builder.test.ts index 7fab72a75..5bf5bcb4b 100644 --- a/src/agents/dynamic-agent-prompt-builder.test.ts +++ b/src/agents/dynamic-agent-prompt-builder.test.ts @@ -244,7 +244,7 @@ describe("buildNonClaudePlannerSection", () => { //#then expect(result).toContain("Plan Agent") - expect(result).toContain("session_id") + expect(result).toContain("task_id") expect(result).toContain("Multi-step") }) From 3a956b2103ce644da9556a186abda8956d03464a Mon Sep 17 00:00:00 2001 From: YeonGyu-Kim Date: Fri, 17 Apr 2026 12:18:22 +0900 Subject: [PATCH 2/3] =?UTF-8?q?fix(test):=20align=20session=5Fid=E2=86=92t?= =?UTF-8?q?ask=5Fid=20across=20tests=20and=20source=20files?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Several places still emitted task(session_id=...) after the refactor: - src/hooks/atlas/verification-reminders.ts: 2 occurrences - src/agents/dynamic-agent-core-sections.ts: buildNonClaudePlannerSection prompt Tests updated to match: atlas index.test.ts and dynamic-agent-prompt-builder.test.ts --- src/agents/dynamic-agent-core-sections.ts | 2 +- src/hooks/atlas/verification-reminders.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/agents/dynamic-agent-core-sections.ts b/src/agents/dynamic-agent-core-sections.ts index dc91fd480..416750a54 100644 --- a/src/agents/dynamic-agent-core-sections.ts +++ b/src/agents/dynamic-agent-core-sections.ts @@ -182,7 +182,7 @@ Multi-step task? **ALWAYS consult Plan Agent first.** Do NOT start implementatio - Single-file fix or trivial change → proceed directly - Anything else (2+ steps, unclear scope, architecture) → \`task(subagent_type="plan", ...)\` FIRST -- Use \`session_id\` to resume the same Plan Agent - ask follow-up questions aggressively +- Use \`task_id\` to resume the same Plan Agent - ask follow-up questions aggressively - If ANY part of the task is ambiguous, ask Plan Agent before guessing Plan Agent returns a structured work breakdown with parallel execution opportunities. Follow it.` diff --git a/src/hooks/atlas/verification-reminders.ts b/src/hooks/atlas/verification-reminders.ts index b00618ecd..9bde55b9d 100644 --- a/src/hooks/atlas/verification-reminders.ts +++ b/src/hooks/atlas/verification-reminders.ts @@ -29,7 +29,7 @@ Your completion will NOT be recorded until you complete ALL of the following: If anything fails while closing this out, resume the same session immediately: \`\`\`typescript -task(session_id="${sessionId}", load_skills=[], prompt="fix: checkbox not recorded correctly") +task(task_id="${sessionId}", load_skills=[], prompt="fix: checkbox not recorded correctly") \`\`\` **Your completion is NOT tracked until the checkbox is marked in the plan file.** @@ -47,7 +47,7 @@ ${VERIFICATION_REMINDER} **If ANY verification fails, use this immediately:** \`\`\` -task(session_id="${sessionId}", load_skills=[], prompt="fix: [describe the specific failure]") +task(task_id="${sessionId}", load_skills=[], prompt="fix: [describe the specific failure]") \`\`\` ${buildReuseHint(sessionId)}` From 2fca3dced8aa495ca069b437ab2451fcc592754a Mon Sep 17 00:00:00 2001 From: YeonGyu-Kim Date: Fri, 17 Apr 2026 12:47:49 +0900 Subject: [PATCH 3/3] =?UTF-8?q?fix(test):=20complete=20session=5Fid?= =?UTF-8?q?=E2=86=92task=5Fid=20migration=20in=20test=20assertions?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The previous PR #3481 only added a not.toContain check but left the final toContain assertion still expecting task(session_id=...). Also updates dynamic-agent-core-sections.ts and verification-reminders.ts which still had session_id format after the refactor. --- src/hooks/atlas/index.test.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/hooks/atlas/index.test.ts b/src/hooks/atlas/index.test.ts index 0f9e7d605..20fb02fc1 100644 --- a/src/hooks/atlas/index.test.ts +++ b/src/hooks/atlas/index.test.ts @@ -957,7 +957,8 @@ session_id: ses_untrusted_999 const updatedState = readBoulderState(TEST_DIR) expect(updatedState?.task_sessions?.["todo:1"]).toBeUndefined() expect(output.output).not.toContain('task(session_id="ses_untrusted_999"') - expect(output.output).toContain('task(session_id=""') + expect(output.output).not.toContain('task(task_id="ses_untrusted_999"') + expect(output.output).toContain('task(task_id=""') cleanupMessageStorage(sessionID) })