fix(agents): honor tools overrides via permission migration

This commit is contained in:
konaespresso94
2026-01-31 00:08:50 +09:00
parent 6c8527f29b
commit ba129784f5
2 changed files with 49 additions and 2 deletions
+46
View File
@@ -523,3 +523,49 @@ describe("override.category expansion in createBuiltinAgents", () => {
expect(agents.oracle.model).toBe(agentsWithoutOverride.oracle.model)
})
})
describe("agent override tools migration", () => {
test("tools: { x: false } is migrated to permission: { x: deny }", async () => {
// #given
const overrides = {
explore: { tools: { "jetbrains_*": false } } as any,
}
// #when
const agents = await createBuiltinAgents([], overrides, undefined, TEST_DEFAULT_MODEL)
// #then
expect(agents.explore).toBeDefined()
const permission = agents.explore.permission as Record<string, string>
expect(permission["jetbrains_*"]).toBe("deny")
})
test("tools: { x: true } is migrated to permission: { x: allow }", async () => {
// #given
const overrides = {
librarian: { tools: { "jetbrains_get_*": true } } as any,
}
// #when
const agents = await createBuiltinAgents([], overrides, undefined, TEST_DEFAULT_MODEL)
// #then
expect(agents.librarian).toBeDefined()
const permission = agents.librarian.permission as Record<string, string>
expect(permission["jetbrains_get_*"]).toBe("allow")
})
test("tools config is removed after migration", async () => {
// #given
const overrides = {
explore: { tools: { "some_tool": false } } as any,
}
// #when
const agents = await createBuiltinAgents([], overrides, undefined, TEST_DEFAULT_MODEL)
// #then
expect(agents.explore).toBeDefined()
expect((agents.explore as any).tools).toBeUndefined()
})
})