fix(agents): use runtime names for default_agent to match ordered agent list

This commit is contained in:
YeonGyu-Kim
2026-04-11 14:15:00 +09:00
parent 630f5b79e7
commit c30b058b7e
5 changed files with 106 additions and 16 deletions
+3 -3
View File
@@ -2,7 +2,7 @@ import { createBuiltinAgents } from "../agents";
import { createSisyphusJuniorAgentWithOverrides } from "../agents/sisyphus-junior"; import { createSisyphusJuniorAgentWithOverrides } from "../agents/sisyphus-junior";
import type { OhMyOpenCodeConfig } from "../config"; import type { OhMyOpenCodeConfig } from "../config";
import { isTaskSystemEnabled, log, migrateAgentConfig } from "../shared"; import { isTaskSystemEnabled, log, migrateAgentConfig } from "../shared";
import { getAgentDisplayName } from "../shared/agent-display-names"; import { getAgentRuntimeName } from "../shared/agent-display-names";
import { AGENT_NAME_MAP } from "../shared/migration"; import { AGENT_NAME_MAP } from "../shared/migration";
import { registerAgentName } from "../features/claude-code-session-state"; import { registerAgentName } from "../features/claude-code-session-state";
import { import {
@@ -159,10 +159,10 @@ export async function applyAgentConfig(params: {
if (isSisyphusEnabled && builtinAgents.sisyphus) { if (isSisyphusEnabled && builtinAgents.sisyphus) {
if (configuredDefaultAgent) { if (configuredDefaultAgent) {
(params.config as { default_agent?: string }).default_agent = (params.config as { default_agent?: string }).default_agent =
getAgentDisplayName(configuredDefaultAgent); getAgentRuntimeName(configuredDefaultAgent);
} else { } else {
(params.config as { default_agent?: string }).default_agent = (params.config as { default_agent?: string }).default_agent =
getAgentDisplayName("sisyphus"); getAgentRuntimeName("sisyphus");
} }
// Assembly order: Sisyphus -> Hephaestus -> Prometheus -> Atlas // Assembly order: Sisyphus -> Hephaestus -> Prometheus -> Atlas
+44 -1
View File
@@ -1,6 +1,6 @@
import { describe, it, expect } from "bun:test" import { describe, it, expect } from "bun:test"
import { remapAgentKeysToDisplayNames } from "./agent-key-remapper" import { remapAgentKeysToDisplayNames } from "./agent-key-remapper"
import { getAgentDisplayName } from "../shared/agent-display-names" import { getAgentDisplayName, getAgentRuntimeName } from "../shared/agent-display-names"
describe("remapAgentKeysToDisplayNames", () => { describe("remapAgentKeysToDisplayNames", () => {
it("remaps known agent keys to display names", () => { it("remaps known agent keys to display names", () => {
@@ -105,4 +105,47 @@ describe("remapAgentKeysToDisplayNames", () => {
expect(name).not.toContain("\u200B") expect(name).not.toContain("\u200B")
} }
}) })
it("preserves clean keys but rewrites core agent name fields to list-display names for tab cycling", () => {
// given agents with raw config-key names
const agents = {
sisyphus: { name: "sisyphus", prompt: "test", mode: "primary" },
hephaestus: { name: "hephaestus", prompt: "test", mode: "primary" },
prometheus: { name: "prometheus", prompt: "test", mode: "all" },
atlas: { name: "atlas", prompt: "test", mode: "primary" },
oracle: { name: "oracle", prompt: "test", mode: "subagent" },
}
// when remapping
const result = remapAgentKeysToDisplayNames(agents)
// then keys stay HTTP-header-safe, but nested names carry stable list ordering
expect(Object.keys(result).slice(0, 4)).toEqual([
getAgentDisplayName("sisyphus"),
getAgentDisplayName("hephaestus"),
getAgentDisplayName("prometheus"),
getAgentDisplayName("atlas"),
])
expect(result[getAgentDisplayName("sisyphus")]).toEqual({
name: getAgentRuntimeName("sisyphus"),
prompt: "test",
mode: "primary",
})
expect(result[getAgentDisplayName("hephaestus")]).toEqual({
name: getAgentRuntimeName("hephaestus"),
prompt: "test",
mode: "primary",
})
expect(result[getAgentDisplayName("prometheus")]).toEqual({
name: getAgentRuntimeName("prometheus"),
prompt: "test",
mode: "all",
})
expect(result[getAgentDisplayName("atlas")]).toEqual({
name: getAgentRuntimeName("atlas"),
prompt: "test",
mode: "primary",
})
expect(result.oracle).toEqual({ name: "oracle", prompt: "test", mode: "subagent" })
})
}) })
+21 -2
View File
@@ -1,4 +1,23 @@
import { getAgentDisplayName } from "../shared/agent-display-names" import { getAgentDisplayName, getAgentRuntimeName } from "../shared/agent-display-names"
function rewriteAgentNameForListDisplay(
key: string,
value: unknown,
): unknown {
if (typeof value !== "object" || value === null || !("name" in value)) {
return value
}
const agent = value as Record<string, unknown>
if (typeof agent.name !== "string") {
return value
}
return {
...agent,
name: getAgentRuntimeName(key),
}
}
export function remapAgentKeysToDisplayNames( export function remapAgentKeysToDisplayNames(
agents: Record<string, unknown>, agents: Record<string, unknown>,
@@ -8,7 +27,7 @@ export function remapAgentKeysToDisplayNames(
for (const [key, value] of Object.entries(agents)) { for (const [key, value] of Object.entries(agents)) {
const displayName = getAgentDisplayName(key) const displayName = getAgentDisplayName(key)
if (displayName && displayName !== key) { if (displayName && displayName !== key) {
result[displayName] = value result[displayName] = rewriteAgentNameForListDisplay(key, value)
// Regression guard: do not also assign result[key]. // Regression guard: do not also assign result[key].
// This line was repeatedly re-added and caused duplicate agent rows in the UI. // This line was repeatedly re-added and caused duplicate agent rows in the UI.
// Runtime callers that previously depended on config-key aliases were fixed in: // Runtime callers that previously depended on config-key aliases were fixed in:
+30 -6
View File
@@ -3,7 +3,7 @@
import { describe, test, expect, spyOn, beforeEach, afterEach, mock } from "bun:test" import { describe, test, expect, spyOn, beforeEach, afterEach, mock } from "bun:test"
import type { CategoryConfig } from "../config/schema" import type { CategoryConfig } from "../config/schema"
import type { OhMyOpenCodeConfig } from "../config" import type { OhMyOpenCodeConfig } from "../config"
import { getAgentDisplayName } from "../shared/agent-display-names" import { getAgentDisplayName, getAgentRuntimeName } from "../shared/agent-display-names"
import { resolveCategoryConfig } from "./category-config-resolver" import { resolveCategoryConfig } from "./category-config-resolver"
import * as agents from "../agents" import * as agents from "../agents"
@@ -479,7 +479,7 @@ describe("default_agent behavior with Sisyphus orchestration", () => {
await handler(config) await handler(config)
// then // then
expect(config.default_agent).toBe(getAgentDisplayName("hephaestus")) expect(config.default_agent).toBe(getAgentRuntimeName("hephaestus"))
}) })
test("canonicalizes configured default_agent when key uses mixed case", async () => { test("canonicalizes configured default_agent when key uses mixed case", async () => {
@@ -503,7 +503,7 @@ describe("default_agent behavior with Sisyphus orchestration", () => {
await handler(config) await handler(config)
// then // then
expect(config.default_agent).toBe(getAgentDisplayName("hephaestus")) expect(config.default_agent).toBe(getAgentRuntimeName("hephaestus"))
}) })
test("canonicalizes configured default_agent key to display name", async () => { test("canonicalizes configured default_agent key to display name", async () => {
@@ -527,7 +527,7 @@ describe("default_agent behavior with Sisyphus orchestration", () => {
await handler(config) await handler(config)
// #then // #then
expect(config.default_agent).toBe(getAgentDisplayName("hephaestus")) expect(config.default_agent).toBe(getAgentRuntimeName("hephaestus"))
}) })
test("preserves existing display-name default_agent", async () => { test("preserves existing display-name default_agent", async () => {
@@ -575,7 +575,31 @@ describe("default_agent behavior with Sisyphus orchestration", () => {
await handler(config) await handler(config)
// #then // #then
expect(config.default_agent).toBe(getAgentDisplayName("sisyphus")) expect(config.default_agent).toBe(getAgentRuntimeName("sisyphus"))
})
test("uses runtime default_agent name so OpenCode matches the emitted ordered agent names", async () => {
// given
const pluginConfig = createPluginConfig({})
const config: Record<string, unknown> = {
model: "anthropic/claude-opus-4-6",
default_agent: "hephaestus",
agent: {},
}
const handler = createConfigHandler({
ctx: { directory: "/tmp" },
pluginConfig,
modelCacheState: {
anthropicContext1MEnabled: false,
modelContextLimitsCache: new Map(),
},
})
// when
await handler(config)
// then
expect(config.default_agent).toBe(getAgentRuntimeName("hephaestus"))
}) })
test("sets default_agent to sisyphus when configured default_agent is empty after trim", async () => { test("sets default_agent to sisyphus when configured default_agent is empty after trim", async () => {
@@ -599,7 +623,7 @@ describe("default_agent behavior with Sisyphus orchestration", () => {
await handler(config) await handler(config)
// then // then
expect(config.default_agent).toBe(getAgentDisplayName("sisyphus")) expect(config.default_agent).toBe(getAgentRuntimeName("sisyphus"))
}) })
test("preserves custom default_agent names while trimming whitespace", async () => { test("preserves custom default_agent names while trimming whitespace", async () => {
+8 -4
View File
@@ -37,6 +37,13 @@ export function stripAgentListSortPrefix(agentName: string): string {
return agentName.replace(/^\u200B+/, "") return agentName.replace(/^\u200B+/, "")
} }
export function getAgentRuntimeName(configKey: string): string {
const displayName = getAgentDisplayName(configKey)
const prefix = AGENT_LIST_SORT_PREFIXES[configKey.toLowerCase()]
return prefix ? `${prefix}${displayName}` : displayName
}
/** /**
* Get display name for an agent config key. * Get display name for an agent config key.
* Uses case-insensitive lookup for backward compatibility. * Uses case-insensitive lookup for backward compatibility.
@@ -65,10 +72,7 @@ export function getAgentDisplayName(configKey: string): string {
* See: https://github.com/code-yeongyu/oh-my-openagent/issues/3238 * See: https://github.com/code-yeongyu/oh-my-openagent/issues/3238
*/ */
export function getAgentListDisplayName(configKey: string): string { export function getAgentListDisplayName(configKey: string): string {
const displayName = getAgentDisplayName(configKey) return getAgentRuntimeName(configKey)
const prefix = AGENT_LIST_SORT_PREFIXES[configKey.toLowerCase()]
return prefix ? `${prefix}${displayName}` : displayName
} }
const REVERSE_DISPLAY_NAMES: Record<string, string> = Object.fromEntries( const REVERSE_DISPLAY_NAMES: Record<string, string> = Object.fromEntries(