add skills

This commit is contained in:
YeonGyu-Kim
2026-03-14 12:45:53 +09:00
parent 0dcfcd372b
commit c7518eae2d
81 changed files with 19037 additions and 0 deletions
@@ -0,0 +1,10 @@
{
"run_id": "eval-4-with_skill",
"expectations": [
{"text": "Plan uses git worktree in a sibling directory", "passed": true, "evidence": "../omo-wt/feat/arxiv-mcp"},
{"text": "New MCP follows existing pattern from src/mcp/", "passed": true, "evidence": "Follows context7.ts and grep-app.ts static export pattern"},
{"text": "Verification loop includes all 3 gates", "passed": true, "evidence": "Gate A (CI), Gate B (review-work 5 agents), Gate C (Cubic)"},
{"text": "PR targets dev branch", "passed": true, "evidence": "--base dev"},
{"text": "Runs local checks before pushing", "passed": true, "evidence": "bun run typecheck, bun test src/mcp/, bun run build"}
]
}
@@ -0,0 +1,143 @@
# Code Changes: Issue #100 - Built-in arXiv MCP
## 1. NEW FILE: `src/mcp/arxiv.ts`
```typescript
export const arxiv = {
type: "remote" as const,
url: "https://mcp.arxiv.org",
enabled: true,
oauth: false as const,
}
```
Pattern: identical to `grep-app.ts` (static export, no auth, no config factory needed).
## 2. MODIFY: `src/mcp/types.ts`
```typescript
import { z } from "zod"
export const McpNameSchema = z.enum(["websearch", "context7", "grep_app", "arxiv"])
export type McpName = z.infer<typeof McpNameSchema>
export const AnyMcpNameSchema = z.string().min(1)
export type AnyMcpName = z.infer<typeof AnyMcpNameSchema>
```
Change: add `"arxiv"` to `McpNameSchema` enum.
## 3. MODIFY: `src/mcp/index.ts`
```typescript
import { createWebsearchConfig } from "./websearch"
import { context7 } from "./context7"
import { grep_app } from "./grep-app"
import { arxiv } from "./arxiv"
import type { OhMyOpenCodeConfig } from "../config/schema"
export { McpNameSchema, type McpName } from "./types"
type RemoteMcpConfig = {
type: "remote"
url: string
enabled: boolean
headers?: Record<string, string>
oauth?: false
}
export function createBuiltinMcps(disabledMcps: string[] = [], config?: OhMyOpenCodeConfig) {
const mcps: Record<string, RemoteMcpConfig> = {}
if (!disabledMcps.includes("websearch")) {
mcps.websearch = createWebsearchConfig(config?.websearch)
}
if (!disabledMcps.includes("context7")) {
mcps.context7 = context7
}
if (!disabledMcps.includes("grep_app")) {
mcps.grep_app = grep_app
}
if (!disabledMcps.includes("arxiv")) {
mcps.arxiv = arxiv
}
return mcps
}
```
Changes: import `arxiv`, add conditional block.
## 4. NEW FILE: `src/mcp/arxiv.test.ts`
```typescript
import { describe, expect, test } from "bun:test"
import { arxiv } from "./arxiv"
describe("arxiv MCP configuration", () => {
test("should have correct remote config shape", () => {
// given
// arxiv is a static export
// when
const config = arxiv
// then
expect(config.type).toBe("remote")
expect(config.url).toBe("https://mcp.arxiv.org")
expect(config.enabled).toBe(true)
expect(config.oauth).toBe(false)
})
})
```
## 5. MODIFY: `src/mcp/index.test.ts`
Changes needed:
- Test "should return all MCPs when disabled_mcps is empty": add `expect(result).toHaveProperty("arxiv")`, change length to 4
- Test "should filter out all built-in MCPs when all disabled": add `"arxiv"` to disabledMcps array, add `expect(result).not.toHaveProperty("arxiv")`
- Test "should handle empty disabled_mcps by default": add `expect(result).toHaveProperty("arxiv")`, change length to 4
- Test "should only filter built-in MCPs, ignoring unknown names": add `expect(result).toHaveProperty("arxiv")`, change length to 4
New test to add:
```typescript
test("should filter out arxiv when disabled", () => {
// given
const disabledMcps = ["arxiv"]
// when
const result = createBuiltinMcps(disabledMcps)
// then
expect(result).toHaveProperty("websearch")
expect(result).toHaveProperty("context7")
expect(result).toHaveProperty("grep_app")
expect(result).not.toHaveProperty("arxiv")
expect(Object.keys(result)).toHaveLength(3)
})
```
## 6. MODIFY: `src/mcp/AGENTS.md`
Add row to built-in MCPs table:
```
| **arxiv** | `mcp.arxiv.org` | None | arXiv paper search |
```
## Files touched summary
| File | Action |
|------|--------|
| `src/mcp/arxiv.ts` | NEW |
| `src/mcp/arxiv.test.ts` | NEW |
| `src/mcp/types.ts` | MODIFY (add enum value) |
| `src/mcp/index.ts` | MODIFY (import + conditional block) |
| `src/mcp/index.test.ts` | MODIFY (update counts + new test) |
| `src/mcp/AGENTS.md` | MODIFY (add table row) |
@@ -0,0 +1,82 @@
# Execution Plan: Issue #100 - Built-in arXiv MCP
## Phase 0: Setup
1. `git fetch origin dev`
2. `git worktree add ../omo-wt/feat/arxiv-mcp origin/dev`
3. `cd ../omo-wt/feat/arxiv-mcp`
4. `git checkout -b feat/arxiv-mcp`
## Phase 1: Implement
### Step 1: Create `src/mcp/arxiv.ts`
- Follow static export pattern (same as `context7.ts` and `grep-app.ts`)
- arXiv API is public, no auth needed
- URL: `https://mcp.arxiv.org` (hypothetical remote MCP endpoint)
- If no remote MCP exists for arXiv, this would need to be a stdio MCP or a custom HTTP wrapper. For this plan, we assume a remote MCP endpoint pattern consistent with existing built-ins.
### Step 2: Update `src/mcp/types.ts`
- Add `"arxiv"` to `McpNameSchema` enum: `z.enum(["websearch", "context7", "grep_app", "arxiv"])`
### Step 3: Update `src/mcp/index.ts`
- Import `arxiv` from `"./arxiv"`
- Add conditional block in `createBuiltinMcps()`:
```typescript
if (!disabledMcps.includes("arxiv")) {
mcps.arxiv = arxiv
}
```
### Step 4: Create `src/mcp/arxiv.test.ts`
- Test arXiv config shape (type, url, enabled, oauth)
- Follow pattern from existing tests (given/when/then)
### Step 5: Update `src/mcp/index.test.ts`
- Update expected MCP count from 3 to 4
- Add `"arxiv"` to `toHaveProperty` checks
- Add `"arxiv"` to the "all disabled" test case
### Step 6: Update `src/mcp/AGENTS.md`
- Add arxiv row to the built-in MCPs table
### Step 7: Local validation
- `bun run typecheck`
- `bun test src/mcp/`
- `bun run build`
### Atomic commits (in order):
1. `feat(mcp): add arxiv paper search built-in MCP` - arxiv.ts + types.ts update
2. `test(mcp): add arxiv MCP tests` - arxiv.test.ts + index.test.ts updates
3. `docs(mcp): update AGENTS.md with arxiv MCP` - AGENTS.md update
## Phase 2: PR Creation
1. `git push -u origin feat/arxiv-mcp`
2. `gh pr create --base dev --title "feat(mcp): add built-in arXiv paper search MCP" --body-file /tmp/pull-request-arxiv-mcp-*.md`
## Phase 3: Verify Loop
### Gate A: CI
- Wait for `ci.yml` workflow (tests, typecheck, build)
- `gh run watch` or poll `gh pr checks`
### Gate B: review-work
- Run `/review-work` skill (5-agent parallel review)
- All 5 agents must pass: Oracle (goal), Oracle (code quality), Oracle (security), QA execution, context mining
### Gate C: Cubic
- Wait for cubic-dev-ai[bot] automated review
- Must show "No issues found"
- If issues found, fix and re-push
### Failure handling:
- Gate A fail: fix locally, amend or new commit, re-push
- Gate B fail: address review-work findings, new commit
- Gate C fail: address Cubic findings, new commit
- Re-enter verify loop from Gate A
## Phase 4: Merge
1. `gh pr merge --squash --delete-branch`
2. `git worktree remove ../omo-wt/feat/arxiv-mcp`
3. `git branch -D feat/arxiv-mcp` (if not auto-deleted)
@@ -0,0 +1,51 @@
# PR: feat(mcp): add built-in arXiv paper search MCP
## Title
`feat(mcp): add built-in arXiv paper search MCP`
## Body
```markdown
## Summary
Closes #100
- Add `arxiv` as 4th built-in remote MCP for arXiv paper search
- Follows existing static export pattern (same as `grep_app`, `context7`)
- No auth required, disableable via `disabled_mcps: ["arxiv"]`
## Changes
- `src/mcp/arxiv.ts` - new MCP config (static export, remote type)
- `src/mcp/types.ts` - add `"arxiv"` to `McpNameSchema` enum
- `src/mcp/index.ts` - register arxiv in `createBuiltinMcps()`
- `src/mcp/arxiv.test.ts` - config shape tests
- `src/mcp/index.test.ts` - update counts, add disable test
- `src/mcp/AGENTS.md` - document new MCP
## Usage
Enabled by default. Disable with:
```jsonc
// .opencode/oh-my-opencode.jsonc
{
"disabled_mcps": ["arxiv"]
}
```
## Validation
- [x] `bun run typecheck` passes
- [x] `bun test src/mcp/` passes
- [x] `bun run build` passes
```
## Labels
`enhancement`, `mcp`
## Base branch
`dev`
@@ -0,0 +1,69 @@
# Verification Strategy: Issue #100 - arXiv MCP
## Gate A: CI (`ci.yml`)
### What runs
- `bun test` (split: mock-heavy isolated + batch) - must include new `arxiv.test.ts` and updated `index.test.ts`
- `bun run typecheck` - validates `McpNameSchema` enum change propagates correctly
- `bun run build` - ensures no build regressions
### How to monitor
```bash
gh pr checks <pr-number> --watch
```
### Failure scenarios
| Failure | Likely cause | Fix |
|---------|-------------|-----|
| Type error in `types.ts` | Enum value not matching downstream consumers | Check all `McpName` usages via `lsp_find_references` |
| Test count mismatch in `index.test.ts` | Forgot to update `toHaveLength()` from 3 to 4 | Update all length assertions |
| Build failure | Import path or barrel export issue | Verify `src/mcp/index.ts` exports are clean |
### Retry
Fix locally in worktree, new commit, `git push`.
## Gate B: review-work (5-agent)
### Agents and focus areas
| Agent | What it checks for this PR |
|-------|--------------------------|
| Oracle (goal) | Does arxiv MCP satisfy issue #100 requirements? |
| Oracle (code quality) | Follows `grep-app.ts` pattern? No SRP violations? < 200 LOC? |
| Oracle (security) | No credentials hardcoded, no auth bypass |
| QA (execution) | Run tests, verify disable mechanism works |
| Context (mining) | Check issue #100 for any missed requirements |
### Pass criteria
All 5 must pass. Any single failure blocks.
### Failure handling
- Read each agent's report
- Address findings with new atomic commits
- Re-run full verify loop from Gate A
## Gate C: Cubic (`cubic-dev-ai[bot]`)
### Expected review scope
- Config shape consistency across MCPs
- Test coverage for new MCP
- Schema type safety
### Pass criteria
Comment from `cubic-dev-ai[bot]` containing "No issues found".
### Failure handling
- Read Cubic's specific findings
- Fix with new commit
- Re-push, re-enter Gate A
## Pre-merge checklist
- [ ] Gate A: CI green
- [ ] Gate B: All 5 review-work agents pass
- [ ] Gate C: Cubic "No issues found"
- [ ] No unresolved review comments
- [ ] PR has at least 1 approval (if required by branch protection)
## Post-merge
1. `gh pr merge --squash --delete-branch`
2. `git worktree remove ../omo-wt/feat/arxiv-mcp`
3. Verify merge commit on `dev` branch
@@ -0,0 +1 @@
{"total_tokens": null, "duration_ms": 152000, "total_duration_seconds": 152}