fix(subagent): remove permission.question=deny override that caused zombie sessions

Child session creation was injecting permission: { question: 'deny' } which conflicted with OpenCode's child session permission handling, causing subagent sessions to hang with 0 messages after creation (zombie state). Remove the permission override from all session creators (BackgroundManager, sync-session-creator, call-omo-agent) and rely on prompt-level tool restrictions (tools.question=false) to maintain the intended policy. Closes #1711
2026-02-11 11:55:56 +09:00
parent 73c0fc9bb5
commit cd0e2e5190
12 changed files with 106 additions and 33 deletions
@@ -0,0 +1,50 @@
+import { describe, expect, test } from "bun:test"
+
+import { createOrGetSession } from "./session-creator"
+import { _resetForTesting, subagentSessions } from "../../features/claude-code-session-state"
+
+describe("call-omo-agent createOrGetSession", () => {
+  test("creates child session without overriding permission and tracks it as subagent session", async () => {
+    // given
+    _resetForTesting()
+
+    const createCalls: Array<unknown> = []
+    const ctx = {
+      directory: "/project",
+      client: {
+        session: {
+          get: async () => ({ data: { directory: "/parent" } }),
+          create: async (args: unknown) => {
+            createCalls.push(args)
+            return { data: { id: "ses_child" } }
+          },
+        },
+      },
+    }
+
+    const toolContext = {
+      sessionID: "ses_parent",
+      messageID: "msg_parent",
+      agent: "sisyphus",
+      abort: new AbortController().signal,
+    }
+
+    const args = {
+      description: "test",
+      prompt: "hello",
+      subagent_type: "explore",
+      run_in_background: true,
+    }
+
+    // when
+    const result = await createOrGetSession(args as any, toolContext as any, ctx as any)
+
+    // then
+    expect(result).toEqual({ sessionID: "ses_child", isNew: true })
+    expect(createCalls).toHaveLength(1)
+    const createBody = (createCalls[0] as any)?.body
+    expect(createBody?.parentID).toBe("ses_parent")
+    expect(createBody?.permission).toBeUndefined()
+    expect(subagentSessions.has("ses_child")).toBe(true)
+  })
+})