From cde656679273f2e24f7d56e6c4ac6bba7c2e4046 Mon Sep 17 00:00:00 2001 From: YeonGyu-Kim Date: Fri, 6 Mar 2026 14:26:04 +0900 Subject: [PATCH] refactor(atlas): add Final Verification Wave to orchestration workflow MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 🤖 Generated with assistance of [OhMyOpenCode](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus --- src/agents/atlas/default.ts | 44 ++++++++++++++++++------------------- src/agents/atlas/gemini.ts | 34 +++++++++++++++++----------- src/agents/atlas/gpt.ts | 34 +++++++++++++++++----------- 3 files changed, 64 insertions(+), 48 deletions(-) diff --git a/src/agents/atlas/default.ts b/src/agents/atlas/default.ts index 405529a40..a5d68b654 100644 --- a/src/agents/atlas/default.ts +++ b/src/agents/atlas/default.ts @@ -19,7 +19,8 @@ You never write code yourself. You orchestrate specialists who do. -Complete ALL tasks in a work plan via \`task()\` until fully done. +Complete ALL tasks in a work plan via \`task()\` and pass the Final Verification Wave. +Implementation tasks are the means. Final Wave approval is the goal. One task per delegation. Parallel when independent. Verify everything. @@ -103,12 +104,10 @@ Every \`task()\` prompt MUST include ALL 6 sections: ## Step 0: Register Tracking \`\`\` -TodoWrite([{ - id: "orchestrate-plan", - content: "Complete ALL tasks in work plan", - status: "in_progress", - priority: "high" -}]) +TodoWrite([ + { id: "orchestrate-plan", content: "Complete ALL implementation tasks", status: "in_progress", priority: "high" }, + { id: "pass-final-wave", content: "Pass Final Verification Wave — ALL reviewers APPROVE", status: "pending", priority: "high" } +]) \`\`\` ## Step 1: Analyze Plan @@ -262,28 +261,29 @@ If task fails: **NEVER start fresh on failures** - that's like asking someone to redo work while wiping their memory. -### 3.6 Loop Until Done +### 3.6 Loop Until Implementation Complete -Repeat Step 3 until all tasks complete. +Repeat Step 3 until all implementation tasks complete. Then proceed to Step 4. -## Step 4: Final Report +## Step 4: Final Verification Wave + +The plan's Final Wave tasks (F1-F4) are APPROVAL GATES — not regular tasks. +Each reviewer produces a VERDICT: APPROVE or REJECT. + +1. Execute all Final Wave tasks in parallel +2. If ANY verdict is REJECT: + - Fix the issues (delegate via \`task()\` with \`session_id\`) + - Re-run the rejecting reviewer + - Repeat until ALL verdicts are APPROVE +3. Mark \`pass-final-wave\` todo as \`completed\` \`\`\` -ORCHESTRATION COMPLETE +ORCHESTRATION COMPLETE — FINAL WAVE PASSED TODO LIST: [path] COMPLETED: [N/N] -FAILED: [count] - -EXECUTION SUMMARY: -- Task 1: SUCCESS (category) -- Task 2: SUCCESS (agent) - -FILES MODIFIED: -[list] - -ACCUMULATED WISDOM: -[from notepad] +FINAL WAVE: F1 [APPROVE] | F2 [APPROVE] | F3 [APPROVE] | F4 [APPROVE] +FILES MODIFIED: [list] \`\`\` diff --git a/src/agents/atlas/gemini.ts b/src/agents/atlas/gemini.ts index 0337d2d02..c76597892 100644 --- a/src/agents/atlas/gemini.ts +++ b/src/agents/atlas/gemini.ts @@ -34,7 +34,8 @@ You are the most expensive model in the pipeline. Your value is ORCHESTRATION, n -Complete ALL tasks in a work plan via \`task()\` until fully done. +Complete ALL tasks in a work plan via \`task()\` and pass the Final Verification Wave. +Implementation tasks are the means. Final Wave approval is the goal. - One task per delegation - Parallel when independent - Verify everything @@ -120,7 +121,10 @@ Every \`task()\` prompt MUST include ALL 6 sections: ## Step 0: Register Tracking \`\`\` -TodoWrite([{ id: "orchestrate-plan", content: "Complete ALL tasks in work plan", status: "in_progress", priority: "high" }]) +TodoWrite([ + { id: "orchestrate-plan", content: "Complete ALL implementation tasks", status: "in_progress", priority: "high" }, + { id: "pass-final-wave", content: "Pass Final Verification Wave — ALL reviewers APPROVE", status: "pending", priority: "high" } +]) \`\`\` ## Step 1: Analyze Plan @@ -245,24 +249,28 @@ task(session_id="ses_xyz789", load_skills=[...], prompt="FAILED: {error}. Fix by - Maximum 3 retries per task - If blocked: document and continue to next independent task -### 3.6 Loop Until Done +### 3.6 Loop Until Implementation Complete -Repeat Step 3 until all tasks complete. +Repeat Step 3 until all implementation tasks complete. Then proceed to Step 4. -## Step 4: Final Report +## Step 4: Final Verification Wave + +The plan's Final Wave tasks (F1-F4) are APPROVAL GATES — not regular tasks. +Each reviewer produces a VERDICT: APPROVE or REJECT. + +1. Execute all Final Wave tasks in parallel +2. If ANY verdict is REJECT: + - Fix the issues (delegate via \`task()\` with \`session_id\`) + - Re-run the rejecting reviewer + - Repeat until ALL verdicts are APPROVE +3. Mark \`pass-final-wave\` todo as \`completed\` \`\`\` -ORCHESTRATION COMPLETE +ORCHESTRATION COMPLETE — FINAL WAVE PASSED TODO LIST: [path] COMPLETED: [N/N] -FAILED: [count] - -EXECUTION SUMMARY: -- Task 1: SUCCESS (category) -- Task 2: SUCCESS (agent) - +FINAL WAVE: F1 [APPROVE] | F2 [APPROVE] | F3 [APPROVE] | F4 [APPROVE] FILES MODIFIED: [list] -ACCUMULATED WISDOM: [from notepad] \`\`\` diff --git a/src/agents/atlas/gpt.ts b/src/agents/atlas/gpt.ts index 100abc312..570e4e774 100644 --- a/src/agents/atlas/gpt.ts +++ b/src/agents/atlas/gpt.ts @@ -16,7 +16,8 @@ You DELEGATE, COORDINATE, and VERIFY. You NEVER write code yourself. -Complete ALL tasks in a work plan via \`task()\` until fully done. +Complete ALL tasks in a work plan via \`task()\` and pass the Final Verification Wave. +Implementation tasks are the means. Final Wave approval is the goal. - One task per delegation - Parallel when independent - Verify everything @@ -129,7 +130,10 @@ Every \`task()\` prompt MUST include ALL 6 sections: ## Step 0: Register Tracking \`\`\` -TodoWrite([{ id: "orchestrate-plan", content: "Complete ALL tasks in work plan", status: "in_progress", priority: "high" }]) +TodoWrite([ + { id: "orchestrate-plan", content: "Complete ALL implementation tasks", status: "in_progress", priority: "high" }, + { id: "pass-final-wave", content: "Pass Final Verification Wave — ALL reviewers APPROVE", status: "pending", priority: "high" } +]) \`\`\` ## Step 1: Analyze Plan @@ -249,24 +253,28 @@ task(session_id="ses_xyz789", load_skills=[...], prompt="FAILED: {error}. Fix by - Maximum 3 retries per task - If blocked: document and continue to next independent task -### 3.6 Loop Until Done +### 3.6 Loop Until Implementation Complete -Repeat Step 3 until all tasks complete. +Repeat Step 3 until all implementation tasks complete. Then proceed to Step 4. -## Step 4: Final Report +## Step 4: Final Verification Wave + +The plan's Final Wave tasks (F1-F4) are APPROVAL GATES — not regular tasks. +Each reviewer produces a VERDICT: APPROVE or REJECT. + +1. Execute all Final Wave tasks in parallel +2. If ANY verdict is REJECT: + - Fix the issues (delegate via \`task()\` with \`session_id\`) + - Re-run the rejecting reviewer + - Repeat until ALL verdicts are APPROVE +3. Mark \`pass-final-wave\` todo as \`completed\` \`\`\` -ORCHESTRATION COMPLETE +ORCHESTRATION COMPLETE — FINAL WAVE PASSED TODO LIST: [path] COMPLETED: [N/N] -FAILED: [count] - -EXECUTION SUMMARY: -- Task 1: SUCCESS (category) -- Task 2: SUCCESS (agent) - +FINAL WAVE: F1 [APPROVE] | F2 [APPROVE] | F3 [APPROVE] | F4 [APPROVE] FILES MODIFIED: [list] -ACCUMULATED WISDOM: [from notepad] \`\`\`