luna/oh-my-opencode
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(agents): replace 'in' with Object.hasOwn() for prototype-safe property checks

Browse Source 
Addresses cubic-dev-ai review: using 'in' on plain objects can skip valid
agent names that match inherited properties (toString, constructor, etc.).
Switched both occurrences in opencode-config-agents-reader.ts to
Object.hasOwn() for safe own-property checks.
This commit is contained in:
Brandon Webb
2026-04-14 20:45:22 -04:00
committed by YeonGyu-Kim
parent 42445f5130
commit cf4b231553
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/features/claude-code-agent-loader/opencode-config-agents-reader.ts
+2 -2
View File
@@ -96,7 +96,7 @@ export function readOpencodeConfigAgents(directory: string): Record<string, Clau
if (agentsToLoad && typeof agentsToLoad === "object") { if (agentsToLoad && typeof agentsToLoad === "object") {
for (const [agentName, agentData] of Object.entries(agentsToLoad)) { for (const [agentName, agentData] of Object.entries(agentsToLoad)) {
if (agentName in result) continue if (Object.hasOwn(result, agentName)) continue
const converted = convertInlineAgent(agentData) const converted = convertInlineAgent(agentData)
if (converted) { if (converted) {
result[agentName] = converted result[agentName] = converted
@@ -113,7 +113,7 @@ export function readOpencodeConfigAgents(directory: string): Record<string, Clau
const definitionAgents = loadAgentDefinitions(resolvedPaths, "opencode-config") const definitionAgents = loadAgentDefinitions(resolvedPaths, "opencode-config")
for (const [name, config] of Object.entries(definitionAgents)) { for (const [name, config] of Object.entries(definitionAgents)) {
if (!(name in result)) { if (!Object.hasOwn(result, name)) {
result[name] = config result[name] = config
} }
} }