fix(ralph-loop): skip idle continuation during background tasks
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This commit is contained in:
@@ -59,6 +59,7 @@ export function createHooks(args: {
|
|||||||
ctx,
|
ctx,
|
||||||
pluginConfig,
|
pluginConfig,
|
||||||
modelCacheState,
|
modelCacheState,
|
||||||
|
backgroundManager,
|
||||||
modelFallbackControllerAccessor,
|
modelFallbackControllerAccessor,
|
||||||
isHookEnabled,
|
isHookEnabled,
|
||||||
safeHookEnabled,
|
safeHookEnabled,
|
||||||
|
|||||||
@@ -25,7 +25,7 @@ type LoopStateController = {
|
|||||||
setVerificationSessionID: (sessionID: string, verificationSessionID: string) => RalphLoopState | null
|
setVerificationSessionID: (sessionID: string, verificationSessionID: string) => RalphLoopState | null
|
||||||
restartAfterFailedVerification: (sessionID: string, messageCountAtStart?: number) => RalphLoopState | null
|
restartAfterFailedVerification: (sessionID: string, messageCountAtStart?: number) => RalphLoopState | null
|
||||||
}
|
}
|
||||||
type RalphLoopEventHandlerOptions = { directory: string; apiTimeoutMs: number; getTranscriptPath: (sessionID: string) => string | undefined; checkSessionExists?: RalphLoopOptions["checkSessionExists"]; sessionRecovery: SessionRecovery; loopState: LoopStateController }
|
type RalphLoopEventHandlerOptions = { directory: string; apiTimeoutMs: number; getTranscriptPath: (sessionID: string) => string | undefined; checkSessionExists?: RalphLoopOptions["checkSessionExists"]; backgroundManager?: RalphLoopOptions["backgroundManager"]; sessionRecovery: SessionRecovery; loopState: LoopStateController }
|
||||||
|
|
||||||
export function createRalphLoopEventHandler(
|
export function createRalphLoopEventHandler(
|
||||||
ctx: PluginInput,
|
ctx: PluginInput,
|
||||||
@@ -59,6 +59,15 @@ export function createRalphLoopEventHandler(
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
|
const hasRunningBackgroundTasks = options.backgroundManager
|
||||||
|
? options.backgroundManager.getTasksByParentSession(sessionID).some((task: { status: string }) => task.status === "running")
|
||||||
|
: false
|
||||||
|
|
||||||
|
if (hasRunningBackgroundTasks) {
|
||||||
|
log(`[${HOOK_NAME}] Skipped: background tasks running`, { sessionID })
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
const verificationSessionID = state.verification_pending
|
const verificationSessionID = state.verification_pending
|
||||||
? state.verification_session_id
|
? state.verification_session_id
|
||||||
: undefined
|
: undefined
|
||||||
|
|||||||
@@ -46,6 +46,7 @@ export function createRalphLoopHook(
|
|||||||
const getTranscriptPath = options?.getTranscriptPath ?? getDefaultTranscriptPath
|
const getTranscriptPath = options?.getTranscriptPath ?? getDefaultTranscriptPath
|
||||||
const apiTimeout = options?.apiTimeout ?? DEFAULT_API_TIMEOUT
|
const apiTimeout = options?.apiTimeout ?? DEFAULT_API_TIMEOUT
|
||||||
const checkSessionExists = options?.checkSessionExists
|
const checkSessionExists = options?.checkSessionExists
|
||||||
|
const backgroundManager = options?.backgroundManager
|
||||||
|
|
||||||
const loopState = createLoopStateController({
|
const loopState = createLoopStateController({
|
||||||
directory: ctx.directory,
|
directory: ctx.directory,
|
||||||
@@ -59,6 +60,7 @@ export function createRalphLoopHook(
|
|||||||
apiTimeoutMs: apiTimeout,
|
apiTimeoutMs: apiTimeout,
|
||||||
getTranscriptPath,
|
getTranscriptPath,
|
||||||
checkSessionExists,
|
checkSessionExists,
|
||||||
|
backgroundManager,
|
||||||
sessionRecovery,
|
sessionRecovery,
|
||||||
loopState,
|
loopState,
|
||||||
})
|
})
|
||||||
|
|||||||
@@ -22,4 +22,5 @@ export interface RalphLoopOptions {
|
|||||||
getTranscriptPath?: (sessionId: string) => string
|
getTranscriptPath?: (sessionId: string) => string
|
||||||
apiTimeout?: number
|
apiTimeout?: number
|
||||||
checkSessionExists?: (sessionId: string) => Promise<boolean>
|
checkSessionExists?: (sessionId: string) => Promise<boolean>
|
||||||
|
backgroundManager?: { getTasksByParentSession: (sessionId: string) => Array<{ status: string }> }
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,4 +1,5 @@
|
|||||||
import type { HookName, OhMyOpenCodeConfig } from "../../config"
|
import type { HookName, OhMyOpenCodeConfig } from "../../config"
|
||||||
|
import type { BackgroundManager } from "../../features/background-agent"
|
||||||
import type { ModelFallbackControllerAccessor } from "../../hooks/model-fallback"
|
import type { ModelFallbackControllerAccessor } from "../../hooks/model-fallback"
|
||||||
import type { PluginContext } from "../types"
|
import type { PluginContext } from "../types"
|
||||||
import type { ModelCacheState } from "../../plugin-state"
|
import type { ModelCacheState } from "../../plugin-state"
|
||||||
@@ -11,16 +12,18 @@ export function createCoreHooks(args: {
|
|||||||
ctx: PluginContext
|
ctx: PluginContext
|
||||||
pluginConfig: OhMyOpenCodeConfig
|
pluginConfig: OhMyOpenCodeConfig
|
||||||
modelCacheState: ModelCacheState
|
modelCacheState: ModelCacheState
|
||||||
|
backgroundManager: BackgroundManager
|
||||||
modelFallbackControllerAccessor?: ModelFallbackControllerAccessor
|
modelFallbackControllerAccessor?: ModelFallbackControllerAccessor
|
||||||
isHookEnabled: (hookName: HookName) => boolean
|
isHookEnabled: (hookName: HookName) => boolean
|
||||||
safeHookEnabled: boolean
|
safeHookEnabled: boolean
|
||||||
}) {
|
}) {
|
||||||
const { ctx, pluginConfig, modelCacheState, modelFallbackControllerAccessor, isHookEnabled, safeHookEnabled } = args
|
const { ctx, pluginConfig, modelCacheState, backgroundManager, modelFallbackControllerAccessor, isHookEnabled, safeHookEnabled } = args
|
||||||
|
|
||||||
const session = createSessionHooks({
|
const session = createSessionHooks({
|
||||||
ctx,
|
ctx,
|
||||||
pluginConfig,
|
pluginConfig,
|
||||||
modelCacheState,
|
modelCacheState,
|
||||||
|
backgroundManager,
|
||||||
modelFallbackControllerAccessor,
|
modelFallbackControllerAccessor,
|
||||||
isHookEnabled,
|
isHookEnabled,
|
||||||
safeHookEnabled,
|
safeHookEnabled,
|
||||||
|
|||||||
@@ -1,4 +1,5 @@
|
|||||||
import type { OhMyOpenCodeConfig, HookName } from "../../config"
|
import type { OhMyOpenCodeConfig, HookName } from "../../config"
|
||||||
|
import type { BackgroundManager } from "../../features/background-agent"
|
||||||
import type { ModelFallbackControllerAccessor } from "../../hooks/model-fallback"
|
import type { ModelFallbackControllerAccessor } from "../../hooks/model-fallback"
|
||||||
import type { ModelCacheState } from "../../plugin-state"
|
import type { ModelCacheState } from "../../plugin-state"
|
||||||
import type { PluginContext } from "../types"
|
import type { PluginContext } from "../types"
|
||||||
@@ -70,11 +71,12 @@ export function createSessionHooks(args: {
|
|||||||
ctx: PluginContext
|
ctx: PluginContext
|
||||||
pluginConfig: OhMyOpenCodeConfig
|
pluginConfig: OhMyOpenCodeConfig
|
||||||
modelCacheState: ModelCacheState
|
modelCacheState: ModelCacheState
|
||||||
|
backgroundManager: BackgroundManager
|
||||||
modelFallbackControllerAccessor?: ModelFallbackControllerAccessor
|
modelFallbackControllerAccessor?: ModelFallbackControllerAccessor
|
||||||
isHookEnabled: (hookName: HookName) => boolean
|
isHookEnabled: (hookName: HookName) => boolean
|
||||||
safeHookEnabled: boolean
|
safeHookEnabled: boolean
|
||||||
}): SessionHooks {
|
}): SessionHooks {
|
||||||
const { ctx, pluginConfig, modelCacheState, modelFallbackControllerAccessor, isHookEnabled, safeHookEnabled } = args
|
const { ctx, pluginConfig, modelCacheState, backgroundManager, modelFallbackControllerAccessor, isHookEnabled, safeHookEnabled } = args
|
||||||
const safeHook = <T>(hookName: HookName, factory: () => T): T | null =>
|
const safeHook = <T>(hookName: HookName, factory: () => T): T | null =>
|
||||||
safeCreateHook(hookName, factory, { enabled: safeHookEnabled })
|
safeCreateHook(hookName, factory, { enabled: safeHookEnabled })
|
||||||
|
|
||||||
@@ -211,6 +213,7 @@ export function createSessionHooks(args: {
|
|||||||
createRalphLoopHook(ctx, {
|
createRalphLoopHook(ctx, {
|
||||||
config: pluginConfig.ralph_loop,
|
config: pluginConfig.ralph_loop,
|
||||||
checkSessionExists: async (sessionId) => await sessionExists(sessionId),
|
checkSessionExists: async (sessionId) => await sessionExists(sessionId),
|
||||||
|
backgroundManager,
|
||||||
}))
|
}))
|
||||||
: null
|
: null
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user