luna/oh-my-opencode
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: address Oracle + Cubic review feedback for background-agent refactoring

Browse Source 
- Revert getMessageDir to original join(MESSAGE_STORAGE, sessionID) behavior
- Fix dead subagentSessions.delete by capturing previousSessionID before tryFallbackRetry
- Add .unref() to process cleanup setTimeout to prevent 6s hang on Ctrl-C
- Add missing isUnstableAgent to fallback retry input mapping
- Fix process-cleanup tests to use exit listener instead of SIGINT at index 0
- Swap test filenames in compaction-aware-message-resolver to exercise skip logic correctly
This commit is contained in:
YeonGyu-Kim
2026-02-22 12:14:26 +09:00
parent ed43cd4c85
commit d1e5bd63c1
5 changed files with 21 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/features/background-agent/compaction-aware-message-resolver.test.ts
+4 -4
View File
@@ -96,8 +96,8 @@ describe("findNearestMessageExcludingCompaction", () => {
agent: "sisyphus",
model: { providerID: "anthropic", modelID: "claude-opus-4-6" },
}
writeFileSync(join(tempDir, "001.json"), JSON.stringify(compactionMessage))
writeFileSync(join(tempDir, "002.json"), JSON.stringify(validMessage))
writeFileSync(join(tempDir, "002.json"), JSON.stringify(compactionMessage))
writeFileSync(join(tempDir, "001.json"), JSON.stringify(validMessage))
// when
const result = findNearestMessageExcludingCompaction(tempDir)
@@ -155,8 +155,8 @@ describe("findNearestMessageExcludingCompaction", () => {
agent: "oracle",
model: { providerID: "google", modelID: "gemini-2-flash" },
}
writeFileSync(join(tempDir, "001.json"), invalidJson)
writeFileSync(join(tempDir, "002.json"), JSON.stringify(validMessage))
writeFileSync(join(tempDir, "002.json"), invalidJson)
writeFileSync(join(tempDir, "001.json"), JSON.stringify(validMessage))
// when
const result = findNearestMessageExcludingCompaction(tempDir)