test: make unsafe test coercion explicit
Move test coercion out of a hidden global and require each test to import the helper so review tools and runtime scripts can see the unsafe boundary. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This commit is contained in:
@@ -11,6 +11,7 @@ import {
|
||||
injectHookMessage,
|
||||
} from "./injector"
|
||||
import { getCompactionPartStorageDir } from "../../shared/compaction-marker"
|
||||
import { unsafeTestValue } from "../../../test-support/unsafe-test-value"
|
||||
|
||||
//#region Mocks
|
||||
|
||||
@@ -73,7 +74,7 @@ describe("findNearestMessageWithFieldsFromSDK", () => {
|
||||
{ info: { agent: "sisyphus", model: { providerID: "anthropic", modelID: "claude-opus-4" } } },
|
||||
])
|
||||
|
||||
const result = await findNearestMessageWithFieldsFromSDK(testCoerce(mockClient), "ses_123")
|
||||
const result = await findNearestMessageWithFieldsFromSDK(unsafeTestValue(mockClient), "ses_123")
|
||||
|
||||
expect(result).toEqual({
|
||||
agent: "sisyphus",
|
||||
@@ -87,7 +88,7 @@ describe("findNearestMessageWithFieldsFromSDK", () => {
|
||||
{ info: { agent: "sisyphus", providerID: "openai", modelID: "gpt-5" } },
|
||||
])
|
||||
|
||||
const result = await findNearestMessageWithFieldsFromSDK(testCoerce(mockClient), "ses_123")
|
||||
const result = await findNearestMessageWithFieldsFromSDK(unsafeTestValue(mockClient), "ses_123")
|
||||
|
||||
expect(result).toEqual({
|
||||
agent: "sisyphus",
|
||||
@@ -102,7 +103,7 @@ describe("findNearestMessageWithFieldsFromSDK", () => {
|
||||
{ id: "msg_new", info: { agent: "new-agent", model: { providerID: "new", modelID: "model" }, time: { created: 20 } } },
|
||||
])
|
||||
|
||||
const result = await findNearestMessageWithFieldsFromSDK(testCoerce(mockClient), "ses_123")
|
||||
const result = await findNearestMessageWithFieldsFromSDK(unsafeTestValue(mockClient), "ses_123")
|
||||
|
||||
expect(result?.agent).toBe("new-agent")
|
||||
})
|
||||
@@ -112,7 +113,7 @@ describe("findNearestMessageWithFieldsFromSDK", () => {
|
||||
{ info: { agent: "partial-agent" } },
|
||||
])
|
||||
|
||||
const result = await findNearestMessageWithFieldsFromSDK(testCoerce(mockClient), "ses_123")
|
||||
const result = await findNearestMessageWithFieldsFromSDK(unsafeTestValue(mockClient), "ses_123")
|
||||
|
||||
expect(result?.agent).toBe("partial-agent")
|
||||
})
|
||||
@@ -123,7 +124,7 @@ describe("findNearestMessageWithFieldsFromSDK", () => {
|
||||
{ info: {} },
|
||||
])
|
||||
|
||||
const result = await findNearestMessageWithFieldsFromSDK(testCoerce(mockClient), "ses_123")
|
||||
const result = await findNearestMessageWithFieldsFromSDK(unsafeTestValue(mockClient), "ses_123")
|
||||
|
||||
expect(result).toBeNull()
|
||||
})
|
||||
@@ -131,7 +132,7 @@ describe("findNearestMessageWithFieldsFromSDK", () => {
|
||||
it("returns null when messages array is empty", async () => {
|
||||
const mockClient = createMockClient([])
|
||||
|
||||
const result = await findNearestMessageWithFieldsFromSDK(testCoerce(mockClient), "ses_123")
|
||||
const result = await findNearestMessageWithFieldsFromSDK(unsafeTestValue(mockClient), "ses_123")
|
||||
|
||||
expect(result).toBeNull()
|
||||
})
|
||||
@@ -145,7 +146,7 @@ describe("findNearestMessageWithFieldsFromSDK", () => {
|
||||
},
|
||||
}
|
||||
|
||||
const result = await findNearestMessageWithFieldsFromSDK(testCoerce(mockClient), "ses_123")
|
||||
const result = await findNearestMessageWithFieldsFromSDK(unsafeTestValue(mockClient), "ses_123")
|
||||
|
||||
expect(result).toBeNull()
|
||||
})
|
||||
@@ -161,7 +162,7 @@ describe("findNearestMessageWithFieldsFromSDK", () => {
|
||||
},
|
||||
])
|
||||
|
||||
const result = await findNearestMessageWithFieldsFromSDK(testCoerce(mockClient), "ses_123")
|
||||
const result = await findNearestMessageWithFieldsFromSDK(unsafeTestValue(mockClient), "ses_123")
|
||||
|
||||
expect(result?.tools).toEqual({ edit: true, write: false })
|
||||
})
|
||||
@@ -172,7 +173,7 @@ describe("findNearestMessageWithFieldsFromSDK", () => {
|
||||
{ id: "msg_older", info: { agent: "newest-by-time", model: { providerID: "openai", modelID: "gpt-5" }, time: { created: 100 } } },
|
||||
])
|
||||
|
||||
const result = await findNearestMessageWithFieldsFromSDK(testCoerce(mockClient), "ses_123")
|
||||
const result = await findNearestMessageWithFieldsFromSDK(unsafeTestValue(mockClient), "ses_123")
|
||||
|
||||
expect(result?.agent).toBe("newest-by-time")
|
||||
})
|
||||
@@ -190,7 +191,7 @@ describe("findNearestMessageWithFieldsFromSDK", () => {
|
||||
},
|
||||
])
|
||||
|
||||
const result = await findNearestMessageWithFieldsFromSDK(testCoerce(mockClient), "ses_123")
|
||||
const result = await findNearestMessageWithFieldsFromSDK(unsafeTestValue(mockClient), "ses_123")
|
||||
|
||||
expect(result?.agent).toBe("sisyphus")
|
||||
})
|
||||
@@ -252,7 +253,7 @@ describe("findFirstMessageWithAgentFromSDK", () => {
|
||||
{ info: { agent: "second-agent" } },
|
||||
])
|
||||
|
||||
const result = await findFirstMessageWithAgentFromSDK(testCoerce(mockClient), "ses_123")
|
||||
const result = await findFirstMessageWithAgentFromSDK(unsafeTestValue(mockClient), "ses_123")
|
||||
|
||||
expect(result).toBe("first-agent")
|
||||
})
|
||||
@@ -263,7 +264,7 @@ describe("findFirstMessageWithAgentFromSDK", () => {
|
||||
{ id: "msg_early", info: { agent: "earliest-agent", time: { created: 10 } } },
|
||||
])
|
||||
|
||||
const result = await findFirstMessageWithAgentFromSDK(testCoerce(mockClient), "ses_123")
|
||||
const result = await findFirstMessageWithAgentFromSDK(unsafeTestValue(mockClient), "ses_123")
|
||||
|
||||
expect(result).toBe("earliest-agent")
|
||||
})
|
||||
@@ -274,7 +275,7 @@ describe("findFirstMessageWithAgentFromSDK", () => {
|
||||
{ id: "msg_real", info: { agent: "sisyphus", time: { created: 20 } } },
|
||||
])
|
||||
|
||||
const result = await findFirstMessageWithAgentFromSDK(testCoerce(mockClient), "ses_123")
|
||||
const result = await findFirstMessageWithAgentFromSDK(unsafeTestValue(mockClient), "ses_123")
|
||||
|
||||
expect(result).toBe("sisyphus")
|
||||
})
|
||||
@@ -285,7 +286,7 @@ describe("findFirstMessageWithAgentFromSDK", () => {
|
||||
{ info: { agent: "first-real-agent" } },
|
||||
])
|
||||
|
||||
const result = await findFirstMessageWithAgentFromSDK(testCoerce(mockClient), "ses_123")
|
||||
const result = await findFirstMessageWithAgentFromSDK(unsafeTestValue(mockClient), "ses_123")
|
||||
|
||||
expect(result).toBe("first-real-agent")
|
||||
})
|
||||
@@ -296,7 +297,7 @@ describe("findFirstMessageWithAgentFromSDK", () => {
|
||||
{ info: {} },
|
||||
])
|
||||
|
||||
const result = await findFirstMessageWithAgentFromSDK(testCoerce(mockClient), "ses_123")
|
||||
const result = await findFirstMessageWithAgentFromSDK(unsafeTestValue(mockClient), "ses_123")
|
||||
|
||||
expect(result).toBeNull()
|
||||
})
|
||||
@@ -310,7 +311,7 @@ describe("findFirstMessageWithAgentFromSDK", () => {
|
||||
},
|
||||
}
|
||||
|
||||
const result = await findFirstMessageWithAgentFromSDK(testCoerce(mockClient), "ses_123")
|
||||
const result = await findFirstMessageWithAgentFromSDK(unsafeTestValue(mockClient), "ses_123")
|
||||
|
||||
expect(result).toBeNull()
|
||||
})
|
||||
|
||||
Reference in New Issue
Block a user