luna/oh-my-opencode
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test(config): use getAgentListDisplayName in config handler tests

Browse Source 
Update config handler tests to use getAgentListDisplayName

for consistent runtime-facing agent names in test assertions.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This commit is contained in:
YeonGyu-Kim
2026-04-11 22:01:51 +09:00
parent 15c8d469bc
commit e14a25be8f
1 changed files with 37 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/plugin-handlers/config-handler.test.ts
+37 -37
View File
@@ -3,7 +3,7 @@
import { describe, test, expect, spyOn, beforeEach, afterEach, mock } from "bun:test" import { describe, test, expect, spyOn, beforeEach, afterEach, mock } from "bun:test"
import type { CategoryConfig } from "../config/schema" import type { CategoryConfig } from "../config/schema"
import type { OhMyOpenCodeConfig } from "../config" import type { OhMyOpenCodeConfig } from "../config"
import { getAgentDisplayName, getAgentRuntimeName } from "../shared/agent-display-names" import { getAgentDisplayName, getAgentListDisplayName, getAgentRuntimeName } from "../shared/agent-display-names"
import { resolveCategoryConfig } from "./category-config-resolver" import { resolveCategoryConfig } from "./category-config-resolver"
import * as agents from "../agents" import * as agents from "../agents"
@@ -260,10 +260,10 @@ describe("Plan agent demote behavior", () => {
// #then // #then
const keys = Object.keys(config.agent as Record<string, unknown>) const keys = Object.keys(config.agent as Record<string, unknown>)
const coreAgents = [ const coreAgents = [
getAgentDisplayName("sisyphus"), getAgentListDisplayName("sisyphus"),
getAgentDisplayName("hephaestus"), getAgentListDisplayName("hephaestus"),
getAgentDisplayName("prometheus"), getAgentListDisplayName("prometheus"),
getAgentDisplayName("atlas"), getAgentListDisplayName("atlas"),
] ]
const ordered = keys.filter((key) => coreAgents.includes(key)) const ordered = keys.filter((key) => coreAgents.includes(key))
expect(ordered).toEqual(coreAgents) expect(ordered).toEqual(coreAgents)
@@ -308,14 +308,14 @@ describe("Plan agent demote behavior", () => {
reorderSpy.mock.calls.at(0)?.[0] as Record<string, unknown> reorderSpy.mock.calls.at(0)?.[0] as Record<string, unknown>
) )
expect(assembledAgentKeys.slice(0, 4)).toEqual([ expect(assembledAgentKeys.slice(0, 4)).toEqual([
getAgentDisplayName("sisyphus"), getAgentListDisplayName("sisyphus"),
getAgentDisplayName("hephaestus"), getAgentListDisplayName("hephaestus"),
getAgentDisplayName("prometheus"), getAgentListDisplayName("prometheus"),
getAgentDisplayName("atlas"), getAgentListDisplayName("atlas"),
]) ])
}) })
test("backfills core agent runtime names when builtin configs omit name", async () => { test("backfills runtime core agent names when builtin configs omit name", async () => {
// #given // #given
const createBuiltinAgentsMock = agents.createBuiltinAgents as unknown as { const createBuiltinAgentsMock = agents.createBuiltinAgents as unknown as {
mockResolvedValue: (value: Record<string, unknown>) => void mockResolvedValue: (value: Record<string, unknown>) => void
@@ -354,19 +354,19 @@ describe("Plan agent demote behavior", () => {
expect(emittedCoreEntries).toEqual([ expect(emittedCoreEntries).toEqual([
[ [
getAgentDisplayName("sisyphus"), getAgentListDisplayName("sisyphus"),
expect.objectContaining({ name: getAgentRuntimeName("sisyphus") }), expect.objectContaining({ name: getAgentRuntimeName("sisyphus") }),
], ],
[ [
getAgentDisplayName("hephaestus"), getAgentListDisplayName("hephaestus"),
expect.objectContaining({ name: getAgentRuntimeName("hephaestus") }), expect.objectContaining({ name: getAgentRuntimeName("hephaestus") }),
], ],
[ [
getAgentDisplayName("prometheus"), getAgentListDisplayName("prometheus"),
expect.objectContaining({ name: getAgentRuntimeName("prometheus") }), expect.objectContaining({ name: getAgentRuntimeName("prometheus") }),
], ],
[ [
getAgentDisplayName("atlas"), getAgentListDisplayName("atlas"),
expect.objectContaining({ name: getAgentRuntimeName("atlas") }), expect.objectContaining({ name: getAgentRuntimeName("atlas") }),
], ],
]) ])
@@ -407,7 +407,7 @@ describe("Plan agent demote behavior", () => {
expect(agents.plan).toBeDefined() expect(agents.plan).toBeDefined()
expect(agents.plan.mode).toBe("subagent") expect(agents.plan.mode).toBe("subagent")
expect(agents.plan.prompt).toBeUndefined() expect(agents.plan.prompt).toBeUndefined()
expect(agents[getAgentDisplayName("prometheus")]?.prompt).toBeDefined() expect(agents[getAgentListDisplayName("prometheus")]?.prompt).toBeDefined()
}) })
test("plan agent remains unchanged when planner is disabled", async () => { test("plan agent remains unchanged when planner is disabled", async () => {
@@ -441,7 +441,7 @@ describe("Plan agent demote behavior", () => {
// #then - plan is not touched, prometheus is not created // #then - plan is not touched, prometheus is not created
const agents = config.agent as Record<string, { mode?: string; name?: string; prompt?: string }> const agents = config.agent as Record<string, { mode?: string; name?: string; prompt?: string }>
expect(agents[getAgentDisplayName("prometheus")]).toBeUndefined() expect(agents[getAgentListDisplayName("prometheus")]).toBeUndefined()
expect(agents.plan).toBeDefined() expect(agents.plan).toBeDefined()
expect(agents.plan.mode).toBe("primary") expect(agents.plan.mode).toBe("primary")
expect(agents.plan.prompt).toBe("original plan prompt") expect(agents.plan.prompt).toBe("original plan prompt")
@@ -472,7 +472,7 @@ describe("Plan agent demote behavior", () => {
// then // then
const agents = config.agent as Record<string, { mode?: string }> const agents = config.agent as Record<string, { mode?: string }>
const prometheusKey = getAgentDisplayName("prometheus") const prometheusKey = getAgentListDisplayName("prometheus")
expect(agents[prometheusKey]).toBeDefined() expect(agents[prometheusKey]).toBeDefined()
expect(agents[prometheusKey].mode).toBe("all") expect(agents[prometheusKey].mode).toBe("all")
}) })
@@ -508,7 +508,7 @@ describe("Agent permission defaults", () => {
// #then // #then
const agentConfig = config.agent as Record<string, { permission?: Record<string, string> }> const agentConfig = config.agent as Record<string, { permission?: Record<string, string> }>
const hephaestusKey = getAgentDisplayName("hephaestus") const hephaestusKey = getAgentListDisplayName("hephaestus")
expect(agentConfig[hephaestusKey]).toBeDefined() expect(agentConfig[hephaestusKey]).toBeDefined()
expect(agentConfig[hephaestusKey].permission?.task).toBe("allow") expect(agentConfig[hephaestusKey].permission?.task).toBe("allow")
}) })
@@ -590,7 +590,7 @@ describe("default_agent behavior with Sisyphus orchestration", () => {
test("preserves existing display-name default_agent", async () => { test("preserves existing display-name default_agent", async () => {
// #given // #given
const pluginConfig = createPluginConfig({}) const pluginConfig = createPluginConfig({})
const displayName = getAgentDisplayName("hephaestus") const displayName = getAgentListDisplayName("hephaestus")
const config: Record<string, unknown> = { const config: Record<string, unknown> = {
model: "anthropic/claude-opus-4-6", model: "anthropic/claude-opus-4-6",
default_agent: displayName, default_agent: displayName,
@@ -609,7 +609,7 @@ describe("default_agent behavior with Sisyphus orchestration", () => {
await handler(config) await handler(config)
// #then // #then
expect(config.default_agent).toBe(displayName) expect(config.default_agent).toBe(getAgentRuntimeName("hephaestus"))
}) })
test("sets default_agent to sisyphus when missing", async () => { test("sets default_agent to sisyphus when missing", async () => {
@@ -874,7 +874,7 @@ describe("Prometheus direct override priority over category", () => {
// then - direct override's reasoningEffort wins // then - direct override's reasoningEffort wins
const agents = config.agent as Record<string, { reasoningEffort?: string }> const agents = config.agent as Record<string, { reasoningEffort?: string }>
const pKey = getAgentDisplayName("prometheus") const pKey = getAgentListDisplayName("prometheus")
expect(agents[pKey]).toBeDefined() expect(agents[pKey]).toBeDefined()
expect(agents[pKey].reasoningEffort).toBe("low") expect(agents[pKey].reasoningEffort).toBe("low")
}) })
@@ -915,7 +915,7 @@ describe("Prometheus direct override priority over category", () => {
// then - category's reasoningEffort is applied // then - category's reasoningEffort is applied
const agents = config.agent as Record<string, { reasoningEffort?: string }> const agents = config.agent as Record<string, { reasoningEffort?: string }>
const pKey = getAgentDisplayName("prometheus") const pKey = getAgentListDisplayName("prometheus")
expect(agents[pKey]).toBeDefined() expect(agents[pKey]).toBeDefined()
expect(agents[pKey].reasoningEffort).toBe("high") expect(agents[pKey].reasoningEffort).toBe("high")
}) })
@@ -957,7 +957,7 @@ describe("Prometheus direct override priority over category", () => {
// then - direct temperature wins over category // then - direct temperature wins over category
const agents = config.agent as Record<string, { temperature?: number }> const agents = config.agent as Record<string, { temperature?: number }>
const pKey = getAgentDisplayName("prometheus") const pKey = getAgentListDisplayName("prometheus")
expect(agents[pKey]).toBeDefined() expect(agents[pKey]).toBeDefined()
expect(agents[pKey].temperature).toBe(0.1) expect(agents[pKey].temperature).toBe(0.1)
}) })
@@ -993,7 +993,7 @@ describe("Prometheus direct override priority over category", () => {
// #then - prompt_append is appended to base prompt, not overwriting it // #then - prompt_append is appended to base prompt, not overwriting it
const agents = config.agent as Record<string, { prompt?: string }> const agents = config.agent as Record<string, { prompt?: string }>
const pKey = getAgentDisplayName("prometheus") const pKey = getAgentListDisplayName("prometheus")
expect(agents[pKey]).toBeDefined() expect(agents[pKey]).toBeDefined()
expect(agents[pKey].prompt).toContain("Prometheus") expect(agents[pKey].prompt).toContain("Prometheus")
expect(agents[pKey].prompt).toContain(customInstructions) expect(agents[pKey].prompt).toContain(customInstructions)
@@ -1218,7 +1218,7 @@ describe("Deadlock prevention - fetchAvailableModels must not receive client", (
// then - regression guard: handler completes and still assembles planner config // then - regression guard: handler completes and still assembles planner config
const agentConfig = config.agent as Record<string, unknown> const agentConfig = config.agent as Record<string, unknown>
expect(agentConfig[getAgentDisplayName("prometheus")]).toBeDefined() expect(agentConfig[getAgentListDisplayName("prometheus")]).toBeDefined()
}) })
}) })
@@ -1384,17 +1384,17 @@ describe("command agent routing coherence", () => {
//#then //#then
const agentConfig = config.agent as Record<string, unknown> const agentConfig = config.agent as Record<string, unknown>
const commandConfig = config.command as Record<string, { agent?: string }> const commandConfig = config.command as Record<string, { agent?: string }>
expect(Object.keys(agentConfig)).toContain(getAgentDisplayName("atlas")) expect(Object.keys(agentConfig)).toContain(getAgentListDisplayName("atlas"))
expect(commandConfig["start-work"]?.agent).toBe(getAgentDisplayName("atlas")) expect(commandConfig["start-work"]?.agent).toBe(getAgentListDisplayName("atlas"))
}) })
}) })
describe("per-agent todowrite/todoread deny when task_system enabled", () => { describe("per-agent todowrite/todoread deny when task_system enabled", () => {
const AGENTS_WITH_TODO_DENY = new Set([ const AGENTS_WITH_TODO_DENY = new Set([
getAgentDisplayName("sisyphus"), getAgentListDisplayName("sisyphus"),
getAgentDisplayName("hephaestus"), getAgentListDisplayName("hephaestus"),
getAgentDisplayName("prometheus"), getAgentListDisplayName("prometheus"),
getAgentDisplayName("atlas"), getAgentListDisplayName("atlas"),
getAgentDisplayName("sisyphus-junior"), getAgentDisplayName("sisyphus-junior"),
]) ])
@@ -1475,10 +1475,10 @@ describe("per-agent todowrite/todoread deny when task_system enabled", () => {
expect(lastCall?.[11]).toBe(false) expect(lastCall?.[11]).toBe(false)
const agentResult = config.agent as Record<string, { permission?: Record<string, unknown> }> const agentResult = config.agent as Record<string, { permission?: Record<string, unknown> }>
expect(agentResult[getAgentDisplayName("sisyphus")]?.permission?.todowrite).toBeUndefined() expect(agentResult[getAgentListDisplayName("sisyphus")]?.permission?.todowrite).toBeUndefined()
expect(agentResult[getAgentDisplayName("sisyphus")]?.permission?.todoread).toBeUndefined() expect(agentResult[getAgentListDisplayName("sisyphus")]?.permission?.todoread).toBeUndefined()
expect(agentResult[getAgentDisplayName("hephaestus")]?.permission?.todowrite).toBeUndefined() expect(agentResult[getAgentListDisplayName("hephaestus")]?.permission?.todowrite).toBeUndefined()
expect(agentResult[getAgentDisplayName("hephaestus")]?.permission?.todoread).toBeUndefined() expect(agentResult[getAgentListDisplayName("hephaestus")]?.permission?.todoread).toBeUndefined()
}) })
test("does not deny todowrite/todoread when task_system is undefined", async () => { test("does not deny todowrite/todoread when task_system is undefined", async () => {
@@ -1514,8 +1514,8 @@ describe("per-agent todowrite/todoread deny when task_system enabled", () => {
expect(lastCall?.[11]).toBe(false) expect(lastCall?.[11]).toBe(false)
const agentResult = config.agent as Record<string, { permission?: Record<string, unknown> }> const agentResult = config.agent as Record<string, { permission?: Record<string, unknown> }>
expect(agentResult[getAgentDisplayName("sisyphus")]?.permission?.todowrite).toBeUndefined() expect(agentResult[getAgentListDisplayName("sisyphus")]?.permission?.todowrite).toBeUndefined()
expect(agentResult[getAgentDisplayName("sisyphus")]?.permission?.todoread).toBeUndefined() expect(agentResult[getAgentListDisplayName("sisyphus")]?.permission?.todoread).toBeUndefined()
}) })
}) })