luna/oh-my-opencode
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(council): increase archive ID entropy and remove unused toolContext param

Browse Source 
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This commit is contained in:
ismeth
2026-03-02 00:34:53 +01:00
committed by YeonGyu-Kim
parent 3d36f6c5d8
commit e15ce7b279
4 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/agents/athena/constants.ts
+1 -1
View File
@@ -3,5 +3,5 @@ export const COUNCIL_DEFAULTS = {
BACKGROUND_WAIT_TIMEOUT_MS: 30000, BACKGROUND_WAIT_TIMEOUT_MS: 30000,
STUCK_THRESHOLD_SECONDS: 120, STUCK_THRESHOLD_SECONDS: 120,
MEMBER_MAX_RUNNING_SECONDS: 1800, MEMBER_MAX_RUNNING_SECONDS: 1800,
ARCHIVE_ID_BYTES: 2, ARCHIVE_ID_BYTES: 8,
} as const } as const
src/tools/council-archive/council-flow.integration.test.ts
+1 -1
View File
@@ -117,7 +117,7 @@ describe("council archive integration flow", () => {
) )
const result: CouncilFinalizeResult = JSON.parse(extractJson(resultStr)) const result: CouncilFinalizeResult = JSON.parse(extractJson(resultStr))
expect(result.archive_dir).toMatch(/\.sisyphus\/athena\/council-test-[a-f0-9]{4}$/) expect(result.archive_dir).toMatch(/\.sisyphus\/athena\/council-test-[a-f0-9]{16}$/)
expect(result.meta_file).toMatch(/meta\.yaml$/) expect(result.meta_file).toMatch(/meta\.yaml$/)
expect(result.members).toHaveLength(3) expect(result.members).toHaveLength(3)
src/tools/council-archive/create-council-finalize.test.ts
+3 -3
View File
@@ -73,8 +73,8 @@ describe("createCouncilFinalize", () => {
) )
const result: CouncilFinalizeResult = JSON.parse(extractJson(resultStr)) const result: CouncilFinalizeResult = JSON.parse(extractJson(resultStr))
expect(result.archive_dir).toMatch(/\.sisyphus\/athena\/council-test-[a-f0-9]{4}$/) expect(result.archive_dir).toMatch(/\.sisyphus\/athena\/council-test-[a-f0-9]{16}$/)
expect(result.meta_file).toMatch(/\.sisyphus\/athena\/council-test-[a-f0-9]{4}\/meta\.yaml$/) expect(result.meta_file).toMatch(/\.sisyphus\/athena\/council-test-[a-f0-9]{16}\/meta\.yaml$/)
expect(result.members).toHaveLength(3) expect(result.members).toHaveLength(3)
for (let i = 0; i < agents.length; i++) { for (let i = 0; i < agents.length; i++) {
@@ -517,7 +517,7 @@ describe("createCouncilFinalize", () => {
) )
const result: CouncilFinalizeResult = JSON.parse(extractJson(resultStr)) const result: CouncilFinalizeResult = JSON.parse(extractJson(resultStr))
expect(result.archive_dir).toMatch(/^\.sisyphus\/athena\/council-unnamed-[a-f0-9]{4}$/) expect(result.archive_dir).toMatch(/^\.sisyphus\/athena\/council-unnamed-[a-f0-9]{16}$/)
}) })
}) })
}) })
src/tools/council-archive/create-council-finalize.ts
+1 -4
View File
@@ -13,9 +13,6 @@ import {
} from "../../agents/athena" } from "../../agents/athena"
import type { CouncilFinalizeArgs, CouncilMemberResult, CouncilFinalizeResult } from "./types" import type { CouncilFinalizeArgs, CouncilMemberResult, CouncilFinalizeResult } from "./types"
type CouncilFinalizeToolContext = {
sessionID?: string
}
export function createCouncilFinalize( export function createCouncilFinalize(
basePath?: string, basePath?: string,
): ToolDefinition { ): ToolDefinition {
@@ -34,7 +31,7 @@ export function createCouncilFinalize(
question: tool.schema.string().optional().describe("Original user question that triggered the council"), question: tool.schema.string().optional().describe("Original user question that triggered the council"),
prompt_file: tool.schema.string().optional().describe("Path to the council prompt temp file (will be moved into the archive)"), prompt_file: tool.schema.string().optional().describe("Path to the council prompt temp file (will be moved into the archive)"),
}, },
async execute(args: CouncilFinalizeArgs, toolContext: CouncilFinalizeToolContext) { async execute(args: CouncilFinalizeArgs, toolContext) {
const resolvedIntent = resolveCouncilIntent(args.intent) const resolvedIntent = resolveCouncilIntent(args.intent)
if (!resolvedIntent) { if (!resolvedIntent) {
return `Invalid intent: "${args.intent}". Valid intents: ${getValidCouncilIntents().join(", ")}.` return `Invalid intent: "${args.intent}". Valid intents: ${getValidCouncilIntents().join(", ")}.`