fix(model-resolution): normalize model format and remove dead config flag
This commit is contained in:
@@ -0,0 +1,25 @@
|
||||
import { describe, expect, test } from "bun:test"
|
||||
import { resolveModelPipeline } from "./model-resolution-pipeline"
|
||||
|
||||
describe("resolveModelPipeline", () => {
|
||||
test("does not return unused explicit user config metadata in override result", () => {
|
||||
// given
|
||||
const result = resolveModelPipeline({
|
||||
intent: {
|
||||
userModel: "openai/gpt-5.3-codex",
|
||||
},
|
||||
constraints: {
|
||||
availableModels: new Set<string>(),
|
||||
},
|
||||
})
|
||||
|
||||
// when
|
||||
const hasExplicitUserConfigField = result
|
||||
? Object.prototype.hasOwnProperty.call(result, "explicitUserConfig")
|
||||
: false
|
||||
|
||||
// then
|
||||
expect(result).toEqual({ model: "openai/gpt-5.3-codex", provenance: "override" })
|
||||
expect(hasExplicitUserConfigField).toBe(false)
|
||||
})
|
||||
})
|
||||
@@ -34,7 +34,6 @@ export type ModelResolutionResult = {
|
||||
variant?: string
|
||||
attempted?: string[]
|
||||
reason?: string
|
||||
explicitUserConfig?: boolean
|
||||
}
|
||||
|
||||
|
||||
@@ -56,7 +55,7 @@ export function resolveModelPipeline(
|
||||
const normalizedUserModel = normalizeModel(intent?.userModel)
|
||||
if (normalizedUserModel) {
|
||||
log("Model resolved via config override", { model: normalizedUserModel })
|
||||
return { model: normalizedUserModel, provenance: "override", explicitUserConfig: true }
|
||||
return { model: normalizedUserModel, provenance: "override" }
|
||||
}
|
||||
|
||||
const normalizedCategoryDefault = normalizeModel(intent?.categoryDefaultModel)
|
||||
|
||||
Reference in New Issue
Block a user