refactor(hooks): split session-notification and unstable-agent-babysitter

Extract notification and babysitter logic:
- session-notification-formatting.ts, session-notification-scheduler.ts
- session-notification-sender.ts, session-todo-status.ts
- task-message-analyzer.ts: message analysis for babysitter hook

src/hooks/session-notification.ts

@@ -1,22 +1,16 @@
 import type { PluginInput } from "@opencode-ai/plugin"
-import { platform } from "os"
 import { subagentSessions, getMainSessionID } from "../features/claude-code-session-state"
 import {
-  getOsascriptPath,
-  getNotifySendPath,
-  getPowershellPath,
-  getAfplayPath,
-  getPaplayPath,
-  getAplayPath,
   startBackgroundCheck,
 } from "./session-notification-utils"
-
-interface Todo {
-  content: string
-  status: string
-  priority: string
-  id: string
-}
+import {
+  detectPlatform,
+  getDefaultSoundPath,
+  playSessionNotificationSound,
+  sendSessionNotification,
+} from "./session-notification-sender"
+import { hasIncompleteTodos } from "./session-todo-status"
+import { createIdleNotificationScheduler } from "./session-notification-scheduler"
 
 interface SessionNotificationConfig {
   title?: string
@@ -30,115 +24,6 @@ interface SessionNotificationConfig {
   /** Maximum number of sessions to track before cleanup (default: 100) */
   maxTrackedSessions?: number
 }
-
-type Platform = "darwin" | "linux" | "win32" | "unsupported"
-
-function detectPlatform(): Platform {
-  const p = platform()
-  if (p === "darwin" || p === "linux" || p === "win32") return p
-  return "unsupported"
-}
-
-function getDefaultSoundPath(p: Platform): string {
-  switch (p) {
-    case "darwin":
-      return "/System/Library/Sounds/Glass.aiff"
-    case "linux":
-      return "/usr/share/sounds/freedesktop/stereo/complete.oga"
-    case "win32":
-      return "C:\\Windows\\Media\\notify.wav"
-    default:
-      return ""
-  }
-}
-
-async function sendNotification(
-  ctx: PluginInput,
-  p: Platform,
-  title: string,
-  message: string
-): Promise<void> {
-  switch (p) {
-    case "darwin": {
-      const osascriptPath = await getOsascriptPath()
-      if (!osascriptPath) return
-
-      const esTitle = title.replace(/\\/g, "\\\\").replace(/"/g, '\\"')
-      const esMessage = message.replace(/\\/g, "\\\\").replace(/"/g, '\\"')
-      await ctx.$`${osascriptPath} -e ${"display notification \"" + esMessage + "\" with title \"" + esTitle + "\""}`.catch(() => {})
-      break
-    }
-    case "linux": {
-      const notifySendPath = await getNotifySendPath()
-      if (!notifySendPath) return
-
-      await ctx.$`${notifySendPath} ${title} ${message} 2>/dev/null`.catch(() => {})
-      break
-    }
-    case "win32": {
-      const powershellPath = await getPowershellPath()
-      if (!powershellPath) return
-
-      const psTitle = title.replace(/'/g, "''")
-      const psMessage = message.replace(/'/g, "''")
-      const toastScript = `
-[Windows.UI.Notifications.ToastNotificationManager, Windows.UI.Notifications, ContentType = WindowsRuntime] | Out-Null
-$Template = [Windows.UI.Notifications.ToastNotificationManager]::GetTemplateContent([Windows.UI.Notifications.ToastTemplateType]::ToastText02)
-$RawXml = [xml] $Template.GetXml()
-($RawXml.toast.visual.binding.text | Where-Object {$_.id -eq '1'}).AppendChild($RawXml.CreateTextNode('${psTitle}')) | Out-Null
-($RawXml.toast.visual.binding.text | Where-Object {$_.id -eq '2'}).AppendChild($RawXml.CreateTextNode('${psMessage}')) | Out-Null
-$SerializedXml = New-Object Windows.Data.Xml.Dom.XmlDocument
-$SerializedXml.LoadXml($RawXml.OuterXml)
-$Toast = [Windows.UI.Notifications.ToastNotification]::new($SerializedXml)
-$Notifier = [Windows.UI.Notifications.ToastNotificationManager]::CreateToastNotifier('OpenCode')
-$Notifier.Show($Toast)
-`.trim().replace(/\n/g, "; ")
-      await ctx.$`${powershellPath} -Command ${toastScript}`.catch(() => {})
-      break
-    }
-  }
-}
-
-async function playSound(ctx: PluginInput, p: Platform, soundPath: string): Promise<void> {
-  switch (p) {
-    case "darwin": {
-      const afplayPath = await getAfplayPath()
-      if (!afplayPath) return
-      ctx.$`${afplayPath} ${soundPath}`.catch(() => {})
-      break
-    }
-    case "linux": {
-      const paplayPath = await getPaplayPath()
-      if (paplayPath) {
-        ctx.$`${paplayPath} ${soundPath} 2>/dev/null`.catch(() => {})
-      } else {
-        const aplayPath = await getAplayPath()
-        if (aplayPath) {
-          ctx.$`${aplayPath} ${soundPath} 2>/dev/null`.catch(() => {})
-        }
-      }
-      break
-    }
-    case "win32": {
-      const powershellPath = await getPowershellPath()
-      if (!powershellPath) return
-      ctx.$`${powershellPath} -Command ${"(New-Object Media.SoundPlayer '" + soundPath.replace(/'/g, "''") + "').PlaySync()"}`.catch(() => {})
-      break
-    }
-  }
-}
-
-async function hasIncompleteTodos(ctx: PluginInput, sessionID: string): Promise<boolean> {
-  try {
-    const response = await ctx.client.session.todo({ path: { id: sessionID } })
-    const todos = (response.data ?? response) as Todo[]
-    if (!todos || todos.length === 0) return false
-    return todos.some((t) => t.status !== "completed" && t.status !== "cancelled")
-  } catch {
-    return false
-  }
-}
-
 export function createSessionNotification(
   ctx: PluginInput,
   config: SessionNotificationConfig = {}
@@ -159,110 +44,14 @@ export function createSessionNotification(
     ...config,
   }
 
-  const notifiedSessions = new Set<string>()
-  const pendingTimers = new Map<string, ReturnType<typeof setTimeout>>()
-  const sessionActivitySinceIdle = new Set<string>()
-  // Track notification execution version to handle race conditions
-  const notificationVersions = new Map<string, number>()
-  // Track sessions currently executing notification (prevents duplicate execution)
-  const executingNotifications = new Set<string>()
-
-  function cleanupOldSessions() {
-    const maxSessions = mergedConfig.maxTrackedSessions
-    if (notifiedSessions.size > maxSessions) {
-      const sessionsToRemove = Array.from(notifiedSessions).slice(0, notifiedSessions.size - maxSessions)
-      sessionsToRemove.forEach(id => notifiedSessions.delete(id))
-    }
-    if (sessionActivitySinceIdle.size > maxSessions) {
-      const sessionsToRemove = Array.from(sessionActivitySinceIdle).slice(0, sessionActivitySinceIdle.size - maxSessions)
-      sessionsToRemove.forEach(id => sessionActivitySinceIdle.delete(id))
-    }
-    if (notificationVersions.size > maxSessions) {
-      const sessionsToRemove = Array.from(notificationVersions.keys()).slice(0, notificationVersions.size - maxSessions)
-      sessionsToRemove.forEach(id => notificationVersions.delete(id))
-    }
-    if (executingNotifications.size > maxSessions) {
-      const sessionsToRemove = Array.from(executingNotifications).slice(0, executingNotifications.size - maxSessions)
-      sessionsToRemove.forEach(id => executingNotifications.delete(id))
-    }
-  }
-
-  function cancelPendingNotification(sessionID: string) {
-    const timer = pendingTimers.get(sessionID)
-    if (timer) {
-      clearTimeout(timer)
-      pendingTimers.delete(sessionID)
-    }
-    sessionActivitySinceIdle.add(sessionID)
-    // Increment version to invalidate any in-flight notifications
-    notificationVersions.set(sessionID, (notificationVersions.get(sessionID) ?? 0) + 1)
-  }
-
-  function markSessionActivity(sessionID: string) {
-    cancelPendingNotification(sessionID)
-    if (!executingNotifications.has(sessionID)) {
-      notifiedSessions.delete(sessionID)
-    }
-  }
-
-  async function executeNotification(sessionID: string, version: number) {
-    if (executingNotifications.has(sessionID)) {
-      pendingTimers.delete(sessionID)
-      return
-    }
-
-    if (notificationVersions.get(sessionID) !== version) {
-      pendingTimers.delete(sessionID)
-      return
-    }
-
-    if (sessionActivitySinceIdle.has(sessionID)) {
-      sessionActivitySinceIdle.delete(sessionID)
-      pendingTimers.delete(sessionID)
-      return
-    }
-
-    if (notifiedSessions.has(sessionID)) {
-      pendingTimers.delete(sessionID)
-      return
-    }
-
-    executingNotifications.add(sessionID)
-    try {
-      if (mergedConfig.skipIfIncompleteTodos) {
-        const hasPendingWork = await hasIncompleteTodos(ctx, sessionID)
-        if (notificationVersions.get(sessionID) !== version) {
-          return
-        }
-        if (hasPendingWork) return
-      }
-
-      if (notificationVersions.get(sessionID) !== version) {
-        return
-      }
-
-      if (sessionActivitySinceIdle.has(sessionID)) {
-        sessionActivitySinceIdle.delete(sessionID)
-        return
-      }
-
-      notifiedSessions.add(sessionID)
-
-      await sendNotification(ctx, currentPlatform, mergedConfig.title, mergedConfig.message)
-
-      if (mergedConfig.playSound && mergedConfig.soundPath) {
-        await playSound(ctx, currentPlatform, mergedConfig.soundPath)
-      }
-    } finally {
-      executingNotifications.delete(sessionID)
-      pendingTimers.delete(sessionID)
-      // Clear notified state if there was activity during notification
-      if (sessionActivitySinceIdle.has(sessionID)) {
-        notifiedSessions.delete(sessionID)
-        sessionActivitySinceIdle.delete(sessionID)
-      }
-    }
-  }
+  const scheduler = createIdleNotificationScheduler({
+    ctx,
+    platform: currentPlatform,
+    config: mergedConfig,
+    hasIncompleteTodos,
+    send: sendSessionNotification,
+    playSound: playSessionNotificationSound,
+  })
 
   return async ({ event }: { event: { type: string; properties?: unknown } }) => {
     if (currentPlatform === "unsupported") return
@@ -273,7 +62,7 @@ export function createSessionNotification(
       const info = props?.info as Record<string, unknown> | undefined
       const sessionID = info?.id as string | undefined
       if (sessionID) {
-        markSessionActivity(sessionID)
+        scheduler.markSessionActivity(sessionID)
       }
       return
     }
@@ -288,21 +77,7 @@ export function createSessionNotification(
       const mainSessionID = getMainSessionID()
       if (mainSessionID && sessionID !== mainSessionID) return
 
-      if (notifiedSessions.has(sessionID)) return
-      if (pendingTimers.has(sessionID)) return
-      if (executingNotifications.has(sessionID)) return
-
-      sessionActivitySinceIdle.delete(sessionID)
-      
-      const currentVersion = (notificationVersions.get(sessionID) ?? 0) + 1
-      notificationVersions.set(sessionID, currentVersion)
-
-      const timer = setTimeout(() => {
-        executeNotification(sessionID, currentVersion)
-      }, mergedConfig.idleConfirmationDelay)
-
-      pendingTimers.set(sessionID, timer)
-      cleanupOldSessions()
+      scheduler.scheduleIdleNotification(sessionID)
       return
     }
 
@@ -310,7 +85,7 @@ export function createSessionNotification(
       const info = props?.info as Record<string, unknown> | undefined
       const sessionID = info?.sessionID as string | undefined
       if (sessionID) {
-        markSessionActivity(sessionID)
+        scheduler.markSessionActivity(sessionID)
       }
       return
     }
@@ -318,7 +93,7 @@ export function createSessionNotification(
     if (event.type === "tool.execute.before" || event.type === "tool.execute.after") {
       const sessionID = props?.sessionID as string | undefined
       if (sessionID) {
-        markSessionActivity(sessionID)
+        scheduler.markSessionActivity(sessionID)
       }
       return
     }
@@ -326,11 +101,7 @@ export function createSessionNotification(
     if (event.type === "session.deleted") {
       const sessionInfo = props?.info as { id?: string } | undefined
       if (sessionInfo?.id) {
-        cancelPendingNotification(sessionInfo.id)
-        notifiedSessions.delete(sessionInfo.id)
-        sessionActivitySinceIdle.delete(sessionInfo.id)
-        notificationVersions.delete(sessionInfo.id)
-        executingNotifications.delete(sessionInfo.id)
+        scheduler.deleteSession(sessionInfo.id)
       }
     }
   }