fix(todo): make Todo id field optional for OpenCode beta compatibility

- Make id field optional in all Todo interfaces (TodoInfo, Todo, TodoItem)
- Fix null-unsafe comparisons in todo-sync.ts to handle missing ids
- Add test case for todos without id field preservation
- All tests pass and typecheck clean
This commit is contained in:
YeonGyu-Kim
2026-02-14 17:41:40 +09:00
parent cb4a165c76
commit e90734d6d9
14 changed files with 180 additions and 98 deletions
+15 -6
View File
@@ -471,7 +471,7 @@ describe("syncAllTasksToTodos", () => {
expect(mockCtx.client.session.todo).toHaveBeenCalled();
});
it("handles undefined sessionID", async () => {
it("preserves todos without id field", async () => {
// given
const tasks: Task[] = [
{
@@ -483,14 +483,23 @@ describe("syncAllTasksToTodos", () => {
blockedBy: [],
},
];
mockCtx.client.session.todo.mockResolvedValue([]);
const currentTodos: TodoInfo[] = [
{
id: "T-1",
content: "Task 1",
status: "pending",
},
{
content: "Todo without id",
status: "pending",
},
];
mockCtx.client.session.todo.mockResolvedValue(currentTodos);
// when
await syncAllTasksToTodos(mockCtx, tasks);
await syncAllTasksToTodos(mockCtx, tasks, "session-1");
// then
expect(mockCtx.client.session.todo).toHaveBeenCalledWith({
path: { id: "" },
});
expect(mockCtx.client.session.todo).toHaveBeenCalled();
});
});
+4 -4
View File
@@ -3,7 +3,7 @@ import { log } from "../../shared/logger";
import type { Task } from "../../features/claude-tasks/types.ts";
export interface TodoInfo {
id: string;
id?: string;
content: string;
status: "pending" | "in_progress" | "completed" | "cancelled";
priority?: "low" | "medium" | "high";
@@ -100,7 +100,7 @@ export async function syncTaskTodoUpdate(
path: { id: sessionID },
});
const currentTodos = extractTodos(response);
const nextTodos = currentTodos.filter((todo) => todo.id !== task.id);
const nextTodos = currentTodos.filter((todo) => !todo.id || todo.id !== task.id);
const todo = syncTaskToTodo(task);
if (todo) {
@@ -150,10 +150,10 @@ export async function syncAllTasksToTodos(
}
const finalTodos: TodoInfo[] = [];
const newTodoIds = new Set(newTodos.map((t) => t.id));
const newTodoIds = new Set(newTodos.map((t) => t.id).filter((id) => id !== undefined));
for (const existing of currentTodos) {
if (!newTodoIds.has(existing.id) && !tasksToRemove.has(existing.id)) {
if ((!existing.id || !newTodoIds.has(existing.id)) && !tasksToRemove.has(existing.id || "")) {
finalTodos.push(existing);
}
}