From eb4060d739edc5f0914d38fd071ff466dce47b30 Mon Sep 17 00:00:00 2001 From: YeonGyu-Kim Date: Sat, 4 Apr 2026 16:56:39 +0900 Subject: [PATCH] fix(test): narrow mock.module() targets in background-agent tests to prevent barrel corruption Three test files were mocking the entire '../../shared' barrel, which corrupted exports for subsequent test files in the same batch run. Narrow mocks to specific submodules (logger, connected-providers-cache). Also reverts Bun version pin since the root cause was mock scope, not Bun. --- .github/workflows/ci.yml | 8 ++++---- .github/workflows/publish.yml | 8 ++++---- src/features/background-agent/abort-with-timeout.test.ts | 2 +- .../background-agent/fallback-retry-handler.test.ts | 5 ++++- .../background-agent/session-status-classifier.test.ts | 2 +- 5 files changed, 14 insertions(+), 11 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c07fc74e5..53959d5e7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -39,7 +39,7 @@ jobs: - uses: oven-sh/setup-bun@v2 with: - bun-version: 1.3.10 + bun-version: latest - name: Install dependencies run: bun install @@ -56,7 +56,7 @@ jobs: - uses: oven-sh/setup-bun@v2 with: - bun-version: 1.3.10 + bun-version: latest - name: Install dependencies run: bun install @@ -81,7 +81,7 @@ jobs: - uses: oven-sh/setup-bun@v2 with: - bun-version: 1.3.10 + bun-version: latest - name: Install dependencies run: bun install @@ -124,7 +124,7 @@ jobs: - uses: oven-sh/setup-bun@v2 with: - bun-version: 1.3.10 + bun-version: latest - name: Generate release notes id: notes diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index db922577a..37b3a7a3b 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -38,7 +38,7 @@ jobs: - uses: oven-sh/setup-bun@v2 with: - bun-version: 1.3.10 + bun-version: latest - name: Install dependencies run: bun install @@ -55,7 +55,7 @@ jobs: - uses: oven-sh/setup-bun@v2 with: - bun-version: 1.3.10 + bun-version: latest - name: Install dependencies run: bun install @@ -81,7 +81,7 @@ jobs: - uses: oven-sh/setup-bun@v2 with: - bun-version: 1.3.10 + bun-version: latest - uses: actions/setup-node@v4 with: @@ -244,7 +244,7 @@ jobs: - uses: oven-sh/setup-bun@v2 with: - bun-version: 1.3.10 + bun-version: latest - name: Install dependencies run: bun install diff --git a/src/features/background-agent/abort-with-timeout.test.ts b/src/features/background-agent/abort-with-timeout.test.ts index cd1aa82d9..3655a4172 100644 --- a/src/features/background-agent/abort-with-timeout.test.ts +++ b/src/features/background-agent/abort-with-timeout.test.ts @@ -2,7 +2,7 @@ import { afterAll, describe, expect, mock, test } from "bun:test" const logMock = mock(() => {}) -mock.module("../../shared", () => ({ +mock.module("../../shared/logger", () => ({ log: logMock, })) diff --git a/src/features/background-agent/fallback-retry-handler.test.ts b/src/features/background-agent/fallback-retry-handler.test.ts index 4932093b7..689785ba2 100644 --- a/src/features/background-agent/fallback-retry-handler.test.ts +++ b/src/features/background-agent/fallback-retry-handler.test.ts @@ -1,7 +1,10 @@ import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test" -mock.module("../../shared", () => ({ +mock.module("../../shared/logger", () => ({ log: mock(() => {}), +})) + +mock.module("../../shared/connected-providers-cache", () => ({ readConnectedProvidersCache: mock(() => null), readProviderModelsCache: mock(() => null), })) diff --git a/src/features/background-agent/session-status-classifier.test.ts b/src/features/background-agent/session-status-classifier.test.ts index d3dc36aa7..c5d322315 100644 --- a/src/features/background-agent/session-status-classifier.test.ts +++ b/src/features/background-agent/session-status-classifier.test.ts @@ -1,7 +1,7 @@ import { describe, test, expect, mock, afterAll } from "bun:test" const mockLog = mock() -mock.module("../../shared", () => ({ log: mockLog })) +mock.module("../../shared/logger", () => ({ log: mockLog })) afterAll(() => { mock.restore() })