luna/oh-my-opencode
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(agents): prevent orchestrator from rushing ahead of background agents

Browse Source 
Tighten Background Result Collection instructions so the model waits
for explore/librarian results instead of duplicating their work and
delivering premature answers.

- Remove 'Continue working immediately' which models interpreted as
  'do ALL work yourself, ignore agents'
- Clarify step 2: only do DIFFERENT independent work while waiting
- Add explicit step 3: end response when no other work remains
- Add 'not for files you already know' to explore section header

Fixes #2124, fixes #1967
This commit is contained in:
mrosnerr
2026-03-05 12:57:39 -05:00
committed by YeonGyu-Kim
parent eb43bd7c43
commit ed76f883b6
2 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/agents/dynamic-agent-prompt-builder.ts
+1 -1
View File
@@ -116,7 +116,7 @@ export function buildExploreSection(agents: AvailableAgent[]): string {
return `### Explore Agent = Contextual Grep return `### Explore Agent = Contextual Grep
Use it as a **peer tool**, not a fallback. Fire liberally. Use it as a **peer tool**, not a fallback. Fire liberally for discovery, not for files you already know.
**Use Direct Tools when:** **Use Direct Tools when:**
${avoidWhen.map((w) => `- ${w}`).join("\n")} ${avoidWhen.map((w) => `- ${w}`).join("\n")}
src/agents/sisyphus.ts
+5 -6
View File
@@ -225,18 +225,17 @@ task(subagent_type="explore", run_in_background=true, load_skills=[], descriptio
// Reference Grep (external) // Reference Grep (external)
task(subagent_type="librarian", run_in_background=true, load_skills=[], description="Find JWT security docs", prompt="I'm implementing JWT auth and need current security best practices to choose token storage (httpOnly cookies vs localStorage) and set expiration policy. Find: OWASP auth guidelines, recommended token lifetimes, refresh token rotation strategies, common JWT vulnerabilities. Skip 'what is JWT' tutorials — production security guidance only.") task(subagent_type="librarian", run_in_background=true, load_skills=[], description="Find JWT security docs", prompt="I'm implementing JWT auth and need current security best practices to choose token storage (httpOnly cookies vs localStorage) and set expiration policy. Find: OWASP auth guidelines, recommended token lifetimes, refresh token rotation strategies, common JWT vulnerabilities. Skip 'what is JWT' tutorials — production security guidance only.")
task(subagent_type="librarian", run_in_background=true, load_skills=[], description="Find Express auth patterns", prompt="I'm building Express auth middleware and need production-quality patterns to structure my middleware chain. Find how established Express apps (1000+ stars) handle: middleware ordering, token refresh, role-based access control, auth error propagation. Skip basic tutorials — I need battle-tested patterns with proper error handling.") task(subagent_type="librarian", run_in_background=true, load_skills=[], description="Find Express auth patterns", prompt="I'm building Express auth middleware and need production-quality patterns to structure my middleware chain. Find how established Express apps (1000+ stars) handle: middleware ordering, token refresh, role-based access control, auth error propagation. Skip basic tutorials — I need battle-tested patterns with proper error handling.")
// Continue working immediately. System notifies on completion — collect with background_output then.
// WRONG: Sequential or blocking // WRONG: Sequential or blocking
result = task(..., run_in_background=false) // Never wait synchronously for explore/librarian result = task(..., run_in_background=false) // Never wait synchronously for explore/librarian
\`\`\` \`\`\`
### Background Result Collection: ### Background Result Collection:
1. Launch parallel agents \u2192 receive task_ids 1. Launch parallel agents \u2192 receive task_ids
2. Continue immediate work 2. If you have DIFFERENT independent work \u2192 do it now
3. System sends \`<system-reminder>\` on each task completion — then call \`background_output(task_id="...")\` 3. Otherwise \u2192 **END YOUR RESPONSE.**
4. Need results not yet ready? **End your response.** The notification will trigger your next turn. 4. System sends \`<system-reminder>\` on completion \u2192 triggers your next turn
5. Cleanup: Cancel disposable tasks individually via \`background_cancel(taskId="...")\` 5. Collect via \`background_output(task_id="...")\`
6. Cleanup: Cancel disposable tasks individually via \`background_cancel(taskId="...")\`
### Search Stop Conditions ### Search Stop Conditions