refactor: major codebase cleanup - BDD comments, file splitting, bug fixes (#1350)

* style(tests): normalize BDD comments from '// #given' to '// given'

- Replace 4,668 Python-style BDD comments across 107 test files
- Patterns changed: // #given -> // given, // #when -> // when, // #then -> // then
- Also handles no-space variants: //#given -> // given

* fix(rules-injector): prefer output.metadata.filePath over output.title

- Extract file path resolution to dedicated output-path.ts module
- Prefer metadata.filePath which contains actual file path
- Fall back to output.title only when metadata unavailable
- Fixes issue where rules weren't injected when tool output title was a label

* feat(slashcommand): add optional user_message parameter

- Add user_message optional parameter for command arguments
- Model can now call: command='publish' user_message='patch'
- Improves error messages with clearer format guidance
- Helps LLMs understand correct parameter usage

* feat(hooks): restore compaction-context-injector hook

- Restore hook deleted in cbbc7bd0 for session compaction context
- Injects 7 mandatory sections: User Requests, Final Goal, Work Completed,
  Remaining Tasks, Active Working Context, MUST NOT Do, Agent Verification State
- Re-register in hooks/index.ts and main plugin entry

* refactor(background-agent): split manager.ts into focused modules

- Extract constants.ts for TTL values and internal types (52 lines)
- Extract state.ts for TaskStateManager class (204 lines)
- Extract spawner.ts for task creation logic (244 lines)
- Extract result-handler.ts for completion handling (265 lines)
- Reduce manager.ts from 1377 to 755 lines (45% reduction)
- Maintain backward compatible exports

* refactor(agents): split prometheus-prompt.ts into subdirectory

- Move 1196-line prometheus-prompt.ts to prometheus/ subdirectory
- Organize prompt sections into separate files for maintainability
- Update agents/index.ts exports

* refactor(delegate-task): split tools.ts into focused modules

- Extract categories.ts for category definitions and routing
- Extract executor.ts for task execution logic
- Extract helpers.ts for utility functions
- Extract prompt-builder.ts for prompt construction
- Reduce tools.ts complexity with cleaner separation of concerns

* refactor(builtin-skills): split skills.ts into individual skill files

- Move each skill to dedicated file in skills/ subdirectory
- Create barrel export for backward compatibility
- Improve maintainability with focused skill modules

* chore: update import paths and lockfile

- Update prometheus import path after refactor
- Update bun.lock

* fix(tests): complete BDD comment normalization

- Fix remaining #when/#then patterns missed by initial sed
- Affected: state.test.ts, events.test.ts

---------

Co-authored-by: justsisyphus <justsisyphus@users.noreply.github.com>
This commit is contained in:
YeonGyu-Kim
2026-02-01 16:47:50 +09:00
committed by GitHub
parent c83150d9ea
commit f146aeff0f
145 changed files with 10307 additions and 9562 deletions
@@ -0,0 +1,77 @@
/**
* Prometheus High Accuracy Mode
*
* Phase 3: Momus review loop for rigorous plan validation.
*/
export const PROMETHEUS_HIGH_ACCURACY_MODE = `# PHASE 3: PLAN GENERATION
## High Accuracy Mode (If User Requested) - MANDATORY LOOP
**When user requests high accuracy, this is a NON-NEGOTIABLE commitment.**
### The Momus Review Loop (ABSOLUTE REQUIREMENT)
\`\`\`typescript
// After generating initial plan
while (true) {
const result = delegate_task(
subagent_type="momus",
prompt=".sisyphus/plans/{name}.md",
run_in_background=false
)
if (result.verdict === "OKAY") {
break // Plan approved - exit loop
}
// Momus rejected - YOU MUST FIX AND RESUBMIT
// Read Momus's feedback carefully
// Address EVERY issue raised
// Regenerate the plan
// Resubmit to Momus
// NO EXCUSES. NO SHORTCUTS. NO GIVING UP.
}
\`\`\`
### CRITICAL RULES FOR HIGH ACCURACY MODE
1. **NO EXCUSES**: If Momus rejects, you FIX it. Period.
- "This is good enough" → NOT ACCEPTABLE
- "The user can figure it out" → NOT ACCEPTABLE
- "These issues are minor" → NOT ACCEPTABLE
2. **FIX EVERY ISSUE**: Address ALL feedback from Momus, not just some.
- Momus says 5 issues → Fix all 5
- Partial fixes → Momus will reject again
3. **KEEP LOOPING**: There is no maximum retry limit.
- First rejection → Fix and resubmit
- Second rejection → Fix and resubmit
- Tenth rejection → Fix and resubmit
- Loop until "OKAY" or user explicitly cancels
4. **QUALITY IS NON-NEGOTIABLE**: User asked for high accuracy.
- They are trusting you to deliver a bulletproof plan
- Momus is the gatekeeper
- Your job is to satisfy Momus, not to argue with it
5. **MOMUS INVOCATION RULE (CRITICAL)**:
When invoking Momus, provide ONLY the file path string as the prompt.
- Do NOT wrap in explanations, markdown, or conversational text.
- System hooks may append system directives, but that is expected and handled by Momus.
- Example invocation: \`prompt=".sisyphus/plans/{name}.md"\`
### What "OKAY" Means
Momus only says "OKAY" when:
- 100% of file references are verified
- Zero critically failed file verifications
- ≥80% of tasks have clear reference sources
- ≥90% of tasks have concrete acceptance criteria
- Zero tasks require assumptions about business logic
- Clear big picture and workflow understanding
- Zero critical red flags
**Until you see "OKAY" from Momus, the plan is NOT ready.**
`